[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-08-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Fridolin Somers  changed:

   What|Removed |Added

 CC||[email protected]
   ||m
 Status|Pushed to main  |Pushed to stable
 Version(s)|25.05.00|25.05.00,24.11.08
released in||

--- Comment #19 from Fridolin Somers  ---
Pushed to 24.11.x for 24.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-06-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Blocks||39926


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39926
[Bug 39926] Block users without edit_catalogue permission from deleting the
record if no items remain from the batch item deletion tool at the script level
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-06-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Blocks|39926   |

--- Comment #18 from Lucas Gass (lukeg)  ---
(In reply to Catrina Berka from comment #17)
> Can we get this backported to 24.11?

Marked it as a candidate for 24.11. Now it will be up to the release
maintainer.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39926
[Bug 39926] Block users without edit_catalogue permission from deleting the
record if no items remain from the batch item deletion tool at the script level
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-06-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Blocks||39926


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39926
[Bug 39926] Block users without edit_catalogue permission from deleting the
record if no items remain from the batch item deletion tool at the script level
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-06-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Lucas Gass (lukeg)  changed:

   What|Removed |Added

   Keywords||rel_24_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-06-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #17 from Catrina Berka  ---
Can we get this backported to 24.11?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #16 from Katrin Fischer  ---
(In reply to Lucas Gass (lukeg) from comment #15)
> (In reply to Katrin Fischer from comment #14)
> > (In reply to Katrin Fischer from comment #5)
> > > Is it really enough to remove the checkbox here? Should we not also check
> > > for the flag in the script itself?
> > 
> > What about this question?
> 
> I 100% agree, I opened Bug 39926 and assigned it to myself. I will get a
> patch up ASAP!

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #14 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #5)
> Is it really enough to remove the checkbox here? Should we not also check
> for the flag in the script itself?

What about this question?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #13 from Katrin Fischer  ---
(In reply to Anneli Österman from comment #12)
> Sorry about the delay. We are fine with backporting. We will take our own
> actions if it is needed when the time comes. :)

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #12 from Anneli Österman  ---
Sorry about the delay. We are fine with backporting. We will take our own
actions if it is needed when the time comes. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Blocks|39926   |

--- Comment #15 from Lucas Gass (lukeg)  ---
(In reply to Katrin Fischer from comment #14)
> (In reply to Katrin Fischer from comment #5)
> > Is it really enough to remove the checkbox here? Should we not also check
> > for the flag in the script itself?
> 
> What about this question?

I 100% agree, I opened Bug 39926 and assigned it to myself. I will get a patch
up ASAP!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39926
[Bug 39926] Blocker users without edit_catalogue permission from deleting the
record if no items remain from the batch item deletion tool at the script level
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Blocks||39926


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39926
[Bug 39926] Blocker users without edit_catalogue permission from deleting the
record if no items remain from the batch item deletion tool at the script level
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #11 from Anneli Österman  ---
I will discuss about this with colleagues tomorrow, they can make a more
accurate assessment than I can. Thank you for your concern! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #10 from Katrin Fischer  ---
My worry is that since this is marked "major" it will be backported to all
older releases - so it could hit you sooner with a security update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #9 from Anneli Österman  ---
This won't be an immediate problem for us because we do not update to newer
version in a while (we have a quite slow update schedule except for security
updates). Maybe the new permission has been added before our next update. 

I found bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 and
commented on that one too. We will surely help with it - at the very least by
testing it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #8 from Katrin Fischer  ---
(In reply to Anneli Österman from comment #7)
> It seems I'm a bit late with my comment but we have used item batch deletion
> to delete bibliographic records on purpose. We do not want to give the
> edit_catalogue permission to everyone who needs to delete records because it
> also gives them the permission to edit records (wicht nowadays takes lots of
> professional competence).
> 
> With this change we would need a new permission delete_catalogue (or
> delete_biblio_records) to obtain our current way of deleting bibliographic
> records.

Hi Anneli, thanks for reaching out. 

I am sorry, that this creates a problem for your workflow and I can understand
your point. I checked and was surprised to only find your new bug and no older
requests for this.

I'd like to find a solution that works for all use cases, but developing a new
permission at this point in cycle is a bit tricky, as we'd have to change a lot
of other places too.

This has been marked as major, so for some libraries it's bad... and for you
the change is bad. We are in a bit of a hard stop. What we could do is maybe
halt off backporting for a bit?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Anneli Österman  changed:

   What|Removed |Added

 CC||anneli.osterman@koha-suomi.
   ||fi

--- Comment #7 from Anneli Österman  ---
It seems I'm a bit late with my comment but we have used item batch deletion to
delete bibliographic records on purpose. We do not want to give the
edit_catalogue permission to everyone who needs to delete records because it
also gives them the permission to edit records (wicht nowadays takes lots of
professional competence).

With this change we would need a new permission delete_catalogue (or
delete_biblio_records) to obtain our current way of deleting bibliographic
records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||25.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

--- Comment #6 from Katrin Fischer  ---
Pushed for 25.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #5 from Katrin Fischer  ---
Is it really enough to remove the checkbox here? Should we not also check for
the flag in the script itself?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39848] Users without edit_catalogue permission can delete the record if no items remain from the batch item deletion tool

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848

Katrin Fischer  changed:

   What|Removed |Added

Summary|Unauthorized users can  |Users without
   |delete the record if no |edit_catalogue permission
   |items remain from the batch |can delete the record if no
   |item deletion tool  |items remain from the batch
   ||item deletion tool

--- Comment #4 from Katrin Fischer  ---
Updated description slightly - unauthorized would be a bit worse :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/