[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 David Nind changed: What|Removed |Added Text to go in the||This fixes the ILL request release notes||history check (added in ||Koha 25.05 by bug 38441 - ||Allow for an ILL history ||check workflow stage). If ||there is no patron, or it ||is an unauthenticated ||request, then the check to ||see if the same request has ||been made is no longer ||performed (requires ||enbaling the ||ILLHistoryCheck system ||preference). CC||da...@davidnind.com --- Comment #15 from David Nind --- Attempted a release note - please update it if I haven't got it right. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 --- Comment #14 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Paul Derscheid changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.01 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 --- Comment #13 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 --- Comment #12 from Pedro Amorim --- Created attachment 183065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183065&action=edit Bug 39875: (QA follow-up): Correct historycheck ui_context This ui_context is supposed to be opac, not staff. For the purposes of these tests, this is not important, as the ui_context is only needed for the template params and this is testing if the history check stage is supposed to show or not. Reckon this was a copy paste without consequences hence missed, but the code is now semantically more correct. prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Marcel de Rooy changed: What|Removed |Added QA Contact|tomasco...@gmail.com|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Marcel de Rooy changed: What|Removed |Added Attachment #182859|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 183052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183052&action=edit Bug 39875: Dont show history check Unless there is a cardnumber or an authenticated user Test plan: 1) Apply only the the tests file highlighting the issue: prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 2) Notice it fails. 3) Apply this patch. 4) Run tests again. Notice it passes. Signed-off-by: David Nind Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Marcel de Rooy changed: What|Removed |Added Attachment #182858|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 183051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183051&action=edit Bug 39875: Add tests Signed-off-by: David Nind Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Pedro Amorim changed: What|Removed |Added Attachment #182296|0 |1 is obsolete|| --- Comment #9 from Pedro Amorim --- Created attachment 182859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182859&action=edit Bug 39875: Dont show history check Unless there is a cardnumber or an authenticated user Test plan: 1) Apply only the the tests file highlighting the issue: prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 2) Notice it fails. 3) Apply this patch. 4) Run tests again. Notice it passes. Signed-off-by: David Nind Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Pedro Amorim changed: What|Removed |Added Attachment #182295|0 |1 is obsolete|| --- Comment #8 from Pedro Amorim --- Created attachment 182858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182858&action=edit Bug 39875: Add tests Signed-off-by: David Nind Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #7 from Marcel de Rooy --- FAIL Koha/ILL/Request/Workflow/HistoryCheck.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/ILL/Request/Workflow/HistoryCheck.pm` FAIL t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Martin Renvoize (ashimema) changed: What|Removed |Added CC||martin.renvoize@openfifth.c ||o.uk Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182291|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Lin Wei changed: What|Removed |Added Attachment #182292|0 |1 is obsolete|| --- Comment #6 from Lin Wei --- Created attachment 182296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182296&action=edit Bug 39875: Dont show history check Unless there is a cardnumber or an authenticated user Test plan: 1) Apply only the the tests file highlighting the issue: prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 2) Notice it fails. 3) Apply this patch. 4) Run tests again. Notice it passes. Signed-off-by: David Nind Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 --- Comment #5 from Lin Wei --- Created attachment 182295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182295&action=edit Bug 39875: Add tests Signed-off-by: David Nind Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 David Nind changed: What|Removed |Added Attachment #182274|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 182292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182292&action=edit Bug 39875: Dont show history check Unless there is a cardnumber or an authenticated user Test plan: 1) Apply only the the tests file highlighting the issue: prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 2) Notice it fails. 3) Apply this patch. 4) Run tests again. Notice it passes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 David Nind changed: What|Removed |Added Attachment #182273|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 182291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182291&action=edit Bug 39875: Add tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Pedro Amorim changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | Patch complexity|--- |Trivial patch Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |pedro.amo...@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 --- Comment #2 from Pedro Amorim --- Created attachment 182274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182274&action=edit Bug 39875: Dont show history check Unless there is a cardnumber or an authenticated user Test plan: 1) Apply only the the tests file highlighting the issue: prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 2) Notice it fails. 3) Apply this patch. 4) Run tests again. Notice it passes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 --- Comment #1 from Pedro Amorim --- Created attachment 182273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182273&action=edit Bug 39875: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39875] ILL - History check fails if unauthenticated request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
