[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #39 from Fridolin Somers --- (In reply to Katrin Fischer from comment #38) > I can see a patch with this commit line in the 24.11.18 release (just doing > my rebase) - looks like a bug number confusion: > > Bug 39900: Preparation: Refactor public_query_search_params for reusability > > So is this really pushed/fixed? Sounds like this has been done to allow easy backport of : Bug 42866: Prevent SQL injection in Koha::AddtionalContents->search_for_display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Emily Lamancusa (emlam) changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #37 from Emily Lamancusa (emlam) --- From what I can tell (from testing and digging into the code), the public API endpoint only exposes additional contents that were already publicly visible by an unauthenticated user on the OPAC, right? If that's correct, can the release notes be updated to reflect that? (too late for the release news posts, of course, but might still be helpful for other libraries who are upgrading now or later and wonder like I did whether they need to audit all of their staff interface HTML customizations before upgrading!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Owen Leonard changed: What|Removed |Added Blocks||41614 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41614 [Bug 41614] additional_contents REST endpoint broke the display location filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 David Nind changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #36 from David Nind --- REST API related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Needs documenting CC||[email protected] ||m --- Comment #35 from Fridolin Somers --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Martin Renvoize (ashimema) changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Martin Renvoize (ashimema) changed: What|Removed |Added CC||[email protected] ||o.uk Text to go in the||A new public REST API release notes||endpoint has been added for ||retrieving additional ||contents (news items and ||HTML customisations) ||without authentication. ||This enables external ||applications and websites ||to access and display Koha ||news and custom content. || ||**Endpoint details:** ||- **Path:** ||`/api/v1/public/additional_ ||contents` ||- **Method:** GET ||- **Authentication:** None ||required (public endpoint) ||- **Query parameters:** || - Standard search and ||filter parameters for ||finding specific content || - `lang`: Filter by ||language code to retrieve ||content in a specific ||language || - `embed`: Use ||`translated_contents` to ||include all available ||translations || ||**Key features:** || ||- **Public access**: No ||authentication required, ||making it suitable for ||displaying library news on ||external websites ||- **Multi-language ||support**: Retrieve content ||in specific languages or ||fetch all translations at ||once using the ||`translated_contents` embed ||- **Flexible filtering**: ||Search and filter ||additional contents using ||standard API query ||parameters ||- **Content types**: Access ||both news items and HTML ||customisations through the ||same endpoint || ||**For developers:** || ||This endpoint follows the ||same patterns as other Koha ||public API endpoints. Use ||the `lang` parameter to ||retrieve content for a ||specific language, or use ||`embed=translated_contents` ||to get all available ||translations in a single ||request. This is |
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #34 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.04 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #33 from Lucas Gass (lukeg) --- follow-up's pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #32 from Lucas Gass (lukeg) --- Created attachment 185455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185455&action=edit Bug 39900: (follow-up) Add a newline to end of additional_contents.yaml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #31 from Tomás Cohen Arazi (tcohen) --- Created attachment 185453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185453&action=edit Bug 39900: (QA follow-up) Add missing tag description Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #30 from Lucas Gass (lukeg) --- There are a few failures due to this bug, I think: xt/api.t is failing: # Failed test 'No tag errors in the spec' # at /kohadevbox/koha/xt/api.t line 128. # Structures begin differing at: # $got->[0] = 'get /public/additional_contents -> uses tag 'additional_contents' not present in top level list' # $expected->[0] = Does not exist get /public/additional_contents -> uses tag 'additional_contents' not present in top level list # Looks like you failed 1 test of 1. not ok 4 - tags tests And also: xt_find_missing_new_lines_at_the_end_of_file_t.api/v1/swagger/paths/additional_contents.yaml should end with a new line (504) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected] Keywords||release-notes-needed --- Comment #29 from Lucas Gass (lukeg) --- Can you please add release notes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #28 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Attachment #184979|0 |1 is obsolete|| --- Comment #27 from Marcel de Rooy --- Created attachment 185086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185086&action=edit Bug 39900: (QA follow-up): Add translated_contents to tests Also add tests to searching for specific language code prove t/db_dependent/api/v1/additional_contents.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Attachment #184726|0 |1 is obsolete|| --- Comment #26 from Marcel de Rooy --- Created attachment 185085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185085&action=edit Bug 39900: Add tests prove t/db_dependent/api/v1/additional_contents.t Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Attachment #184725|0 |1 is obsolete|| --- Comment #25 from Marcel de Rooy --- Created attachment 185084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185084&action=edit Bug 39900: Add translated_contents embed Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Attachment #184724|0 |1 is obsolete|| --- Comment #24 from Marcel de Rooy --- Created attachment 185083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185083&action=edit Bug 39900: REST API specs and class changes Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Attachment #184723|0 |1 is obsolete|| --- Comment #23 from Marcel de Rooy --- Created attachment 185082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185082&action=edit Bug 39900: Preparation: Move html customizations options to class for reusability Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Attachment #184722|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 185081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185081&action=edit Bug 39900: Preparation: Refactor public_query_search_params for reusability Ensure no regressions are introduced, run: prove t/db_dependent/Koha/AdditionalContents.t Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Attachment #184978|0 |1 is obsolete|| --- Comment #21 from Pedro Amorim --- Created attachment 184979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184979&action=edit Bug 39900: (QA follow-up): Add translated_contents to tests Also add tests to searching for specific language code prove t/db_dependent/api/v1/additional_contents.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #20 from Pedro Amorim --- Created attachment 184978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184978&action=edit Bug 39900: (QA follow-up): Add translated_contents to tests Also add tests to searching for specific language code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #19 from Marcel de Rooy --- Looks good to me. Two questions remaining: [1] The test with the translation embed should imo contain some translation data. Now we are just comparing empty arrays. So add two translations to Localizations. [2] What I am actually missing is the possibility to ask for a specific translation by passing a language code. Now translated_contents just contains everything and the receiver should open all elements to check the language. Changing status to reflect need for feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added QA Contact|[email protected]|[email protected] Status|Signed Off |BLOCKED --- Comment #18 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Attachment #182888|0 |1 is obsolete|| --- Comment #14 from Pedro Amorim --- Created attachment 184723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184723&action=edit Bug 39900: Preparation: Move html customizations options to class for reusability Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Attachment #182891|0 |1 is obsolete|| --- Comment #17 from Pedro Amorim --- Created attachment 184726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184726&action=edit Bug 39900: Add tests prove t/db_dependent/api/v1/additional_contents.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Attachment #182890|0 |1 is obsolete|| --- Comment #16 from Pedro Amorim --- Created attachment 184725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184725&action=edit Bug 39900: Add translated_contents embed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Attachment #182889|0 |1 is obsolete|| --- Comment #15 from Pedro Amorim --- Created attachment 184724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184724&action=edit Bug 39900: REST API specs and class changes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Attachment #182887|0 |1 is obsolete|| --- Comment #13 from Pedro Amorim --- Created attachment 184722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184722&action=edit Bug 39900: Preparation: Refactor public_query_search_params for reusability Ensure no regressions are introduced, run: prove t/db_dependent/Koha/AdditionalContents.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #12 from Marcel de Rooy --- Applying: Bug 39900: Preparation: Move html customizations options to class for reusability error: sha1 information is lacking or useless (Koha/AdditionalContents.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Brendan Lawlor changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 David Nind changed: What|Removed |Added Attachment #182443|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 182891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182891&action=edit Bug 39900: Add tests prove t/db_dependent/api/v1/additional_contents.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 David Nind changed: What|Removed |Added CC||[email protected] --- Comment #11 from David Nind --- I tested by running the tests. If this is insufficient, please change the status back to needs signoff. Testing notes (using KTD): 1. Apply the patches. 2. Rebuild everything (not sure that this step is required): yarn build 3. Ran the tests and these passed: - prove t/db_dependent/Koha/AdditionalContents.t - prove t/db_dependent/api/v1/additional_contents.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 David Nind changed: What|Removed |Added Attachment #182442|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 182890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182890&action=edit Bug 39900: Add translated_contents embed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 David Nind changed: What|Removed |Added Attachment #182440|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 182888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182888&action=edit Bug 39900: Preparation: Move html customizations options to class for reusability Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 David Nind changed: What|Removed |Added Attachment #182441|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 182889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182889&action=edit Bug 39900: REST API specs and class changes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 David Nind changed: What|Removed |Added Attachment #182439|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 182887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182887&action=edit Bug 39900: Preparation: Refactor public_query_search_params for reusability Ensure no regressions are introduced, run: prove t/db_dependent/Koha/AdditionalContents.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added CC||[email protected], ||[email protected] ||k -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #5 from Pedro Amorim --- Created attachment 182443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182443&action=edit Bug 39900: Add tests prove t/db_dependent/api/v1/additional_contents.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #4 from Pedro Amorim --- Created attachment 182442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182442&action=edit Bug 39900: Add translated_contents embed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #3 from Pedro Amorim --- Created attachment 182441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182441&action=edit Bug 39900: REST API specs and class changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #1 from Pedro Amorim --- Created attachment 182439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182439&action=edit Bug 39900: Preparation: Refactor public_query_search_params for reusability Ensure no regressions are introduced, run: prove t/db_dependent/Koha/AdditionalContents.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 --- Comment #2 from Pedro Amorim --- Created attachment 182440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182440&action=edit Bug 39900: Preparation: Move html customizations options to class for reusability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39900] Add public REST endpoint for additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39900 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
