[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 David Nind changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #18 from David Nind --- Bug fixes, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Wainui Witika-Park changed: What|Removed |Added CC||[email protected] ||et.nz Status|Pushed to oldstable |Needs documenting --- Comment #17 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Status|Pushed to stable|Pushed to oldstable Version(s)|25.11.00,25.05.01 |25.11.00,25.05.01,24.11.08 released in|| --- Comment #16 from Fridolin Somers --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 David Nind changed: What|Removed |Added Text to go in the||This restores the logging release notes||of fatal SIP errors to both ||the SIP logs and standard ||output from the command ||line. CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.01 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #15 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #12 from Tomás Cohen Arazi (tcohen) --- Created attachment 183247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183247&action=edit Bug 39911: Remove redundant warn Following the original test plan you notice, `THIS IS A TEST` is printed twice: * In the logs. * In STDERR for the SIP server. The latter is redundant, and also problematic for `xt/author/pod_coverage.t` which fails the `no warnings` tests because of that. To test: 1. Run: $ ktd --shell k$ prove xt/author/pod_coverage.t => FAIL: Scary errors, lots of them 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Follow the original bug test plan => SUCCESS: There's `THIS IS A TEST` in the logs, which was the author's goal in the first place. 5. Sign off :-D 6. Visit bug 40144 :-P Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #14 from Lucas Gass (lukeg) --- Follow-ups pushed to main, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #13 from Tomás Cohen Arazi (tcohen) --- (In reply to Lucas Gass (lukeg) from comment #11) > Tests are still failing here, even with Kyle's follow-up. Lucas, I checked the warn is not required to accomplish Kyle's goal so it is ok to push my follow-up. Cheers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=40144 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #11 from Lucas Gass (lukeg) --- Tests are still failing here, even with Kyle's follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #183212|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #10 from Lucas Gass (lukeg) --- Created attachment 183212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183212&action=edit Bug 39911: (RM follow-up) Use logger warn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #9 from Lucas Gass (lukeg) --- I think its actually the bare 'warn' that is causing test to fail. I think we should use $logger->warn() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #8 from Kyle M Hall (khall) --- Created attachment 183203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183203&action=edit Bug 39911: Add POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||additional_work_needed CC||[email protected] --- Comment #7 from Lucas Gass (lukeg) --- This is causing tests to fail in main due to bad POD coverage. xt/author/pod_coverage.t is failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #6 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Attachment #182508|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi (tcohen) --- Created attachment 183078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183078&action=edit Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Magnus Enger changed: What|Removed |Added Attachment #182503|0 |1 is obsolete|| --- Comment #4 from Magnus Enger --- Created attachment 182508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182508&action=edit Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 David Cook changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Kyle M Hall (khall) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Kyle M Hall (khall) changed: What|Removed |Added CC||tristin.stagg@bywatersoluti ||ons.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Kyle M Hall (khall) changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182502|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall (khall) --- Created attachment 182503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182503&action=edit Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #2 from Kyle M Hall (khall) --- Created attachment 182502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182502&action=edit Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 --- Comment #1 from Kyle M Hall (khall) --- Created attachment 182501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182501&action=edit Bug 39911: Introduce failure in patron information request [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39911] Fatal errors from SIP server are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39911 Kyle M Hall (khall) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
