[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to oldoldstable |Needs documenting CC||[email protected] ||et.nz --- Comment #11 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 --- Comment #10 from Jesse Maseto --- Sorry I updated this too early. Merge conflicts. Please resolve if needed for 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Jesse Maseto changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable CC||[email protected] --- Comment #9 from Jesse Maseto --- This will be pushed to 24.05.x for 24.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 --- Comment #8 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Fridolin Somers changed: What|Removed |Added Version(s)|25.11.00,25.05.01 |25.11.00,25.05.01,24.11.06 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #7 from Fridolin Somers --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Fridolin Somers changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.01 released in|| CC||[email protected] ||m Status|Pushed to main |Pushed to stable --- Comment #6 from Fridolin Somers --- I see in 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 --- Comment #5 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|[email protected] |[email protected] |y.org |o.uk CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182563|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize (ashimema) --- Created attachment 182744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182744&action=edit Bug 39920: Update query for check previous checkout to use IN This patch alters the query for checking previous checkouts to use IN instead of a list of OR for itemnumbers. To test: 1 - On the command line: export DBIC_TRACE=1 2 - perl -e 'use Koha::Patrons;my $patron = Koha::Patrons->find(5);my $item = Koha::Items->find(54);warn $item->itemnumber;$patron->do_check_for_previous_checkout( $item->unblessed );' 3 - Note the query 4 - Apply patch 5 - Repeat 2 6 - Note the shorter query Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 --- Comment #1 from Nick Clemens (kidclamp) --- Created attachment 182528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182528&action=edit Bug 39920: Update query for check previous checkout to use IN This patch simply alters the query fro checkign previous checkouts to use IN instead of a list of OR for itemnumbers To test: 1 - On the command line: export DBICE_TRACE=1 2 - perl -e 'use Koha::Patrons;my $patron = Koha::Patrons->find(5);my $item = Koha::Items->find(54);warn $item->itemnumber;$patron->do_check_for_previous_checkout( $item->unblessed );' 3 - Note the query 4 - Apply patch 5 - Repeat 2 6 - Note the shorter query -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Nick Clemens (kidclamp) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 David Nind changed: What|Removed |Added Keywords||no-sandbox CC||[email protected] --- Comment #3 from David Nind --- Testing notes (using KTD): 1. For step 1, it should be export DBIC_TRACE=1 (not export DBICE_TRACE=1) (I amended the patch commit message). 2. Output before the patch: ... SELECT COUNT( * ) FROM `issues` `me` WHERE ( ( `borrowernumber` = ? AND ( `itemnumber` = ? OR `itemnumber` = ? OR `itemnumber` = ? OR `itemnumber` = ? ) ) ): '5', '52', '53', '54', '55' SELECT COUNT( * ) FROM `old_issues` `me` WHERE ( ( `borrowernumber` = ? AND ( `itemnumber` = ? OR `itemnumber` = ? OR `itemnumber` = ? OR `itemnumber` = ? ) ) ): '5', '52', '53', '54', '55' 3. Output after the patch: ... SELECT COUNT( * ) FROM `issues` `me` WHERE ( ( `borrowernumber` = ? AND `itemnumber` IN ( ?, ?, ?, ? ) ) ): '5', '52', '53', '54', '55' SELECT `me`.`variable`, `me`.`value`, `me`.`options`, `me`.`explanation`, `me`.`type` FROM `systempreferences` `me` WHERE ( `me`.`variable` = ? ): 'checkprevcheckoutdelay' SELECT COUNT( * ) FROM `old_issues` `me` WHERE ( ( `borrowernumber` = ? AND `itemnumber` IN ( ?, ?, ?, ? ) ) ): '5', '52', '53', '54', '55' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 Nick Clemens (kidclamp) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33691 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39920] do_check_for_previous_checkout should us 'IN' over 'OR'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39920 David Nind changed: What|Removed |Added Attachment #182528|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 182563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182563&action=edit Bug 39920: Update query for check previous checkout to use IN This patch alters the query for checking previous checkouts to use IN instead of a list of OR for itemnumbers. To test: 1 - On the command line: export DBIC_TRACE=1 2 - perl -e 'use Koha::Patrons;my $patron = Koha::Patrons->find(5);my $item = Koha::Items->find(54);warn $item->itemnumber;$patron->do_check_for_previous_checkout( $item->unblessed );' 3 - Note the query 4 - Apply patch 5 - Repeat 2 6 - Note the shorter query Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
