[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Status|Pushed to main |Pushed to stable Version(s)|25.05.00|25.05.00,24.11.08 released in|| --- Comment #15 from Fridolin Somers --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #14 from Tomás Cohen Arazi (tcohen) --- (In reply to Katrin Fischer from comment #13) > This is blamed for failing tests, please fix! Pushed already (in 37334 context) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed --- Comment #13 from Katrin Fischer --- This is blamed for failing tests, please fix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 --- Comment #12 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Katrin Fischer changed: What|Removed |Added Version(s)||25.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Katrin Fischer changed: What|Removed |Added Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182607|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize (ashimema) --- Created attachment 182634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182634&action=edit Bug 39932: Remove split in template Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182605|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 182632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182632&action=edit Bug 39932: Make Koha::Item->_status return an arrayref This patch makes the method return an actual array instead of a comma-separated string. The API spec is adjusted so it also expects an array in the response. Tests are adjusted for the new return value. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182606|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize (ashimema) --- Created attachment 182633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182633&action=edit Bug 39932: Add POD for Koha::Item->_status() Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 David Nind changed: What|Removed |Added Attachment #182600|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 182607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182607&action=edit Bug 39932: Remove split in template Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 David Nind changed: What|Removed |Added Attachment #182599|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 182606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182606&action=edit Bug 39932: Add POD for Koha::Item->_status() Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 David Nind changed: What|Removed |Added Attachment #182598|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 182605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182605&action=edit Bug 39932: Make Koha::Item->_status return an arrayref This patch makes the method return an actual array instead of a comma-separated string. The API spec is adjusted so it also expects an array in the response. Tests are adjusted for the new return value. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 --- Comment #5 from Tomás Cohen Arazi (tcohen) --- I marked it as Major to get more attention. I think the API spec is the most sensible issue here, as people could start using the 'string value' once it is published. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added CC||[email protected], ||[email protected], ||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 --- Comment #2 from Tomás Cohen Arazi (tcohen) --- Created attachment 182598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182598&action=edit Bug 39932: Make Koha::Item->_status return an arrayref This patch makes the method return an actual array instead of a comma-separated string. The API spec is adjusted so it also expects an array in the response. Tests are adjusted for the new return value. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 --- Comment #4 from Tomás Cohen Arazi (tcohen) --- Created attachment 182600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182600&action=edit Bug 39932: Remove split in template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 --- Comment #3 from Tomás Cohen Arazi (tcohen) --- Created attachment 182599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182599&action=edit Bug 39932: Add POD for Koha::Item->_status() Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Depends on||37334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 [Bug 37334] Cannot filter holdings table by status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39932] Koha::Item->_status should return an array
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39932 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Keywords||rel_25_05_candidate --- Comment #1 from Tomás Cohen Arazi (tcohen) --- I think this should be fixed for the release. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
