[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Lisette Scheer changed: What|Removed |Added CC||[email protected] ||m Comma delimited||NHS England list of Sponsors|| Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944
Pedro Amorim changed:
What|Removed |Added
Attachment #190020|0 |1
is obsolete||
--- Comment #11 from Pedro Amorim ---
Created attachment 190023
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190023&action=edit
Bug 39944: Trim form params
Test plan, ktd, before applying patch:
1) Enable ILLModule sys pref and create a new ILL request:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
2) Pick type 'journal article' and enter ' 123' to DOI (notice the leading
white space)
3) Enter a cardnumber and a library. Click 'Create'.
4) Run the following SQL query (koha-mysql kohadev):
SELECT
CONCAT('(', REPLACE(value, ' ', ' '), ')') AS 'Value with parenthesis
concatenated'
FROM illrequestattributes
WHERE illrequest_id = 1
AND type = 'doi';
5) Notice the value is saved with the leading whitespace. Apply patch. Repeat.
Notice it no longer saves with the leading white space.
Sponsored-by: NHS England
Signed-off-by: Richard Bridgen
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Attachment #190019|0 |1 is obsolete|| --- Comment #10 from Pedro Amorim --- Created attachment 190022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190022&action=edit Bug 39944: Add tests prove t/db_dependent/Koha/ILL/Request.t Signed-off-by: Richard Bridgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944
Pedro Amorim changed:
What|Removed |Added
Attachment #189930|0 |1
is obsolete||
--- Comment #9 from Pedro Amorim ---
Created attachment 190020
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190020&action=edit
Bug 39944: Trim form params
Test plan, ktd, before applying patch:
1) Enable ILLModule sys pref and create a new ILL request:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
2) Pick type 'journal article' and enter ' 123' to DOI (notice the leading
white space)
3) Enter a cardnumber and a library. Click 'Create'.
4) Run the following SQL query (koha-mysql kohadev):
SELECT
CONCAT('(', REPLACE(value, ' ', ' '), ')') AS 'Value with parenthesis
concatenated'
FROM illrequestattributes
WHERE illrequest_id = 1
AND type = 'doi';
5) Notice the value is saved with the leading whitespace. Apply patch. Repeat.
Notice it no longer saves with the leading white space.
Sponsored-by: NHS England
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Attachment #189929|0 |1 is obsolete|| --- Comment #8 from Pedro Amorim --- Created attachment 190019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190019&action=edit Bug 39944: Add tests prove t/db_dependent/Koha/ILL/Request.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Attachment #182673|0 |1 is obsolete|| --- Comment #7 from Pedro Amorim --- Created attachment 189930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189930&action=edit Bug 39944: Trim form params Test plan, ktd, before applying patch: 1) Enable ILLModule sys pref and create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 2) Pick type 'journal article' and enter ' 123' to DOI (notice the leading white space) 3) Enter a cardnumber and a library. Click 'Create'. 4) Run the following SQL query (koha-mysql kohadev): $ SELECT * from illrequestattributes where illrequest_id = '' and type ='doi'; 5) Notice the value is saved with the leading whitespace. Apply patch. Repeat. Notice it no longer saves with the leading white space. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Attachment #182672|0 |1 is obsolete|| --- Comment #6 from Pedro Amorim --- Created attachment 189929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189929&action=edit Bug 39944: Add tests prove t/db_dependent/Koha/ILL/Request.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 --- Comment #5 from Chris Cormack --- Automatic patch test results: â ï¸ The patch applies with fuzzy option (ignoring whitespace). This may indicate minor conflicts that need to be resolved. Details: Patch applies with fuzzy option (ignoring whitespace) This is an automated message from the patch testing system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Attachment #182669|0 |1 is obsolete|| --- Comment #4 from Pedro Amorim --- Created attachment 182673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182673&action=edit Bug 39944: Trim form params Test plan, ktd, before applying patch: 1) Enable ILLModule sys pref and create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 2) Pick type 'journal article' and enter ' 123' to DOI (notice the leading white space) 3) Enter a cardnumber and a library. Click 'Create'. 4) Run the following SQL query (koha-mysql kohadev): $ SELECT * from illrequestattributes where illrequest_id = '' and type ='doi'; 5) Notice the value is saved with the leading whitespace. Apply patch. Repeat. Notice it no longer saves with the leading white space. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Attachment #182668|0 |1 is obsolete|| --- Comment #3 from Pedro Amorim --- Created attachment 182672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182672&action=edit Bug 39944: Add tests prove t/db_dependent/Koha/ILL/Request.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 --- Comment #2 from Pedro Amorim --- Created attachment 182669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182669&action=edit Bug 39944: Trim form params Test plan, ktd, before applying patch: 1) Enable ILLModule sys pref and create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 2) Pick type 'journal article' and enter ' 123' to DOI (notice the leading white space) 3) Enter a cardnumber and a library. Click 'Create'. 4) Run the following SQL query (koha-mysql kohadev): $ SELECT * from illrequestattributes where illrequest_id = '' and type ='doi'; 5) Notice the value is saved with the leading whitespace. Apply patch. Repeat. Notice it no longer saves with the leading white space. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 --- Comment #1 from Pedro Amorim --- Created attachment 182668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182668&action=edit Bug 39944: Add tests prove t/db_dependent/Koha/ILL/Request.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39944] Metadata should be trimmed before creating an ILL request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39944 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
