[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182734|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize (ashimema) --- Created attachment 182743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182743&action=edit Bug 39947: Do not use bg-* Bootstrap classes This patch removes a few instances of the "bg-*" class from our templates, and adds some CSS to ensure that we can safely add the ".bg-*-subtle" class to a div with ".page-section." To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Circulation and fine rules. The information about rules specificity should have a pale blue background matching the color found in an "info" style alert. - Go to Tools -> Import patrons. The "Notes" section should match what you saw in the previous step. NOTE: I made a small change to whitespace in the markup of this section to prevent the database column list from displaying without line breaks--an issue introduced by the global tidy. - Go to Authorities and perform a search which will return results. - Click Actions -> Merge on one of the results. An "info" style alert should be shown at the top of the page, "Merging with authority..." - Without completing a merge, go to the Authorities home page. You should see an identical alert. - In KTD, bibliographic record 369 can be used to test errors related to encoding problems: - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 and confirm that you see a "warning" style alert (a pale yellow background). - Edit that record and confirm you see a similar error messages on that page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 David Nind changed: What|Removed |Added Attachment #182725|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 182734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182734&action=edit Bug 39947: Do not use bg-* Bootstrap classes This patch removes a few instances of the "bg-*" class from our templates, and adds some CSS to ensure that we can safely add the ".bg-*-subtle" class to a div with ".page-section." To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Circulation and fine rules. The information about rules specificity should have a pale blue background matching the color found in an "info" style alert. - Go to Tools -> Import patrons. The "Notes" section should match what you saw in the previous step. NOTE: I made a small change to whitespace in the markup of this section to prevent the database column list from displaying without line breaks--an issue introduced by the global tidy. - Go to Authorities and perform a search which will return results. - Click Actions -> Merge on one of the results. An "info" style alert should be shown at the top of the page, "Merging with authority..." - Without completing a merge, go to the Authorities home page. You should see an identical alert. - In KTD, bibliographic record 369 can be used to test errors related to encoding problems: - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 and confirm that you see a "warning" style alert (a pale yellow background). - Edit that record and confirm you see a similar error messages on that page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Owen Leonard changed: What|Removed |Added Attachment #182687|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 182725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182725&action=edit Bug 39947: Do not use bg-* Bootstrap classes This patch removes a few instances of the "bg-*" class from our templates, and adds some CSS to ensure that we can safely add the ".bg-*-subtle" class to a div with ".page-section." To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Circulation and fine rules. The information about rules specificity should have a pale blue background matching the color found in an "info" style alert. - Go to Tools -> Import patrons. The "Notes" section should match what you saw in the previous step. NOTE: I made a small change to whitespace in the markup of this section to prevent the database column list from displaying without line breaks--an issue introduced by the global tidy. - Go to Authorities and perform a search which will return results. - Click Actions -> Merge on one of the results. An "info" style alert should be shown at the top of the page, "Merging with authority..." - Without completing a merge, go to the Authorities home page. You should see an identical alert. - In KTD, bibliographic record 369 can be used to test errors related to encoding problems: - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 and confirm that you see a "warning" style alert (a pale yellow background). - Edit that record and confirm you see a similar error messages on that page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind --- The patch no longer applies 8-(... git bz apply 39947 Bug 39947 - Do not use bg-* Bootstrap classes 182687 - Bug 39947: Do not use bg-* Bootstrap classes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39947: Do not use bg-* Bootstrap classes Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 39947: Do not use bg-* Bootstrap classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |o.uk CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 --- Comment #1 from Owen Leonard --- Created attachment 182687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182687&action=edit Bug 39947: Do not use bg-* Bootstrap classes This patch removes a few instances of the "bg-*" class from our templates, and adds some CSS to ensure that we can safely add the ".bg-*-subtle" class to a div with ".page-section." To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Circulation and fine rules. The information about rules specificity should have a pale blue background matching the color found in an "info" style alert. - Go to Tools -> Import patrons. The "Notes" section should match what you saw in the previous step. NOTE: I made a small change to whitespace in the markup of this section to prevent the database column list from displaying without line breaks--an issue introduced by the global tidy. - Go to Authorities and perform a search which will return results. - Click Actions -> Merge on one of the results. An "info" style alert should be shown at the top of the page, "Merging with authority..." - Without completing a merge, go to the Authorities home page. You should see an identical alert. - In KTD, bibliographic record 369 can be used to test errors related to encoding problems: - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 and confirm that you see a "warning" style alert (a pale yellow background). - Edit that record and confirm you see a similar error messages on that page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 David Nind changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39947] Do not use bg-* Bootstrap classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
