[Koha-bugs] [Bug 39960] Improve messages in opac-discharge.tt

2025-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39960] Improve messages in opac-discharge.tt

2025-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement improves
  release notes||the messages in the OPAC on
   ||the ask for a discharge
   ||page (Your account > Ask
   ||for discharge, when the
   ||useDischarge system
   ||preference is enabled).
   ||
   ||Improvements:
   ||- Improved
   ||wording for the number of
   ||items checked out: instead
   ||of "..2 item(s).." and "..1
   ||item(s)..." the text
   ||changes based on the actual
   ||number of checkouts - "...2
   ||items..." and "...an
   ||item...".
   ||- More succinct
   ||text: for example, instead
   ||of "Please pay your charges
   ||before reapplying.",
   ||"Please pay them before
   ||reapplying."
 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39960] Improve messages in opac-discharge.tt

2025-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960

David Nind  changed:

   What|Removed |Added

 Attachment #182700|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 182707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182707&action=edit
Bug 39960: Improve messages in opac-discharge.tt

This patch makes the messages more streamlined.

To test:
1. Enable `useDischarge`
2. Have a patron with two checkouts
3. Log into the OPAC and try to request a discharge
=> FAIL: You get a message that says '2 item(s)' and has redundant
words.
4. Check one of the items in
5. Repeat 3
=> FAIL: Same, but says '1 item(s)'.
6. Check it in
7. Add a manual fee
8. Repeat 3
=> FAIL: Another redundant text about charges.
9. Apply this patch and repeat 2-8
=> SUCCESS: Things read better
10. Sign off :-D

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39960] Improve messages in opac-discharge.tt

2025-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 CC||[email protected]
 Status|NEW |Needs Signoff
   Assignee|[email protected] |[email protected]
 Depends on||14250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250
[Bug 14250] Don't allow generating discharges for patrons with fines
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39960] Improve messages in opac-discharge.tt

2025-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39960] Improve messages in opac-discharge.tt

2025-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39960

--- Comment #1 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 182700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182700&action=edit
Bug 39960: Improve messages in opac-discharge.tt

This patch makes the messages more streamlined.

To test:
1. Enable `useDischarge`
2. Have a patron with two checkouts
3. Log into the OPAC and try to request a discharge
=> FAIL: You get a message that says '2 item(s)' and has redundant
words.
4. Check one of the items in
5. Repeat 3
=> FAIL: Same, but says '1 item(s)'.
6. Check it in
7. Add a manual fee
8. Repeat 3
=> FAIL: Another redundant text about charges.
9. Apply this patch and repeat 2-8
=> SUCCESS: Things read better
10. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/