[Koha-bugs] [Bug 39977] Prevent reserves of items the users have already on their possession
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 Lucas Gass (lukeg) changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||[email protected] --- Comment #7 from Lucas Gass (lukeg) --- Some QA tool failures here: [FAIL] C4/Reserves.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl C4/Reserves.pm` Processing additional checks * Commit title does not start with 'Bug X: ' - 72f180fd009 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39977] Prevent reserves of items the users have already on their possession
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 Anneli Österman changed: What|Removed |Added CC||anneli.osterman@koha-suomi. ||fi --- Comment #6 from Anneli Österman --- We have libraries tht have AllowHoldsOnPatronsPossessions set to Allow and it would be nice if it remained the same as before. Maybe a third option as suggested? I do not see why we should prevent patrons to make hold on the very same item they already have checked out. It is not our place to say that they cannot do it. If they need the same item, they can have it. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39977] Prevent reserves of items the users have already on their possession
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #5 from Adolfo Rodríguez Taboada --- This was reported as a problem by a client, as they did want to allow reserves on bibliographic records when the user had some items checked out but not those specific items. We could rework it as a third option in the system preference AllowHoldsOnPatronsPossessions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39977] Prevent reserves of items the users have already on their possession
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #4 from Katrin Fischer --- It's a change in behavior not everyone might agree with. This feature has been existing for a long while now, so it might be an unwanted change for some if it hasn't been reported as a problem so far. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39977] Prevent reserves of items the users have already on their possession
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #3 from Adolfo Rodríguez Taboada --- The point is that the user shouldn't be able to put a hold on the item that's already on their possession. With the AllowHoldsOnPatronsPossessions on Allow they should be able to put a hold on any other item. An example. A bibliographic record of Paradise Kiss, a manga series collected in 5 volumes. The user has checked out an item (Volume 1) and wants to put a hold on a different item (Volume 2) That should be allowed with the preference AllowHoldsOnPatronsPossessions. It makes sense to want to reserve the next volume to continue reading the series. I think the user shouldn't be allowed to put a hold in the item of Volume 1 as he/she has already that item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39977] Prevent reserves of items the users have already on their possession
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #2 from Katrin Fischer --- Does the test plan really make sense? 1 Turn system preference AllowHoldsOnPatronsPossessions to Allow. So a hold on the item in my possession should be allowed. But your test plan ends with: 3 Try to put a hold on that record with the same user that checked out the item. You will see that you can select the item the user already has. 4 Apply patch, restart services 5 Repeat step 3. Now you cannot select the item the user has checked out. I don't think that is correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39977] Prevent reserves of items the users have already on their possession
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 Adolfo Rodríguez Taboada changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39977] Prevent reserves of items the users have already on their possession
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39977 --- Comment #1 from Adolfo Rodríguez Taboada --- Created attachment 182753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182753&action=edit Bug 39977 - Prevent reserves of items the users have already on their possession This patch preventes users from placing a hold on item they haved checked out. 1 Turn system preference AllowHoldsOnPatronsPossessions to Allow. 2 Check out an item from a record with more than one item. 3 Try to put a hold on that record with the same user that checked out the item. You will see that you can select the item the user already has. 4 Apply patch, restart services 5 Repeat step 3. Now you cannot select the item the user has checked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
