[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Wainui Witika-Park changed: What|Removed |Added CC||[email protected] ||et.nz Status|Pushed to oldstable |Needs documenting --- Comment #10 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|25.11.00,25.05.01 |25.11.00,25.05.01,24.11.07 released in|| CC||baptiste.wojtkowski@biblibr ||e.com --- Comment #9 from Baptiste Wojtkowski (bwoj) --- Pushed to 24.11.x for 24.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Paul Derscheid changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.01 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 --- Comment #8 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 --- Comment #7 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Marcel de Rooy changed: What|Removed |Added CC||[email protected] QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Marcel de Rooy changed: What|Removed |Added Attachment #182914|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 183043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183043&action=edit Bug 40034: Only check notforloan on itemtype if it exists This patch makes the code in `CheckReserves` survive the non-existence of the referenced item type in the `items` table for the passed item. To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/Reserves.t => FAIL: Tests explode like this: ``` Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 870. ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Marcel de Rooy changed: What|Removed |Added Attachment #182913|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 183042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183042&action=edit Bug 40034: Regression tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 David Nind changed: What|Removed |Added Attachment #182909|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 182914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182914&action=edit Bug 40034: Only check notforloan on itemtype if it exists This patch makes the code in `CheckReserves` survive the non-existence of the referenced item type in the `items` table for the passed item. To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/Reserves.t => FAIL: Tests explode like this: ``` Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 870. ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 David Nind changed: What|Removed |Added Attachment #182908|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 182913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182913&action=edit Bug 40034: Regression tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 --- Comment #2 from Tomás Cohen Arazi (tcohen) --- Created attachment 182909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182909&action=edit Bug 40034: Only check notforloan on itemtype if it exists This patch makes the code in `CheckReserves` survive the non-existence of the referenced item type in the `items` table for the passed item. To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/Reserves.t => FAIL: Tests explode like this: ``` Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 870. ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 --- Comment #1 from Tomás Cohen Arazi (tcohen) --- Created attachment 182908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182908&action=edit Bug 40034: Regression tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40034] CheckReserves dies if itype doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40034 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | CC||[email protected] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
