[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Owen Leonard changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 David Nind changed: What|Removed |Added CC||[email protected] Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from David Nind --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Needs documenting CC||[email protected] ||m --- Comment #11 from Fridolin Somers --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 --- Comment #10 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Paul Derscheid changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.01 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected] Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 --- Comment #9 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Jonathan Druart changed: What|Removed |Added Attachment #182989|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 182999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182999&action=edit Bug 40055: Make MoveReserve be passed objects instead of ids The `MoveReserve` method is called once, in `AddIssue`. The latter has the related `Koha::Item` object already fetched from the DB, but it passed the `itemnumber` which is used by `MoveReserve` to fetch the item from the DB. This should not happen. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Reserves* \ t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/Circulation* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Attachment #182953|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi (tcohen) --- Created attachment 182989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182989&action=edit Bug 40055: Make MoveReserve be passed objects instead of ids The `MoveReserve` method is called once, in `AddIssue`. The latter has the related `Koha::Item` object already fetched from the DB, but it passed the `itemnumber` which is used by `MoveReserve` to fetch the item from the DB. This should not happen. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Reserves* \ t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/Circulation* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 --- Comment #7 from Tomás Cohen Arazi (tcohen) --- (In reply to Jonathan Druart from comment #3) > I don't like the use of 'id'. We have borrowernumber and userid on this > object. I changed it to `$patron->borrowernumber`. Thanks for reviewing it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 --- Comment #5 from Tomás Cohen Arazi (tcohen) --- (In reply to Jonathan Druart from comment #3) > I don't like the use of 'id'. We have borrowernumber and userid on this > object. > And we have patron_id for the REST API. > > It might be obvious for you and me, but for new developers it can be very > confusing I think. I always felt like ->id (being the defined PRIMARY KEY) was a good practice as, in general, we end up using `$patron->id` which reads as 'the patron id' (at least in my brain). In this case, the comparison is with a 'borrowernumber' attribute, so I'd say I will change it to `$patron->borrowernumber` as it reads well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 --- Comment #4 from Jonathan Druart --- Or we batch replace all the occurrences. Otherwise we are just adding yet another inconsistency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 --- Comment #3 from Jonathan Druart --- I don't like the use of 'id'. We have borrowernumber and userid on this object. And we have patron_id for the REST API. It might be obvious for you and me, but for new developers it can be very confusing I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 David Nind changed: What|Removed |Added Attachment #182915|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 182953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182953&action=edit Bug 40055: Make MoveReserve be passed objects instead of ids The `MoveReserve` method is called once, in `AddIssue`. The latter has the related `Koha::Item` object already fetched from the DB, but it passed the `itemnumber` which is used by `MoveReserve` to fetch the item from the DB. This should not happen. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Reserves* \ t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/Circulation* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Blocks||40058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | CC||[email protected], ||[email protected] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40055] C4::Reserves::MoveReserve should be passed objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 --- Comment #1 from Tomás Cohen Arazi (tcohen) --- Created attachment 182915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182915&action=edit Bug 40055: Make MoveReserve be passed objects instead of ids The `MoveReserve` method is called once, in `AddIssue`. The latter has the related `Koha::Item` object already fetched from the DB, but it passed the `itemnumber` which is used by `MoveReserve` to fetch the item from the DB. This should not happen. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Reserves* \ t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/Circulation* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
