[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Status|Pushed to stable|Needs documenting --- Comment #14 from Fridolin Somers --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Bug 40058 depends on bug 40055, which changed state. Bug 40055 Summary: C4::Reserves::MoveReserve should be passed objects https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Text to go in the||This development refactors release notes||and existing function into ||a class method. The idea is ||that the code gets ||simplified, and also ||improve performance as the ||method acts on the already ||instantiated object instead ||of fetching it from the DB, ||internally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.04 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 --- Comment #13 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Blocks||40671 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40671 [Bug 40671] Rename `revert_waiting` => `revert_found` in Koha::Hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 --- Comment #12 from Tomás Cohen Arazi (tcohen) --- (In reply to Emily Lamancusa (emlam) from comment #11) > I'm afraid this has introduced a few new bugs - there are a few places in > the code where RevertWaitingStatus was being used to revert other found > statuses, which now throw an error 500: > > - in request.tt, the "Revert waiting status" button's text changes to > "Revert transit status" if the hold is in-transit, but under the hood it's > the same code that calls revert_waiting either way > > - when checking out an item with a found hold, if the user chooses to revert > the status of the hold and check out the item, revert_waiting gets called > regardless of which found status the item has > > Any reason not to name the method revert_found and explicitly allow it to > revert any found status? Good catch. This is why we need 100% tests coverage in the code. I'll provide a follow-up in a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Emily Lamancusa (emlam) changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Keywords||additional_work_needed --- Comment #11 from Emily Lamancusa (emlam) --- I'm afraid this has introduced a few new bugs - there are a few places in the code where RevertWaitingStatus was being used to revert other found statuses, which now throw an error 500: - in request.tt, the "Revert waiting status" button's text changes to "Revert transit status" if the hold is in-transit, but under the hood it's the same code that calls revert_waiting either way - when checking out an item with a found hold, if the user chooses to revert the status of the hold and check out the item, revert_waiting gets called regardless of which found status the item has Any reason not to name the method revert_found and explicitly allow it to revert any found status? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 --- Comment #10 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|[email protected] |[email protected] |y.org |o.uk CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182943|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 184982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184982&action=edit Bug 40058: Adjust existing tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182942|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize (ashimema) --- Created attachment 184981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184981&action=edit Bug 40058: Remove RevertWaitingStatus() Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182941|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize (ashimema) --- Created attachment 184980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184980&action=edit Bug 40058: Add Koha::Hold->revert_waiting() This patch adds a new method to the `Koha::Hold` class. The method follows the original implementation in C4::Reserves. Tests are added to cover all the code paths. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass :-D 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 David Nind changed: What|Removed |Added Attachment #182925|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 182942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182942&action=edit Bug 40058: Remove RevertWaitingStatus() Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 David Nind changed: What|Removed |Added Attachment #182924|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 182941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182941&action=edit Bug 40058: Add Koha::Hold->revert_waiting() This patch adds a new method to the `Koha::Hold` class. The method follows the original implementation in C4::Reserves. Tests are added to cover all the code paths. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass :-D 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 David Nind changed: What|Removed |Added Attachment #182926|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 182943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182943&action=edit Bug 40058: Adjust existing tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=40062 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 --- Comment #3 from Tomás Cohen Arazi (tcohen) --- Created attachment 182926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182926&action=edit Bug 40058: Adjust existing tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 --- Comment #2 from Tomás Cohen Arazi (tcohen) --- Created attachment 182925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182925&action=edit Bug 40058: Remove RevertWaitingStatus() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 --- Comment #1 from Tomás Cohen Arazi (tcohen) --- Created attachment 182924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182924&action=edit Bug 40058: Add Koha::Hold->revert_waiting() This patch adds a new method to the `Koha::Hold` class. The method follows the original implementation in C4::Reserves. Tests are added to cover all the code paths. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass :-D 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Jonathan Druart changed: What|Removed |Added Blocks||17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] [Omnibus] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | Depends on||40055 CC||[email protected] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40055 [Bug 40055] C4::Reserves::MoveReserve should be passed objects -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
