[Koha-bugs] [Bug 40083] misc/devel/install_plugins.pl doesn't run the "install" method of plugins.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40083
Kyle M Hall (khall) changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #4 from Kyle M Hall (khall) ---
I cannot recreate this issue. I modified a plugin to have the following:
sub install {
warn "INSTALL";
}
When I ran install_plugins.pl, I got the following output:
./misc/devel/install_plugins.pl
INSTALL at
/kohadevbox/plugins/koha-plugin-rfid/Koha/Plugin/Com/ByWaterSolutions/RFID.pm
line 26.
Installed RFID version {VERSION}
All plugins successfully re-initialised
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40083] misc/devel/install_plugins.pl doesn't run the "install" method of plugins.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40083 Kyle M Hall (khall) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40083] misc/devel/install_plugins.pl doesn't run the "install" method of plugins.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40083 Brendan Lawlor changed: What|Removed |Added Attachment #183486|0 |1 is obsolete|| --- Comment #3 from Brendan Lawlor --- Created attachment 184907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184907&action=edit Bug 40083: InstallPlugin actually runs "install" method. When developping a plugin or installing from the script rather than zip method, the plugin "install" method is not run. This can result in some necessary component (like tables, configuration) not being setup, resulting in errors at plugin run. Test plan : - Install the kitchensink plugin by cloning the source and adding the directory to "koha-conf.xml" with the plugin_dir configuration - Run misc/devel/install_plugins.pl - Check the plugin table "mytable" is not created in the DB (check the code in the "install" method of kitchensink plugin) - apply patch - run misc/devel/install_plugins.pl again - the plugin table should be created according to the install method. Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40083] misc/devel/install_plugins.pl doesn't run the "install" method of plugins.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40083 Brendan Lawlor changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40083] misc/devel/install_plugins.pl doesn't run the "install" method of plugins.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40083 David Cook changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40083] misc/devel/install_plugins.pl doesn't run the "install" method of plugins.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40083 --- Comment #2 from Arthur Suzuki --- Created attachment 183486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183486&action=edit Bug 40083: InstallPlugin actually runs "install" method. When developping a plugin or installing from the script rather than zip method, the plugin "install" method is not run. This can result in some necessary component (like tables, configuration) not being setup, resulting in errors at plugin run. Test plan : - Install the kitchensink plugin by cloning the source and adding the directory to "koha-conf.xml" with the plugin_dir configuration - Run misc/devel/install_plugins.pl - Check the plugin table "mytable" is not created in the DB (check the code in the "install" method of kitchensink plugin) - apply patch - run misc/devel/install_plugins.pl again - the plugin table should be created according to the install method. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40083] misc/devel/install_plugins.pl doesn't run the "install" method of plugins.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40083 Arthur Suzuki changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40083] misc/devel/install_plugins.pl doesn't run the "install" method of plugins.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40083
--- Comment #1 from Arthur Suzuki ---
Managed to get it to work with this diff :
diff --git a/Koha/Plugins.pm b/Koha/Plugins.pm
index d93e9fe40fc..25aad2ffa2c 100644
--- a/Koha/Plugins.pm
+++ b/Koha/Plugins.pm
@@ -287,6 +287,7 @@ sub InstallPlugins {
try {
$plugin = $plugin_class->new({ enable_plugins =>
$self->{'enable_plugins'} });
+ $plugin->install();
}
catch {
warn "$_"
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
