[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 David Nind changed: What|Removed |Added CC||[email protected] Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #8 from David Nind --- Test suite changes, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Status|Pushed to stable|Needs documenting --- Comment #7 from Fridolin Somers --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 --- Comment #6 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Paul Derscheid changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.02 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||40444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 --- Comment #5 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Martin Renvoize (ashimema) changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Martin Renvoize (ashimema) changed: What|Removed |Added CC||[email protected] ||o.uk Status|Signed Off |Passed QA QA Contact|[email protected] |[email protected] |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 --- Comment #4 from Martin Renvoize (ashimema) --- Created attachment 184354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184354&action=edit Bug 40401: (follow-up) Fix grammar and rollback in tests - Fixed grammar: "Returns true if the patron is the anonymous patron" - Fixed test cleanup: use txn_rollback instead of txn_begin - Fixed test subroutine closure syntax Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #184294|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize (ashimema) --- Created attachment 184353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184353&action=edit Bug 40401: Implement Koha::Patron->is_anonymous The first motivation of this patch is to remove the following warnings from t/db_dependent/Auth.t: Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/C4/Auth.pm line 1497 Actually a correct fix seems to add a new `is_anonymous` method to Koha::Patron in order to remove the warnings from everywhere else. Test plan: Confirm that you cannot log in using the anonymous patron and that the 2 tests are passing prove t/db_dependent/Auth.t t/db_dependent/Koha/Patron.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 David Nind changed: What|Removed |Added Attachment #184123|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 184294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184294&action=edit Bug 40401: Implement Koha::Patron->is_anonymous The first motivation of this patch is to remove the following warnings from t/db_dependent/Auth.t: Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/C4/Auth.pm line 1497 Actually a correct fix seems to add a new `is_anonymous` method to Koha::Patron in order to remove the warnings from everywhere else. Test plan: Confirm that you cannot log in using the anonymous patron and that the 2 tests are passing prove t/db_dependent/Auth.t t/db_dependent/Koha/Patron.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40401] Implement Koha::Patron->is_anonymous (was t/db_dependent/Auth.t generates warnings)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40401 Jonathan Druart changed: What|Removed |Added Assignee|[email protected]|[email protected] Severity|minor |enhancement Summary|t/db_dependent/Auth.t |Implement |generates warnings |Koha::Patron->is_anonymous ||(was t/db_dependent/Auth.t ||generates warnings) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
