[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Fridolin Somers changed: What|Removed |Added Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in|| CC||[email protected] ||m Status|Pushed to stable|Pushed to oldstable --- Comment #7 from Fridolin Somers --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 --- Comment #6 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.02 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||40444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 --- Comment #5 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Marcel de Rooy changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403
Marcel de Rooy changed:
What|Removed |Added
Attachment #184295|0 |1
is obsolete||
--- Comment #4 from Marcel de Rooy ---
Created attachment 184308
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184308&action=edit
Bug 40403: Remove warning from Circulation_holdsqueue.t
Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Biblio.pm
line 3049.
The context is:
3045 my $current_issues = $biblioitem->totalissues // 0;
3046 if ( defined $value ) {
3047 $totalissues = $value;
3048 } else {
3049 $totalissues = $biblioitem->totalissues + $increase;
3050 }
3051 return 0 if $current_issues == $totalissues;# No need to update if
no changes
It feels correct to use $current_issues to suppress the warning
Signed-off-by: David Nind
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 David Nind changed: What|Removed |Added CC||[email protected] --- Comment #3 from David Nind --- Testing notes (using KTD): 1. prove t/db_dependent/Circulation_holdsqueue.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403
David Nind changed:
What|Removed |Added
Attachment #184125|0 |1
is obsolete||
--- Comment #2 from David Nind ---
Created attachment 184295
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184295&action=edit
Bug 40403: Remove warning from Circulation_holdsqueue.t
Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Biblio.pm
line 3049.
The context is:
3045 my $current_issues = $biblioitem->totalissues // 0;
3046 if ( defined $value ) {
3047 $totalissues = $value;
3048 } else {
3049 $totalissues = $biblioitem->totalissues + $increase;
3050 }
3051 return 0 if $current_issues == $totalissues;# No need to update if
no changes
It feels correct to use $current_issues to suppress the warning
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Jonathan Druart changed: What|Removed |Added Assignee|[email protected]|[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403
--- Comment #1 from Jonathan Druart ---
Created attachment 184125
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184125&action=edit
Bug 40403: Remove warning from Circulation_holdsqueue.t
Use of uninitialized value in addition (+) at /kohadevbox/koha/C4/Biblio.pm
line 3049.
The context is:
3045 my $current_issues = $biblioitem->totalissues // 0;
3046 if ( defined $value ) {
3047 $totalissues = $value;
3048 } else {
3049 $totalissues = $biblioitem->totalissues + $increase;
3050 }
3051 return 0 if $current_issues == $totalissues;# No need to update if
no changes
It feels correct to use $current_issues to suppress the warning
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40403] Circulation_holdsqueue.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40403 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
