[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Katrin Fischer changed: What|Removed |Added Keywords||rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #150 from Katrin Fischer --- When this was pushed, main was still the upcoming 25.11 release. To figure out which versions a patch is included in, always have a look at the "Version(s) released in". Next the release maintainer for 25.05 will check if this should be backported and will either close it or move it to the next Pushed status after push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Jens Seidel changed: What|Removed |Added CC||[email protected] --- Comment #149 from Jens Seidel --- (In reply to David Cook from comment #8) > I've updated the "System requirements and recommendations" wiki page to say > we're not recommending these latest Debian/Ubuntu OSes, and that people > should double-check the supported OSes for the supported Koha versions. Is the latest stable Koha version still not recommended on Debian Trixie? After reading many reports including this one I do not see a critical blocker. At least it is not this bug anymore as described on https://wiki.koha-community.org/wiki/System_requirements_and_recommendations: “Important note: Koha is NOT YET recommended for use on Debian 13 (Trixie) or Ubuntu 25.04 (Plucky) because of noisy warnings with Perl 5.40.0, and other issues that prevent running automated tests.” This bug is currently only marked as “Pushed to main”? According to the release notes of Koha 25.11.00 it is fixed and so I expect it to be Closed!?? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Jonathan Druart changed: What|Removed |Added Blocks||41521 --- Comment #148 from Jonathan Druart --- (In reply to Jonathan Druart from comment #23) > Those patches fix most of the issues. > > Remaining ones: > > not ok 455 - Koha/ExternalContent/OverDrive.pm has syntax warnings. > # Failed test 'Koha/ExternalContent/OverDrive.pm has syntax warnings.' > # at xt/pl_valid.t line 63. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. > > > > not ok 2266 - opac/external/overdrive/auth.pl has syntax warnings. > # Failed test 'opac/external/overdrive/auth.pl has syntax warnings.' > # at xt/pl_valid.t line 63. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. > > > not ok 2356 - opac/svc/overdrive has syntax warnings. > # Failed test 'opac/svc/overdrive has syntax warnings.' > # at xt/pl_valid.t line 63. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. > > Test plan: > Startup ktd using trixie's image > export DB_IMAGE=mariadb:latest; > export KOHA_IMAGE=main-trixie; > ktd pull && ktd down && ktd --selenium --es7 up > Run prove xt/pl_valid.t Moved to bug 41521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521 [Bug 41521] WebService::ILS::OverDrive not passing pl_valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #147 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #146 from Victor Grousset/tuxayo --- Thanks a lot Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | QA Contact|[email protected] |[email protected] |y.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #145 from Martin Renvoize (ashimema) --- I spend a fair chunk of time testing and reviewing this today and feel it's ready to go. Passing QA, but happy for it to go either side of release to be honest. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188136|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188135|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188134|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188133|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188132|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188131|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188130|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188129|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188128|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188127|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188126|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #144 from Martin Renvoize (ashimema) --- Created attachment 189885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189885&action=edit Bug 40680: Fix t tests Amended patch @ t/db_dependent/Realtime_holdsqueue.t:26 @ use Test::MockModule; -use C4::SIP::ILS::Transaction::Checkin qw( do_checkin ); +use C4::SIP::ILS::Transaction::Checkin; Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #143 from Martin Renvoize (ashimema) --- Created attachment 189884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189884&action=edit Bug 40680: Fix C4::Calendar imports Attempt to call undefined import method with arguments (new ...) via package C4::Calendar (Perhaps you forgot to load the package?) at t/db_dependent/Hold.t line 25. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #142 from Martin Renvoize (ashimema) --- Created attachment 189883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189883&action=edit Bug 40680: Fix t/Labels* Attempt to call undefined import method with arguments (split_callnumber) via package C4::ClassSplitRoutine::LCC (Perhaps you forgot to load the package?) at t/Labels.t line 22. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #141 from Martin Renvoize (ashimema) --- Created attachment 189882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189882&action=edit Bug 40680: Fix svc/virtualshelves/search Attempt to call undefined import method with arguments (search) via package C4::Utils::DataTables::VirtualShelves (Perhaps you forgot to load the package?) at svc/virtualshelves/search line 8. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #140 from Martin Renvoize (ashimema)
---
Created attachment 189881
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189881&action=edit
Bug 40680: Fix TestBuilder
perl -wc misc/devel/create_test_data.pl
Attempt to call undefined import method with arguments ("schema") via package
"Koha::Database" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 5.
Attempt to call undefined import method with arguments ("_type") via package
"Koha::Biblios" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 7.
Attempt to call undefined import method with arguments ("_type") via package
"Koha::Items" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 8.
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #139 from Martin Renvoize (ashimema) --- Created attachment 189880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189880&action=edit Bug 40680: Fix admin/matching-rules.pl Attempt to call undefined import method with arguments (valid_normalization_routines) via package C4::Matcher (Perhaps you forgot to load the package?) at admin/matching-rules.pl line 27. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #138 from Martin Renvoize (ashimema) --- Created attachment 189879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189879&action=edit Bug 40680: Fix admin/columns_settings.pl Attempt to call undefined import method with arguments (get_modules) via package C4::Utils::DataTables::TablesSettings (Perhaps you forgot to load the package?) at admin/columns_settings.pl line 8. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #137 from Martin Renvoize (ashimema) --- Created attachment 189878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189878&action=edit Bug 40680: Fix acqui scripts Attempt to call undefined import method with arguments (get_active) via package Koha::Acquisition::Currencies (Perhaps you forgot to load the package?) at acqui/addorder.pl line 133. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #136 from Martin Renvoize (ashimema) --- Created attachment 189877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189877&action=edit Bug 40680: Fix C4/Patroncards/Patroncard.pm Attempt to call undefined import method with arguments (StrWidth) via package C4::Creators::PDF (Perhaps you forgot to load the package?) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 28. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #135 from Martin Renvoize (ashimema)
---
Created attachment 189876
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189876&action=edit
Bug 40680: Move EXPORT_OK right after Modern::Perl
So it is done before the other use statements.
Also uniformize the pattern, must now be:
```
use Modern::Perl;
use base 'Exporter';
BEGIN {
our @EXPORT_OK = qw(subroutine list);
}
```
Rebased-by: Victor Grousset/tuxayo
Bug38936 exported redirect_if_opac_suppressed
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #134 from Martin Renvoize (ashimema) --- Created attachment 189875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189875&action=edit Bug 40680: Remove duplicated code From commit b40ceb1cf5cb195f81347e090ade5e8bc3f316de Bug 39367: Manual changes Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #133 from Victor Grousset/tuxayo --- Thanks for confirming that's indeed not an issue. I'm reviewing as much as I can with my knowledge. And from what Lucas told me they feel comfortable with merging this at the very start of 26.05 cycle. So I plan to finish proofreading, get a second opinion on QA chat about confirming that the base change template applied to all files is good and it should be good to go :) Surprisingly it hasn't conflicted for a while with main :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #132 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #130) > Comment on attachment 188127 [details] [review] > Bug 40680: Move EXPORT_OK right after Modern::Perl > ::: C4/Members/Messaging.pm > @@ +25,5 @@ > > +our @EXPORT_OK = qw( > > +GetMessagingPreferences > > +SetMessagingPreference > > +GetMessagingOptions > > +SetMessagingPreferencesFromDefaults > > In the whole patchset, that's the only change for that file. Is that > expected that there was no proper export before? Introducing it should not > cause any issues to the current callers of these methods, right? I've noted at least those ones. So either we adjust the callers or we export, it seems that I've decided to add the exports. Koha/CurbsidePickup.pm:use C4::Members::Messaging qw( GetMessagingPreferences ); opac/opac-memberentry.pl:use C4::Members::Messaging qw( SetMessagingPreferencesFromDefaults ); t/db_dependent/Circulation.t:use C4::Members::Messaging qw( SetMessagingPreference ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Jonathan Druart changed: What|Removed |Added Assignee|[email protected] |[email protected] ||ity.org Status|Signed Off |Patch doesn't apply --- Comment #131 from Jonathan Druart --- I won't work more on this until people are ready to QA and push it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #130 from Victor Grousset/tuxayo --- Comment on attachment 188127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188127 Bug 40680: Move EXPORT_OK right after Modern::Perl Review of attachment 188127: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=40680&attachment=188127) - ::: C4/Auth_with_shibboleth.pm @@ +155,4 @@ > module => 'members', > letter_code => 'WELCOME', > branchcode => $patron->branchcode, > + Good catch here with the double ,, and another instance of the same. Ew that these things compiled <.< ::: C4/Members/Messaging.pm @@ +25,5 @@ > +our @EXPORT_OK = qw( > +GetMessagingPreferences > +SetMessagingPreference > +GetMessagingOptions > +SetMessagingPreferencesFromDefaults In the whole patchset, that's the only change for that file. Is that expected that there was no proper export before? Introducing it should not cause any issues to the current callers of these methods, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #129 from Jonathan Druart --- (In reply to Michał from comment #128) > It would definitely be very nice if the fixes were merged for 25.11... > Unfortunately it seems I made the mistake of assuming that "trixie" being in > the repos = it's supported and supposed to work (which it actually does for > the most part, aside from these warnings) There are other know issues, see bug 41077. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Michał changed: What|Removed |Added CC||[email protected] ||om --- Comment #128 from Michał --- It would definitely be very nice if the fixes were merged for 25.11... Unfortunately it seems I made the mistake of assuming that "trixie" being in the repos = it's supported and supposed to work (which it actually does for the most part, aside from these warnings) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #127 from Victor Grousset/tuxayo --- (In reply to Marcel de Rooy from comment #124) > I would tend to postpone this over the 25.11 release now. We are not yet > advertizing Debian 13 as a supported OS. But obviously, we should fix this > soon. Given that there will still be people who will not follow the system requirements (which is a pain!), won't we get bothered with more reports over the next six months if this isn't merged? It's certain there will be some issues without this. But with this merged, the risk is some weird dependency mess that didn't make enough warnings to be noticed during the tests. And didn't make a test fail (there sure are blindspot). **Which bet is safer?** Of course without anyone running Koha on Debian 13 the choice would be easy. Wait, the big assumption is that it will not be possible to backport to from main to 25.11.x. But maybe it's safe enough. Like if that's the 1st thing merged to main after 25.11.00, then does it feel safe to backport to 25.11.01 if nothing is found in 3 weeks? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #126 from Victor Grousset/tuxayo --- Removed dependency to bug 41099. It's not a real dependency. The issue it addresses for testing can be circumvented using DB_IMAGE=mariadb:11.4 or later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Depends on|41099 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41099 [Bug 41099] koha-mysql doesn't work out of the box on Debian 13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #125 from Jonathan Druart --- Those patches fix tests basically so running the tests and confirming that they now pass will already give you a good idea of the sanity of the changes. Then you can test different areas in Koha. Also reading the diff, the changes are pretty trivial. I won't rebase this for months so people should get involved now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Marcel de Rooy changed: What|Removed |Added CC||[email protected] --- Comment #124 from Marcel de Rooy --- I would tend to postpone this over the 25.11 release now. We are not yet advertizing Debian 13 as a supported OS. But obviously, we should fix this soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #123 from David Cook --- (In reply to Jonathan Druart from comment #122) > why is this stalling exactly? For me, I think I'm just intimidated by the amount of changes, so I'm not sure how/where I can help. For instance, I'm not sure what the next step for this report is? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #122 from Jonathan Druart --- why is this stalling exactly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Depends on||41099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41099 [Bug 41099] koha-mysql doesn't work out of the box on Debian 13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added CC||[email protected] --- Comment #121 from Tomás Cohen Arazi (tcohen) --- (In reply to David Cook from comment #4) > (In reply to Victor Grousset/tuxayo from comment #0) > > == Test plan == > > 1. Start a Debian 13 Koha: KOHA_IMAGE=main-trixie ktd up > > So I used the "ku" alias instead of "bin/ktd". I had to set the KOHA_IMAGE > in my .env file. > > Then I kept getting this error at startup: > koha-1 | Running [koha-mysql kohadev -e 'UPDATE systempreferences SET > value="1" WHERE variable="RESTBasicAuth"']... > koha-1 | ERROR 2026 (HY000): TLS/SSL error: SSL is required, but the > server does not support it > koha-1 exited with code 1 > > So on my next try while the container was starting up, I got onto the > container and did the following to turn off SSL for the client: > > vi /etc/mysql/my.cnf > ssl=off Please look at bug 41099. I think keeping the current behavior is the way to go. I already patched KTD (adding the my.cnf line) so we start testing Debian 13 and Ubuntu 25.04 as people are already trying Koha there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40863, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40977, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40978, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40989 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||41077 Depends on|41077 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41077 [Bug 41077] [OMNIBUS] Debian 13 and Perl 5.40 compatibility -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Depends on||41077 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41077 [Bug 41077] [OMNIBUS] Debian 13 and Perl 5.40 compatibility -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #120 from Victor Grousset/tuxayo --- qa script fails with tidy issues on perl files but that only happens on Debian 13. Something like the default of perltidy have changed? Anyway, that's another issue >_< My previous report of tidy failures might have been due to running on Debian 12. And Jonathan made the patches on Debian 13. Or some other confusion like that. At least now the current state is that the code is considered tidy on Debian 12. (lucky that it's not the reverse) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #119 from Victor Grousset/tuxayo --- Thanks for the fix! :) Beside some local failures, I think all tests pass with the patches. Basic circulation works, is there anything else to test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187958|0 |1 is obsolete|| --- Comment #118 from Victor Grousset/tuxayo --- Created attachment 188136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188136&action=edit Bug 40680: Fix t tests Amended patch @ t/db_dependent/Realtime_holdsqueue.t:26 @ use Test::MockModule; -use C4::SIP::ILS::Transaction::Checkin qw( do_checkin ); +use C4::SIP::ILS::Transaction::Checkin; Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187957|0 |1 is obsolete|| --- Comment #117 from Victor Grousset/tuxayo --- Created attachment 188135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188135&action=edit Bug 40680: Fix C4::Calendar imports Attempt to call undefined import method with arguments (new ...) via package C4::Calendar (Perhaps you forgot to load the package?) at t/db_dependent/Hold.t line 25. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187956|0 |1 is obsolete|| --- Comment #116 from Victor Grousset/tuxayo --- Created attachment 188134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188134&action=edit Bug 40680: Fix t/Labels* Attempt to call undefined import method with arguments (split_callnumber) via package C4::ClassSplitRoutine::LCC (Perhaps you forgot to load the package?) at t/Labels.t line 22. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187955|0 |1 is obsolete|| --- Comment #115 from Victor Grousset/tuxayo --- Created attachment 188133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188133&action=edit Bug 40680: Fix svc/virtualshelves/search Attempt to call undefined import method with arguments (search) via package C4::Utils::DataTables::VirtualShelves (Perhaps you forgot to load the package?) at svc/virtualshelves/search line 8. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #187954|0 |1
is obsolete||
--- Comment #114 from Victor Grousset/tuxayo ---
Created attachment 188132
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188132&action=edit
Bug 40680: Fix TestBuilder
perl -wc misc/devel/create_test_data.pl
Attempt to call undefined import method with arguments ("schema") via package
"Koha::Database" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 5.
Attempt to call undefined import method with arguments ("_type") via package
"Koha::Biblios" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 7.
Attempt to call undefined import method with arguments ("_type") via package
"Koha::Items" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 8.
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187953|0 |1 is obsolete|| --- Comment #113 from Victor Grousset/tuxayo --- Created attachment 188131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188131&action=edit Bug 40680: Fix admin/matching-rules.pl Attempt to call undefined import method with arguments (valid_normalization_routines) via package C4::Matcher (Perhaps you forgot to load the package?) at admin/matching-rules.pl line 27. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187952|0 |1 is obsolete|| --- Comment #112 from Victor Grousset/tuxayo --- Created attachment 188130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188130&action=edit Bug 40680: Fix admin/columns_settings.pl Attempt to call undefined import method with arguments (get_modules) via package C4::Utils::DataTables::TablesSettings (Perhaps you forgot to load the package?) at admin/columns_settings.pl line 8. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187951|0 |1 is obsolete|| --- Comment #111 from Victor Grousset/tuxayo --- Created attachment 188129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188129&action=edit Bug 40680: Fix acqui scripts Attempt to call undefined import method with arguments (get_active) via package Koha::Acquisition::Currencies (Perhaps you forgot to load the package?) at acqui/addorder.pl line 133. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187950|0 |1 is obsolete|| --- Comment #110 from Victor Grousset/tuxayo --- Created attachment 188128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188128&action=edit Bug 40680: Fix C4/Patroncards/Patroncard.pm Attempt to call undefined import method with arguments (StrWidth) via package C4::Creators::PDF (Perhaps you forgot to load the package?) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 28. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #187949|0 |1
is obsolete||
--- Comment #109 from Victor Grousset/tuxayo ---
Created attachment 188127
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188127&action=edit
Bug 40680: Move EXPORT_OK right after Modern::Perl
So it is done before the other use statements.
Also uniformize the pattern, must now be:
```
use Modern::Perl;
use base 'Exporter';
BEGIN {
our @EXPORT_OK = qw(subroutine list);
}
```
Rebased-by: Victor Grousset/tuxayo
Bug38936 exported redirect_if_opac_suppressed
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #187948|0 |1 is obsolete|| --- Comment #108 from Victor Grousset/tuxayo --- Created attachment 188126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188126&action=edit Bug 40680: Remove duplicated code From commit b40ceb1cf5cb195f81347e090ade5e8bc3f316de Bug 39367: Manual changes Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #186661|0 |1 is obsolete|| --- Comment #56 from Victor Grousset/tuxayo --- Created attachment 187129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187129&action=edit Bug 40680: Fix svc/virtualshelves/search Attempt to call undefined import method with arguments (search) via package C4::Utils::DataTables::VirtualShelves (Perhaps you forgot to load the package?) at svc/virtualshelves/search line 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #76 from Jonathan Druart --- Created attachment 187614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187614&action=edit Bug 40680: Fix admin/matching-rules.pl Attempt to call undefined import method with arguments (valid_normalization_routines) via package C4::Matcher (Perhaps you forgot to load the package?) at admin/matching-rules.pl line 27. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #72 from Jonathan Druart ---
Created attachment 187610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187610&action=edit
Bug 40680: Move EXPORT_OK right after Modern::Perl
So it is done before the other use statements.
Also uniformize the pattern, must now be:
```
use Modern::Perl;
use base 'Exporter';
BEGIN {
our @EXPORT_OK = qw(subroutine list);
}
```
Rebased-by: Victor Grousset/tuxayo
Bug38936 exported redirect_if_opac_suppressed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #100 from Jonathan Druart --- Created attachment 187951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187951&action=edit Bug 40680: Fix acqui scripts Attempt to call undefined import method with arguments (get_active) via package Koha::Acquisition::Currencies (Perhaps you forgot to load the package?) at acqui/addorder.pl line 133. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #47 from Jonathan Druart --- Created attachment 186663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186663&action=edit Bug 40680: Fix C4::Calendar imports Attempt to call undefined import method with arguments (new ...) via package C4::Calendar (Perhaps you forgot to load the package?) at t/db_dependent/Hold.t line 25. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #104 from Jonathan Druart --- Created attachment 187955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187955&action=edit Bug 40680: Fix svc/virtualshelves/search Attempt to call undefined import method with arguments (search) via package C4::Utils::DataTables::VirtualShelves (Perhaps you forgot to load the package?) at svc/virtualshelves/search line 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #101 from Jonathan Druart --- Created attachment 187952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187952&action=edit Bug 40680: Fix admin/columns_settings.pl Attempt to call undefined import method with arguments (get_modules) via package C4::Utils::DataTables::TablesSettings (Perhaps you forgot to load the package?) at admin/columns_settings.pl line 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=40989 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #80 from Jonathan Druart --- Created attachment 187618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187618&action=edit Bug 40680: Fix C4::Calendar imports Attempt to call undefined import method with arguments (new ...) via package C4::Calendar (Perhaps you forgot to load the package?) at t/db_dependent/Hold.t line 25. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #186664|0 |1 is obsolete|| --- Comment #59 from Victor Grousset/tuxayo --- Created attachment 187132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187132&action=edit Bug 40680: Fix t tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #186655|0 |1
is obsolete||
--- Comment #50 from Victor Grousset/tuxayo ---
Created attachment 187123
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187123&action=edit
Bug 40680: Move EXPORT_OK right after Modern::Perl
So it is done before the other use statements.
Also uniformize the pattern, must now be:
```
use Modern::Perl;
use base 'Exporter';
BEGIN {
our @EXPORT_OK = qw(subroutine list);
}
```
Rebased-by: Victor Grousset/tuxayo
Bug38936 exported redirect_if_opac_suppressed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #69 from David Cook --- I decided to take another look at CPAN to see how you can take over a module on CPAN without the maintainer's permission... On https://www.cpan.org/misc/cpan-faq.html the relevant sections appear to be "How do I go about maintaining a module when the author is unresponsive?" and "How do I adopt or take over a module already on CPAN?". If we want to adopt the module, we'll want 1 person to make contact with the PAUSE admins. It might be best if this is Chris Cormack since I think he's the one who has been trying to contact Srdjan. He'd probably be able to make the most compelling case. In the meantime, CPAN suggests: "If you need changes made immediately, consider applying your patches to the current module, changing the version and requiring that version for your application. Eventually the author will turn up and apply your patches, offer you maintenance of the module or, if the author doesn't respond in a year, you may get maintenance by having interest." Or "If you need changes in order for another module or application to work, consider making the needed changes and bundling the new version with your own distribution and noting the change well in the documentation. Do not upload the new version under the same namespace to CPAN until the matter has been resolved with the author or CPAN." I think the latter is probably more likely and reflects what I was saying above? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #102 from Jonathan Druart --- Created attachment 187953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187953&action=edit Bug 40680: Fix admin/matching-rules.pl Attempt to call undefined import method with arguments (valid_normalization_routines) via package C4::Matcher (Perhaps you forgot to load the package?) at admin/matching-rules.pl line 27. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #186657|0 |1 is obsolete|| --- Comment #52 from Victor Grousset/tuxayo --- Created attachment 187125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187125&action=edit Bug 40680: Fix acqui scripts Attempt to call undefined import method with arguments (get_active) via package Koha::Acquisition::Currencies (Perhaps you forgot to load the package?) at acqui/addorder.pl line 133. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #88 from Jonathan Druart --- Created attachment 187818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187818&action=edit Bug 40680: Fix acqui scripts Attempt to call undefined import method with arguments (get_active) via package Koha::Acquisition::Currencies (Perhaps you forgot to load the package?) at acqui/addorder.pl line 133. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Jonathan Druart changed: What|Removed |Added Attachment #187815|0 |1 is obsolete|| Attachment #187816|0 |1 is obsolete|| Attachment #187817|0 |1 is obsolete|| Attachment #187818|0 |1 is obsolete|| Attachment #187819|0 |1 is obsolete|| Attachment #187820|0 |1 is obsolete|| Attachment #187821|0 |1 is obsolete|| Attachment #187822|0 |1 is obsolete|| Attachment #187823|0 |1 is obsolete|| Attachment #187824|0 |1 is obsolete|| Attachment #187825|0 |1 is obsolete|| --- Comment #97 from Jonathan Druart --- Created attachment 187948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187948&action=edit Bug 40680: Remove duplicated code From commit b40ceb1cf5cb195f81347e090ade5e8bc3f316de Bug 39367: Manual changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #40 from Jonathan Druart --- Created attachment 186656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186656&action=edit Bug 40680: Fix C4/Patroncards/Patroncard.pm Attempt to call undefined import method with arguments (StrWidth) via package C4::Creators::PDF (Perhaps you forgot to load the package?) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 28. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #74 from Jonathan Druart --- Created attachment 187612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187612&action=edit Bug 40680: Fix acqui scripts Attempt to call undefined import method with arguments (get_active) via package Koha::Acquisition::Currencies (Perhaps you forgot to load the package?) at acqui/addorder.pl line 133. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #92 from Jonathan Druart --- Created attachment 187822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187822&action=edit Bug 40680: Fix svc/virtualshelves/search Attempt to call undefined import method with arguments (search) via package C4::Utils::DataTables::VirtualShelves (Perhaps you forgot to load the package?) at svc/virtualshelves/search line 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #186654|0 |1 is obsolete|| --- Comment #49 from Victor Grousset/tuxayo --- Created attachment 187122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187122&action=edit Bug 40680: Remove duplicated code From commit b40ceb1cf5cb195f81347e090ade5e8bc3f316de Bug 39367: Manual changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=40977 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=40863 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #89 from Jonathan Druart --- Created attachment 187819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187819&action=edit Bug 40680: Fix admin/columns_settings.pl Attempt to call undefined import method with arguments (get_modules) via package C4::Utils::DataTables::TablesSettings (Perhaps you forgot to load the package?) at admin/columns_settings.pl line 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #186659|0 |1 is obsolete|| --- Comment #54 from Victor Grousset/tuxayo --- Created attachment 187127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187127&action=edit Bug 40680: Fix admin/matching-rules.pl Attempt to call undefined import method with arguments (valid_normalization_routines) via package C4::Matcher (Perhaps you forgot to load the package?) at admin/matching-rules.pl line 27. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #103 from Jonathan Druart ---
Created attachment 187954
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187954&action=edit
Bug 40680: Fix TestBuilder
perl -wc misc/devel/create_test_data.pl
Attempt to call undefined import method with arguments ("schema") via package
"Koha::Database" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 5.
Attempt to call undefined import method with arguments ("_type") via package
"Koha::Biblios" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 7.
Attempt to call undefined import method with arguments ("_type") via package
"Koha::Items" (Perhaps you forgot to load the package?) at
/kohadevbox/koha/t/lib/TestBuilder.pm line 8.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #42 from Jonathan Druart --- Created attachment 186658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186658&action=edit Bug 40680: Fix admin/columns_settings.pl Attempt to call undefined import method with arguments (get_modules) via package C4::Utils::DataTables::TablesSettings (Perhaps you forgot to load the package?) at admin/columns_settings.pl line 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #96 from Victor Grousset/tuxayo --- Thanks again for all the fixes :) xt/perltidy.t starts failing with the patches I think all other t & xt tests are good. Including selenium, www, ES. I still got cypress tests to rerun to sort out random failures and actual ones. And if they are due to the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #98 from Jonathan Druart ---
Created attachment 187949
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187949&action=edit
Bug 40680: Move EXPORT_OK right after Modern::Perl
So it is done before the other use statements.
Also uniformize the pattern, must now be:
```
use Modern::Perl;
use base 'Exporter';
BEGIN {
our @EXPORT_OK = qw(subroutine list);
}
```
Rebased-by: Victor Grousset/tuxayo
Bug38936 exported redirect_if_opac_suppressed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #93 from Jonathan Druart --- Created attachment 187823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187823&action=edit Bug 40680: Fix t/Labels* Attempt to call undefined import method with arguments (split_callnumber) via package C4::ClassSplitRoutine::LCC (Perhaps you forgot to load the package?) at t/Labels.t line 22. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #75 from Jonathan Druart --- Created attachment 187613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187613&action=edit Bug 40680: Fix admin/columns_settings.pl Attempt to call undefined import method with arguments (get_modules) via package C4::Utils::DataTables::TablesSettings (Perhaps you forgot to load the package?) at admin/columns_settings.pl line 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #106 from Jonathan Druart --- Created attachment 187957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187957&action=edit Bug 40680: Fix C4::Calendar imports Attempt to call undefined import method with arguments (new ...) via package C4::Calendar (Perhaps you forgot to load the package?) at t/db_dependent/Hold.t line 25. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=40978 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 --- Comment #68 from David Cook --- It might be enough to subclass /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm and then override the methods that we need to fix for Perl 5.40 too. Not a brilliant long-term solution but a practical short-term one. -- It looks like the "RecordedBooks" integration was removed in 23.11, so if we did want to fork and do own version in Koha I guess we would just need to fork the WebService/ILS.pm, WebService/ILS/JSON.pm, and WebService/ILS/OverDrive* modules. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #82 from Jonathan Druart --- Amended "Bug 40680: Move EXPORT_OK right after Modern::Perl": add 'use Modern::Perl;' to C4/Members/Messaging.pm in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #186658|0 |1 is obsolete|| --- Comment #53 from Victor Grousset/tuxayo --- Created attachment 187126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187126&action=edit Bug 40680: Fix admin/columns_settings.pl Attempt to call undefined import method with arguments (get_modules) via package C4::Utils::DataTables::TablesSettings (Perhaps you forgot to load the package?) at admin/columns_settings.pl line 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40680] Many warnings on Perl 5.40 due to importing methods from not yet defined packages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #84 from Victor Grousset/tuxayo ---
That one is still failing, I missed it in the 1st run among the many failures:
prove t/db_dependent/Realtime_holdsqueue.t
t/db_dependent/Realtime_holdsqueue.t .. 1/2
# Failed test 'no warnings'
# at /usr/share/perl/5.40/Test/Builder.pm line 193.
# There were 1 warning(s)
# Previous test 0 ''
# Attempt to call undefined import method with arguments ("do_checkin") via
package "C4::SIP::ILS::Transaction::Checkin" (Perhaps you forgot to load the
package?) at t/db_dependent/Realtime_holdsqueue.t line 26.
# at t/db_dependent/Realtime_holdsqueue.t line 26.
# main::BEGIN() called at t/db_dependent/Realtime_holdsqueue.t line 26
# eval {...} called at t/db_dependent/Realtime_holdsqueue.t line 26
Besides that one, these tests were run and pass
--run-selenium-tests-only
--run-light-test-suite
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
