[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 --- Comment #26 from Katrin Fischer --- I love it when a plan works out :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 David Cook changed: What|Removed |Added Attachment #187033|0 |1 is obsolete|| --- Comment #25 from David Cook --- Created attachment 192582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192582&action=edit Bug 40736: Add test To test: 1. prove t/db_dependent/api/v1/idp.t Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 David Cook changed: What|Removed |Added Attachment #187032|0 |1 is obsolete|| --- Comment #24 from David Cook --- Created attachment 192581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192581&action=edit Bug 40736: Restore commented out tests Commented out by https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143438 (or https://github.com/Koha-Community/Koha/commit/9c5f6e8c1772ecb1c2ec8c25d6d32010ce6c263b#diff-9e449131ec9eb973ff6a851c0fda9a426255591e3f579c79b047fb2763f33e80R275 ) To test: 1. prove t/db_dependent/api/v1/idp.t Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 David Cook changed: What|Removed |Added Attachment #187031|0 |1 is obsolete|| --- Comment #23 from David Cook --- Created attachment 192580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192580&action=edit Bug 40736: Gracefully handle missing CGISESSID cookie This change makes the REST API gracefully handle a missing CGISESSID when trying to do an OAuth/OIDC login by direct linking. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Set up an OpenID Connect client using the wiki https://wiki.koha-community.org/wiki/Testing_SSO 2. In an incognito/private window, try directly logging in with the following URL: http://localhost:8080/api/v1/public/oauth/login/test/opac 3. Note that you're redirected to opac-user.pl with an auth error message of "No user session found" 4. Close the incognito/private window 5. In an incognito/private window, try directly logging in with the following URL: http://localhost:8081/api/v1/oauth/login/test/staff 6. Note that you're redirected to mainpage.pl with an auth error message of "No user session found" Signed-off-by: Lari Taskula Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 --- Comment #22 from Katrin Fischer --- Aha! I had missed Lari already signed the first patch - David, could you take a look at the follow-ups to move this to signed off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 --- Comment #21 from Lari Taskula --- (In reply to Katrin Fischer from comment #20) > @Lari: since you added tests, maybe you'd like to sign-off on the first > patch from David? Then David could sign your follow-ups to get this unlocked. Which patch? I have already signed off David's patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 Katrin Fischer changed: What|Removed |Added Version|unspecified |Main CC||[email protected] --- Comment #20 from Katrin Fischer --- 1) QA checks pass. 2) Code review - Nothing spotted 3) Testing - Unit tests pass: t/db_dependent/api/v1/idp.t @Lari: since you added tests, maybe you'd like to sign-off on the first patch from David? Then David could sign your follow-ups to get this unlocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 --- Comment #19 from Lari Taskula --- (In reply to Lari Taskula from comment #17) > Created attachment 187032 [details] [review] > Bug 40736: Restore commented out tests While looking for existing tests, I found idp.t tests that were commented out by Bug 31378. I assume those comment-outs were accidentally pushed. This patch restores those tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 --- Comment #17 from Lari Taskula --- Created attachment 187032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187032&action=edit Bug 40736: Restore commented out tests Commented out by https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143438 (or https://github.com/Koha-Community/Koha/commit/9c5f6e8c1772ecb1c2ec8c25d6d32010ce6c263b#diff-9e449131ec9eb973ff6a851c0fda9a426255591e3f579c79b047fb2763f33e80R275 ) To test: 1. prove t/db_dependent/api/v1/idp.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 Lari Taskula changed: What|Removed |Added Attachment #186950|0 |1 is obsolete|| --- Comment #16 from Lari Taskula --- Created attachment 187031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187031&action=edit Bug 40736: Gracefully handle missing CGISESSID cookie This change makes the REST API gracefully handle a missing CGISESSID when trying to do an OAuth/OIDC login by direct linking. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Set up an OpenID Connect client using the wiki https://wiki.koha-community.org/wiki/Testing_SSO 2. In an incognito/private window, try directly logging in with the following URL: http://localhost:8080/api/v1/public/oauth/login/test/opac 3. Note that you're redirected to opac-user.pl with an auth error message of "No user session found" 4. Close the incognito/private window 5. In an incognito/private window, try directly logging in with the following URL: http://localhost:8081/api/v1/oauth/login/test/staff 6. Note that you're redirected to mainpage.pl with an auth error message of "No user session found" Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 --- Comment #18 from Lari Taskula --- Created attachment 187033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187033&action=edit Bug 40736: Add test To test: 1. prove t/db_dependent/api/v1/idp.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34164 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 --- Comment #15 from Alex Buckley --- (In reply to David Cook from comment #13) > Alex: You'll still experience your problem but you'll get a prettier error > message at least. > > To me, BZ 40736 is just about the API log getting filled up with errors > unnecessarily. > > As for your issue, Alex... it's weird. Very weird. But unfortunately I do > think it's a local issue. Your CGISESSID cookie is missing when it shouldn't > be and you'll have to keep troubleshooting it locally I think :/. Thanks David!(In reply to David Cook from comment #13) > Alex: You'll still experience your problem but you'll get a prettier error > message at least. > > To me, BZ 40736 is just about the API log getting filled up with errors > unnecessarily. > > As for your issue, Alex... it's weird. Very weird. But unfortunately I do > think it's a local issue. Your CGISESSID cookie is missing when it shouldn't > be and you'll have to keep troubleshooting it locally I think :/. Thanks for the patches and update David. Appreciate it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 --- Comment #14 from David Cook --- I just double-checked 24.11 and its OIDC is working well with Keycloak for me as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40736] OAuth/OIDC authentication logs error message when CGISESSID is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40736 David Cook changed: What|Removed |Added Summary|OAuth/OIDC authentication |OAuth/OIDC authentication |broken when CGISESSID is|logs error message when |missing |CGISESSID is missing --- Comment #13 from David Cook --- Alex: You'll still experience your problem but you'll get a prettier error message at least. To me, BZ 40736 is just about the API log getting filled up with errors unnecessarily. As for your issue, Alex... it's weird. Very weird. But unfortunately I do think it's a local issue. Your CGISESSID cookie is missing when it shouldn't be and you'll have to keep troubleshooting it locally I think :/. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
