[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Paul Derscheid changed: What|Removed |Added Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Version(s)|25.11.00,25.05.05 |25.11.00,25.05.05,24.11.11 released in|| CC||baptiste.wojtkowski@biblibr ||e.com Status|Pushed to stable|Pushed to oldstable --- Comment #10 from Baptiste Wojtkowski (bwoj) --- Pushed into 24.11.x for 24.11.11 nice work everyone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Bug 40857 depends on bug 38222, which changed state. Bug 38222 Summary: Let staff pick a cancellation reason when canceling a booking https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 --- Comment #9 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.05 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Paul Derscheid changed: What|Removed |Added Keywords||rel_24_11_candidate, ||rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 --- Comment #3 from Paul Derscheid --- Not sure whether we recently upgraded anything, but using the strategy option in the constructor for the modal context should fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 --- Comment #8 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 --- Comment #6 from Caroline Cyr La Rose --- For release maintainers, the cancellation reason was added in version 24.11. Please backport back to that version, if possible! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |o.uk CC||[email protected] ||o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Caroline Cyr La Rose changed: What|Removed |Added Attachment #186779|0 |1 is obsolete|| --- Comment #4 from Caroline Cyr La Rose --- Created attachment 186800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186800&action=edit Bug 40857: add context parameter for modal overlay - The combobox dropdown in modals scrolled with the modal body instead of overlaying, due to Bootstrap's overflow: hidden on modals clipping extending content. - Added context parameter to combobox config; setting context: 'modal' uses Popper's fixed positioning strategy for proper overlay. - For reference: https://popper.js.org/docs/v2/constructors/#strategy To test: 1. Make an item bookable 1.1. Go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 1.2. Go to the Items tab on the left side of the screen 1.3. Under Bookable, choose Yes and click 'Update' 2. Place a booking 2.1. Click 'Place booking' at the top of the detailed record screen 2.2. Fill out the form 2.3. Click 'Submit' 3. Try to cancel the booking 3.1. Go to the 'Bookings' tab on the left side of the screen 3.2. Click 'Cancel' next to the booking --> A modal appears with a text field for the cancellation reason 3.3. Click 'No, do not cancel' 4. Add one authorised value in BOOKING_CANCELLATION 4.1. Go to Administration > Authorized values 4.2. Search for BOOKING_CANCELLATION 4.3. Click 'Add' 4.4. Fill out the form 4.5. Click 'Save' 5. Redo step 3 --> The option appears as a dropdown below the text field -- OK 6. Add one or two more authorised values 7. Redo step 3 --> The options appear as a dropdown below the text field -- OK Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #186800|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize (ashimema) --- Created attachment 186883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186883&action=edit Bug 40857: add context parameter for modal overlay - The combobox dropdown in modals scrolled with the modal body instead of overlaying, due to Bootstrap's overflow: hidden on modals clipping extending content. - Added context parameter to combobox config; setting context: 'modal' uses Popper's fixed positioning strategy for proper overlay. - For reference: https://popper.js.org/docs/v2/constructors/#strategy To test: 1. Make an item bookable 1.1. Go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 1.2. Go to the Items tab on the left side of the screen 1.3. Under Bookable, choose Yes and click 'Update' 2. Place a booking 2.1. Click 'Place booking' at the top of the detailed record screen 2.2. Fill out the form 2.3. Click 'Submit' 3. Try to cancel the booking 3.1. Go to the 'Bookings' tab on the left side of the screen 3.2. Click 'Cancel' next to the booking --> A modal appears with a text field for the cancellation reason 3.3. Click 'No, do not cancel' 4. Add one authorised value in BOOKING_CANCELLATION 4.1. Go to Administration > Authorized values 4.2. Search for BOOKING_CANCELLATION 4.3. Click 'Add' 4.4. Fill out the form 4.5. Click 'Save' 5. Redo step 3 --> The option appears as a dropdown below the text field -- OK 6. Add one or two more authorised values 7. Redo step 3 --> The options appear as a dropdown below the text field -- OK Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 --- Comment #5 from Caroline Cyr La Rose --- Thanks Paul! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Paul Derscheid changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 --- Comment #2 from Paul Derscheid --- Created attachment 186779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186779&action=edit Bug 40857: add context parameter for modal overlay - The combobox dropdown in modals scrolled with the modal body instead of overlaying, due to Bootstrap's overflow: hidden on modals clipping extending content. - Added context parameter to combobox config; setting context: 'modal' uses Popper's fixed positioning strategy for proper overlay. - For reference: https://popper.js.org/docs/v2/constructors/#strategy To test: 1. Make an item bookable 1.1. Go to a record (e.g. http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=285) 1.2. Go to the Items tab on the left side of the screen 1.3. Under Bookable, choose Yes and click 'Update' 2. Place a booking 2.1. Click 'Place booking' at the top of the detailed record screen 2.2. Fill out the form 2.3. Click 'Submit' 3. Try to cancel the booking 3.1. Go to the 'Bookings' tab on the left side of the screen 3.2. Click 'Cancel' next to the booking --> A modal appears with a text field for the cancellation reason 3.3. Click 'No, do not cancel' 4. Add one authorised value in BOOKING_CANCELLATION 4.1. Go to Administration > Authorized values 4.2. Search for BOOKING_CANCELLATION 4.3. Click 'Add' 4.4. Fill out the form 4.5. Click 'Save' 5. Redo step 3 --> The option appears as a dropdown below the text field -- OK 6. Add one or two more authorised values 7. Redo step 3 --> The options appear as a dropdown below the text field -- OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Paul Derscheid changed: What|Removed |Added CC||[email protected] Severity|enhancement |normal Assignee|[email protected] |[email protected] --- Comment #1 from Paul Derscheid --- Hi Caroline, will take a look right away. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 Caroline Cyr La Rose changed: What|Removed |Added Depends on||38222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 [Bug 38222] Let staff pick a cancellation reason when canceling a booking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
