[Koha-bugs] [Bug 40860] ILL get_notice does not consider HTML template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 Katrin Fischer changed: What|Removed |Added Attachment #186788|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 192393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192393&action=edit Bug 40860: Consider is_html template notice Change logic of get_notice to fetch the template before GetPreparedLetter. This allows to verify is the template is HTML or not, and act accordingly. Test plan, before applying patch: 1) Enable ILLModule 2) Edit the default ktd ILL partner patron and add a primary email address: /cgi-bin/koha/circ/circulation.pl?borrowernumber=16 3) Create a new ILL request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add some metadata like title and author, after creation click 'Place request with partners'. 'FRL - Walker' should show up as an option. Select that and click 'Send email'. 5) Run the following query to grab the produced email content: $ koha-mysql kohadev $ SELECT content FROM message_queue; 6) Utilize an HTML previewer (to avoid having to send the mail for testing): https://html.onlineviewer.net/ 7) Paste the contents there, notice there's no line breaks when shown as HTML. 8) Apply patch, restart plack, repeat test plan. Notice the HTML preview has appropriate line breaks for each metadata entry. Please note that any other remaining line breaks need to replaced by a tag but that is besides the ill_full_metadata substitution scope of this patch. Signed-off-by: Katrin Fischer Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40860] ILL get_notice does not consider HTML template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 Katrin Fischer changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org |k Status|Needs Signoff |Signed Off --- Comment #3 from Katrin Fischer --- 1) QA checks - passing 2) Code review 3) Testing All worked well after I restart_all. I am not super happy about the hardcoded formatting of [% ill_full_metadata %]. We now have breaks, which is nice, but we can not determine what is printed ,cannot turn it into a proper html formatted list as the - seems hardcoded, cannot change formatting etc. I feel like at some point we will want to replace this with a proper object where we can also modify/translate labels etc. This is still a nice small enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40860] ILL get_notice does not consider HTML template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 --- Comment #1 from Pedro Amorim --- Created attachment 186787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186787&action=edit Bug 40860: Consider is_html template notice Change logic of get_notice to fetch the template before GetPreparedLetter. This allows to verify is the template is HTML or not, and act accordingly. Test plan, before applying patch: 1) Enable ILLModule 2) Edit the default ktd ILL partner patron and add a primary email address: /cgi-bin/koha/circ/circulation.pl?borrowernumber=16 3) Create a new ILL request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add some metadata like title and author, after creation click 'Place request with partners'. 'FRL - Walker' should show up as an option. Select that and click 'Send email'. 5) Run the following query to grab the produced email content: $ koha-mysql kohadev $ SELECT content FROM message_queue; 6) Utilize an HTML previewer (to avoid having to send the mail for testing): https://html.onlineviewer.net/ 7) Paste the contents there, notice there's no line breaks when shown as HTML. 8) Apply patch, restart plack, repeat test plan. Notice the HTML preview has appropriate line breaks for each metadata entry. Please note that any other remaining line breaks need to replaced by a tag but that is besides the ill_full_metadata substitution scope of this patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40860] ILL get_notice does not consider HTML template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 Pedro Amorim changed: What|Removed |Added Attachment #186787|0 |1 is obsolete|| --- Comment #2 from Pedro Amorim --- Created attachment 186788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186788&action=edit Bug 40860: Consider is_html template notice Change logic of get_notice to fetch the template before GetPreparedLetter. This allows to verify is the template is HTML or not, and act accordingly. Test plan, before applying patch: 1) Enable ILLModule 2) Edit the default ktd ILL partner patron and add a primary email address: /cgi-bin/koha/circ/circulation.pl?borrowernumber=16 3) Create a new ILL request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add some metadata like title and author, after creation click 'Place request with partners'. 'FRL - Walker' should show up as an option. Select that and click 'Send email'. 5) Run the following query to grab the produced email content: $ koha-mysql kohadev $ SELECT content FROM message_queue; 6) Utilize an HTML previewer (to avoid having to send the mail for testing): https://html.onlineviewer.net/ 7) Paste the contents there, notice there's no line breaks when shown as HTML. 8) Apply patch, restart plack, repeat test plan. Notice the HTML preview has appropriate line breaks for each metadata entry. Please note that any other remaining line breaks need to replaced by a tag but that is besides the ill_full_metadata substitution scope of this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40860] ILL get_notice does not consider HTML template notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40860 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
