[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 David Nind changed: What|Removed |Added Status|Needs documenting |RESOLVED CC||[email protected] Resolution|--- |FIXED --- Comment #8 from David Nind --- Plugin development related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Status|Pushed to stable|Needs documenting --- Comment #7 from Fridolin Somers --- I prefer not backport to 24.11.x since it is a LTS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 --- Comment #6 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Paul Derscheid changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.06 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983
Marcel de Rooy changed:
What|Removed |Added
Attachment #187652|0 |1
is obsolete||
--- Comment #2 from Marcel de Rooy ---
Created attachment 187715
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187715&action=edit
Bug 40983: Complete deprecation of old after_biblio_action hook signature
This patch completes the deprecation cycle started in bug 36343 by
removing the backward compatibility code and deprecation warnings for
the old after_biblio_action hook signature.
Changes made:
1. Removed the duplicate biblio and biblio_id parameters from
_after_biblio_action_hooks in C4::Biblio that were marked for
deprecation in 24.11.00
2. Updated the test plugin to use only the new payload-based signature,
ensuring all parameters are accessed via $params->{payload}
The after_biblio_action hook now consistently uses the modern signature
with a payload parameter, matching the pattern used by other plugin hooks
like before_biblio_action, after_item_action, and after_hold_action.
Test plan:
1. Run: prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
2. Run: prove t/db_dependent/Koha/Plugins/
3. Run: prove t/db_dependent/Biblio.t
4. All tests should pass
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983
--- Comment #1 from Martin Renvoize (ashimema)
---
Created attachment 187652
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187652&action=edit
Bug 40983: Complete deprecation of old after_biblio_action hook signature
This patch completes the deprecation cycle started in bug 36343 by
removing the backward compatibility code and deprecation warnings for
the old after_biblio_action hook signature.
Changes made:
1. Removed the duplicate biblio and biblio_id parameters from
_after_biblio_action_hooks in C4::Biblio that were marked for
deprecation in 24.11.00
2. Updated the test plugin to use only the new payload-based signature,
ensuring all parameters are accessed via $params->{payload}
The after_biblio_action hook now consistently uses the modern signature
with a payload parameter, matching the pattern used by other plugin hooks
like before_biblio_action, after_item_action, and after_hold_action.
Test plan:
1. Run: prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
2. Run: prove t/db_dependent/Koha/Plugins/
3. Run: prove t/db_dependent/Biblio.t
4. All tests should pass
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 --- Comment #5 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Martin Renvoize (ashimema) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Martin Renvoize (ashimema) changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Marcel de Rooy --- Trivial patch. SO and QA in one pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Martin Renvoize (ashimema) changed: What|Removed |Added CC||[email protected], ||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Martin Renvoize (ashimema) changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Martin Renvoize (ashimema) changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 --- Comment #3 from Marcel de Rooy --- Created attachment 187716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187716&action=edit Bug 40983: (QA follow-up) Add a (final) upgrade warn Just a last wake up call. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40983] Remove deprecated syntax for 'after_biblio_action' hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40983 Marcel de Rooy changed: What|Removed |Added Text to go in the||IMPORTANT: The former release notes||biblio and biblio_id params ||of after_biblio_action ||hooks/plugins have been ||removed now. They were ||deprecated on bug 36343 and ||replaced by the payload ||hash. Please adjust your ||plugins using them, if you ||did not do so already. QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
