[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||[email protected] ||m Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in|| --- Comment #11 from Fridolin Somers --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 --- Comment #10 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Paul Derscheid changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.06 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 --- Comment #9 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Brendan Lawlor changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Brendan Lawlor changed: What|Removed |Added CC||[email protected] --- Comment #8 from Brendan Lawlor --- This change makes sense because batchMod.pl expects a multi param named itemnumber. Before this patch the batch_item_modification and batch_item_deletion forms' inputs for itemnumbers were being rendered with the renamed column as name attribute instead of just 'itemnumber'. Nice! Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Brendan Lawlor changed: What|Removed |Added Attachment #188419|0 |1 is obsolete|| --- Comment #7 from Brendan Lawlor --- Created attachment 188523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188523&action=edit Bug 41082: Fix batch tools from reports when itemnumber col has been renamed Description from comment 0 When creating an SQL report and it contains the column itemnumber, we activate batch operations above the table. The itemnumber column can be renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us the option to translate the column name into something nicer for display. But: if you then send to batch item edit, the items are not transmitted. Test plan: 1) Create a report: select itemnumber, itemcallnumber from items; 2) Send some items to batch item edit, verify the items are shown above the item form 3) Update the report: select [[itemnumber|Exemplarnummer]], itemcallnumber from items; 4) Verify the report still shows as before with the batch options available and only the column being renamed. 5) Send some items to the batch item edit again => verify the items are shown above the item form Signed-off-by: Owen Leonard Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Brendan Lawlor changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 --- Comment #6 from Jonathan Druart --- (In reply to Owen Leonard from comment #5) > Edit the patch to remove the change to yarn.lock which I assumed to be > accidental. Yes, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 --- Comment #5 from Owen Leonard --- Edit the patch to remove the change to yarn.lock which I assumed to be accidental. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Owen Leonard changed: What|Removed |Added Attachment #188321|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 188419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188419&action=edit Bug 41082: Fix batch tools from reports when itemnumber col has been renamed Description from comment 0 When creating an SQL report and it contains the column itemnumber, we activate batch operations above the table. The itemnumber column can be renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us the option to translate the column name into something nicer for display. But: if you then send to batch item edit, the items are not transmitted. Test plan: 1) Create a report: select itemnumber, itemcallnumber from items; 2) Send some items to batch item edit, verify the items are shown above the item form 3) Update the report: select [[itemnumber|Exemplarnummer]], itemcallnumber from items; 4) Verify the report still shows as before with the batch options available and only the column being renamed. 5) Send some items to the batch item edit again => verify the items are shown above the item form Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 --- Comment #3 from Katrin Fischer --- But then they are exploiting a bug, I don't feel like we should account for that. The batch options are still showing, they are just broken. So it's not really nixed. You can just use itemnumber as if you want to nix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 [email protected] changed: What|Removed |Added CC||[email protected] --- Comment #2 from [email protected] --- Heh, I suspect this is a case of a bug that will break some folks' workflows - there are some libraries that use this 'trick' to nix the data links and batch options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Jonathan Druart changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | Version|24.11 |unspecified CC||[email protected] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 --- Comment #1 from Jonathan Druart --- Created attachment 188321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188321&action=edit Bug 41082: Fix batch tools from reports when itemnumber col has been renamed Description from comment 0 When creating an SQL report and it contains the column itemnumber, we activate batch operations above the table. The itemnumber column can be renamed, using the syntax [[itemnumber|Exemplarnummer]], which gives us the option to translate the column name into something nicer for display. But: if you then send to batch item edit, the items are not transmitted. Test plan: 1) Create a report: select itemnumber, itemcallnumber from items; 2) Send some items to batch item edit, verify the items are shown above the item form 3) Update the report: select [[itemnumber|Exemplarnummer]], itemcallnumber from items; 4) Verify the report still shows as before with the batch options available and only the column being renamed. 5) Send some items to the batch item edit again => verify the items are shown above the item form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41082] Renaming columns in reports doesn't work with batch tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41082 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
