[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 David Nind changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC||[email protected] --- Comment #20 from David Nind --- Accessibility improvement, no change required to the manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Needs documenting CC||[email protected] ||m --- Comment #19 from Fridolin Somers --- Hard to apply on 24.11.x LTS I skip -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lucas Gass (lukeg) changed: What|Removed |Added Blocks||41368 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 [Bug 41368] Tools/ManageMarcImport_spec.ts is failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 --- Comment #18 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #17 from Lucas Gass (lukeg) --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Paul Derscheid changed: What|Removed |Added Attachment #189931|0 |1 is obsolete|| --- Comment #16 from Paul Derscheid --- Created attachment 189932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189932&action=edit Bug 41177: Adjust Cypress tests Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 --- Comment #15 from Lucas Gass (lukeg) --- Created attachment 189931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189931&action=edit Bug 41177: Adjust Cypress tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 --- Comment #14 from Paul Derscheid --- I think the exact error was something like that, yeah. CSS evaluating to `pointer-events: none`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177
--- Comment #13 from Owen Leonard ---
I don't know Cypress but is this the problematic line?
cy.contains("Manage staged MARC records").click();
Is the "click" not being registered because there is not longer an href
attribute?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected] Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Paul Derscheid changed: What|Removed |Added CC||[email protected] --- Comment #12 from Paul Derscheid --- Hi there, I think the second commit breaks Tools/ManageMarcImport_spec.ts, see Koha_Main, run #3445 for reference. Probably just some markup that shifted around. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 --- Comment #11 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lisette Scheer changed: What|Removed |Added CC||[email protected] ||m Keywords||release-notes-needed QA Contact|[email protected] |[email protected] |y.org |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lisette Scheer changed: What|Removed |Added Attachment #189651|0 |1 is obsolete|| --- Comment #10 from Lisette Scheer --- Created attachment 189653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189653&action=edit Bug 41177: (follow-up) A few minor corrections This patch makes the following corrections: - Remove link from breadcrumb WRAPPER items. The right markup is generated in html_helpers.inc if you add the "bc_active = 1" to the breadcrumb_item WRAPPER. - Remove "href='#'" from inactive links, and adjust CSS accordingly. The W3C validator doesn't like it when a true "aria-disabled" attribute is on a link which has an href attribute. Signed-off-by: Jake Deery Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lisette Scheer changed: What|Removed |Added Attachment #189188|0 |1 is obsolete|| --- Comment #9 from Lisette Scheer --- Created attachment 189652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189652&action=edit Bug 41177: Add aria-disabled to breadcrumbs This patch adds aria-disabled and tabindex = -1 to a breadcrumb, if it is the current page. This aids in accesssibility, and is generally good practice. == TO TEST: == a) Visit any page on the OPAC, and inspect the breadcrumb pertinent to the current page *) Notice the lack of aria-disabled and tabindex on the inspected element == APPLY PATCH == b) repeat step a *) Notice how there is now an aria-disabled and tabindex = -1 *) Notice you cannot tab on to the final breadcrumb anymore c) Ensure other breadcrumbs are unaffected and still work as links == SIGN OFF == Signed-off-by: Owen Leonard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lisette Scheer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Lisette Scheer changed: What|Removed |Added Attachment #189262|0 |1 is obsolete|| --- Comment #8 from Lisette Scheer --- Created attachment 189651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189651&action=edit Bug 41177: (follow-up) A few minor corrections This patch makes the following corrections: - Remove link from breadcrumb WRAPPER items. The right markup is generated in html_helpers.inc if you add the "bc_active = 1" to the breadcrumb_item WRAPPER. - Remove "href='#'" from inactive links, and adjust CSS accordingly. The W3C validator doesn't like it when a true "aria-disabled" attribute is on a link which has an href attribute. Signed-off-by: Jake Deery Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Jake Deery changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Jake Deery --- Thanks for that, Owen. Looks good to me, signed off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Jake Deery changed: What|Removed |Added Attachment #189261|0 |1 is obsolete|| --- Comment #6 from Jake Deery --- Created attachment 189262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189262&action=edit Bug 41177: (follow-up) A few minor corrections This patch makes the following corrections: - Remove link from breadcrumb WRAPPER items. The right markup is generated in html_helpers.inc if you add the "bc_active = 1" to the breadcrumb_item WRAPPER. - Remove "href='#'" from inactive links, and adjust CSS accordingly. The W3C validator doesn't like it when a true "aria-disabled" attribute is on a link which has an href attribute. Signed-off-by: Jake Deery -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Jake Deery changed: What|Removed |Added Attachment #189189|0 |1 is obsolete|| --- Comment #5 from Jake Deery --- Created attachment 189261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189261&action=edit Bug 41177: (follow-up) A few minor corrections This patch makes the following corrections: - Remove link from breadcrumb WRAPPER items. The right markup is generated in html_helpers.inc if you add the "bc_active = 1" to the breadcrumb_item WRAPPER. - Remove "href='#'" from inactive links, and adjust CSS accordingly. The W3C validator doesn't like it when a true "aria-disabled" attribute is on a link which has an href attribute. Signed-of-by: Jake Deery -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 --- Comment #4 from Owen Leonard --- Jake I hope my follow-up makes sense! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 --- Comment #3 from Owen Leonard --- Created attachment 189189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189189&action=edit Bug 41177: (follow-up) A few minor corrections This patch makes the following corrections: - Remove link from breadcrumb WRAPPER items. The right markup is generated in html_helpers.inc if you add the "bc_active = 1" to the breadcrumb_item WRAPPER. - Remove "href='#'" from inactive links, and adjust CSS accordingly. The W3C validator doesn't like it when a true "aria-disabled" attribute is on a link which has an href attribute. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Owen Leonard changed: What|Removed |Added Attachment #189033|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 189188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189188&action=edit Bug 41177: Add aria-disabled to breadcrumbs This patch adds aria-disabled and tabindex = -1 to a breadcrumb, if it is the current page. This aids in accesssibility, and is generally good practice. == TO TEST: == a) Visit any page on the OPAC, and inspect the breadcrumb pertinent to the current page *) Notice the lack of aria-disabled and tabindex on the inspected element == APPLY PATCH == b) repeat step a *) Notice how there is now an aria-disabled and tabindex = -1 *) Notice you cannot tab on to the final breadcrumb anymore c) Ensure other breadcrumbs are unaffected and still work as links == SIGN OFF == Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Jake Deery changed: What|Removed |Added Assignee|[email protected] |[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 Jake Deery changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 --- Comment #1 from Jake Deery --- Created attachment 189033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189033&action=edit Bug 41177: Add aria-disabled to breadcrumbs This patch adds aria-disabled and tabindex = -1 to a breadcrumb, if it is the current page. This aids in accesssibility, and is generally good practice. == TO TEST: == a) Visit any page on the OPAC, and inspect the breadcrumb pertinent to the current page *) Notice the lack of aria-disabled and tabindex on the inspected element == APPLY PATCH == b) repeat step a *) Notice how there is now an aria-disabled and tabindex = -1 *) Notice you cannot tab on to the final breadcrumb anymore c) Ensure other breadcrumbs are unaffected and still work as links == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
