[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #11 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart changed: What|Removed |Added Attachment #189799|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart changed: What|Removed |Added Attachment #189798|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart changed: What|Removed |Added Attachment #189797|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #10 from Jonathan Druart --- Created attachment 189830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189830&action=edit Bug 41271: Revert follow-up from bug 37893 This was a bad workaround. It was ugly and is no longer relevant now that pod_coverage.t no longer attempts to launch a SIP server. prove xt/author/pod_coverage.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #9 from Jonathan Druart --- Created attachment 189829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189829&action=edit Bug 41271: Fix pod_coverage for SIPServer.pm Because the file is now being properly checked for pod_coverage, it fails (because a lot of methods dont have pod coverage. Add here Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #8 from Jonathan Druart --- Created attachment 189828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189828&action=edit Bug 41271: Dont run Net::Server::PreFork->run on 'require' or 'use' By using 'unless caller' we ensure the class is not executed when Pod::Coverage->new does 'require C4/SIP/SIPServer.pm Ensure no regressions are added: prove t/db_dependent/SIP/* koha-sip --restart kohadev koha-sip --status kohadev Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim changed: What|Removed |Added Depends on||37893 --- Comment #7 from Pedro Amorim --- I don't think this should be backported as it's cleaning up an inconsequential bug only made evident by bug 37893 - which is not backportable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [Bug 37893] Migrate some SIP configuration into the staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #6 from Pedro Amorim --- Had a chat with Joubu about this and I agree with his opinion that the 'die' patch from bug 37893 was ugly. I believe we both agree that adding 'unless caller' to SIPServer.pm is the most sensible approach here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #5 from Pedro Amorim --- Created attachment 189799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189799&action=edit Bug 41271: Revert follow-up from bug 37893 This was a bad workaround. It was ugly and is no longer relevant now that pod_coverage.t no longer attempts to launch a SIP server. prove xt/author/pod_coverage.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #4 from Pedro Amorim --- Created attachment 189798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189798&action=edit Bug 41271: Fix pod_coverage for SIPServer.pm Because the file is now being properly checked for pod_coverage, it fails (because a lot of methods dont have pod coverage. Add here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #3 from Pedro Amorim --- Created attachment 189797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189797&action=edit Bug 41271: Dont run Net::Server::PreFork->run on 'require' or 'use' By using 'unless caller' we ensure the class is not executed when Pod::Coverage->new does 'require C4/SIP/SIPServer.pm Ensure no regressions are added: prove t/db_dependent/SIP/* koha-sip --restart kohadev koha-sip --status kohadev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org |k QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim changed: What|Removed |Added Attachment #189713|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim changed: What|Removed |Added Summary|pod_coverage.t skips over |pod_coverage.t |files that fail silently|unintentionally attempts to ||launch a SIP server when ||checking SIPServer.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
