[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=41364 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #11 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Attachment #190108|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Attachment #190107|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #10 from Tomás Cohen Arazi (tcohen) --- Created attachment 190114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190114&action=edit Bug 41336: (follow-up) Fix breadcrumb selector in Cypress test The test was looking for .current class but the Vue component uses aria-current="page" attribute instead. Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #9 from Tomás Cohen Arazi (tcohen) --- Created attachment 190113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190113&action=edit Bug 41336: Fix current (?) On top of "Bug 41354: Fix record sources Vue app" there is still one failing test for t/cypress/integration/Admin/RecordSources_spec.ts 1) Breadcrumbs tests Breadcrumbs: AssertionError: Timed out retrying after 1ms: Expected to find element: `.current`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) This patch is trying to fix it but it does not Signed-off-by: Nick Clemens Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #8 from Tomás Cohen Arazi (tcohen) --- Created attachment 190112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190112&action=edit Bug 41336: Remove 'No match found for location with path' warnings Cypress tests for Vue app are currently failing because of the following warnings in the console: "[Vue Router warn] No match found for location with path" It happens for routes that are disabled. We should not build a router-link but a "disabled" link instead. Signed-off-by: Nick Clemens Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added CC||[email protected] QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Nick Clemens (kidclamp) changed: What|Removed |Added CC||[email protected] --- Comment #7 from Nick Clemens (kidclamp) --- These worked for me, the tests all pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #190079|0 |1 is obsolete|| --- Comment #6 from Nick Clemens (kidclamp) --- Created attachment 190108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190108&action=edit Bug 41336: Fix current (?) On top of "Bug 41354: Fix record sources Vue app" there is still one failing test for t/cypress/integration/Admin/RecordSources_spec.ts 1) Breadcrumbs tests Breadcrumbs: AssertionError: Timed out retrying after 1ms: Expected to find element: `.current`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) This patch is trying to fix it but it does not Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #190077|0 |1 is obsolete|| --- Comment #5 from Nick Clemens (kidclamp) --- Created attachment 190107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190107&action=edit Bug 41336: Remove 'No match found for location with path' warnings Cypress tests for Vue app are currently failing because of the following warnings in the console: "[Vue Router warn] No match found for location with path" It happens for routes that are disabled. We should not build a router-link but a "disabled" link instead. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #4 from David Nind --- It does fix 'No match found for location with path' warnings 8-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 David Nind changed: What|Removed |Added Depends on||41354 CC||[email protected] --- Comment #3 from David Nind --- The tests still don't pass for me, even with bug 41354 and 41355 applied first - yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts: 1) Breadcrumbs tests Breadcrumbs: AssertionError: Timed out retrying after 1ms: Expected to find element: `.current`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) Testing notes (using KTD): 1. Enable ERM (ERMModule system preference) 2. Turn on the developer tools for your browser 3. Go to the ERM landing page 4. Note these warnings in the console: - [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings" - [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eholdings/local" - [Vue Router warn]: No match found for location with path "/cgi-bin/koha/erm/eusage" 5. Bonus: Test other areas of ERM and modules that use Vue and DataTables, such as preservation. 7. Run the test: yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts 8. Apply the patches. 9. yarn build 10. restart_all 11. Repeat steps 3-7: no warnings, test passes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41354 [Bug 41354] Error when loading "Record sources" Vue app -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #2 from Jonathan Druart --- Created attachment 190079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190079&action=edit Bug 41336: Fix current (?) On top of "Bug 41354: Fix record sources Vue app" there is still one failing test for t/cypress/integration/Admin/RecordSources_spec.ts 1) Breadcrumbs tests Breadcrumbs: AssertionError: Timed out retrying after 1ms: Expected to find element: `.current`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) This patch is trying to fix it but it does not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Jonathan Druart changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | CC||[email protected], ||[email protected] ||o.uk Keywords||rel_25_11_candidate Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 --- Comment #1 from Jonathan Druart --- Created attachment 190077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190077&action=edit Bug 41336: Remove 'No match found for location with path' warnings Cypress tests for Vue app are currently failing because of the following warnings in the console: "[Vue Router warn] No match found for location with path" It happens for routes that are disabled. We should not build a router-link but a "disabled" link instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41336] Vue Router warn on Vue datatable pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41336 Lucas Gass (lukeg) changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=41328 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
