subject:"\[Koha\-bugs\] \[Bug 41358\] action logs info column should always store JSON"

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-09-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Baptiste Wojtkowski (bwoj)  changed:

   What|Removed |Added

 CC||baptiste.wojtkowski@biblibr
   ||e.com
 Version(s)|26.11.00,26.05.03   |26.11.00,26.05.03,25.11.09
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #37 from Baptiste Wojtkowski (bwoj) 
 ---
Pushed into 25.11.x for 25.11.09 nice work everyone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-08-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Lucas Gass (lukeg)  changed:

   What|Removed |Added

   Keywords|rel_26_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-08-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #36 from Lucas Gass (lukeg)  ---
Nice work everyone!

Pushed to 26.05.x for the upcoming 26.05.03 release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-08-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Pushed to main  |Pushed to stable
 Version(s)|26.11.00|26.11.00,26.05.03
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-16 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #35 from Pedro Amorim (ammopt)  ---
Thanks everyone! Pushed to main for 26.11!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-16 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Pedro Amorim (ammopt)  changed:

   What|Removed |Added

 Version(s)||26.11.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #34 from Lisette Scheer  ---
Created attachment 201671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201671&action=edit
Bug 41358: Apply consistent JSON logging to holds (Bug 40866)

Bug 40866 introduced JSON logging for HOLDS CREATE but stored null for
'confirmations' and 'forced' when no overrides were present. This patch
mirrors the earlier change to CIRCULATION ISSUE by defaulting them to
empty arrays, keeping the two log streams structurally identical and
simplifying reporting queries.

Changes:

C4/Reserves.pm:
- Default confirmations/forced to [] in the AddReserve log payload.

t/db_dependent/Reserves.t:
- Update the Bug 40866 subtest to assert the empty-array defaults on
  normal holds, and fix a 'my $log_data' redeclaration.

tools/viewlog.pl:
- Extend the CSV export JSON-decode block to also cover HOLDS logs,
  guarding the item lookup on itemnumber being present (HOLDS payloads
  may lack one) and filling the CSV item columns from the decoded
  payload. The legacy bare-itemnumber fallback is restricted to
  CIRCULATION so a legacy HOLDS hold_id is not mistaken for an
  itemnumber.

koha-tmpl/intranet-tmpl/prog/js/viewlog.js:
- Extend the info column override rendering (renderCircInfo) to HOLDS
  entries so forced/confirmations arrays display translated, exactly as
  they do for CIRCULATION. The log viewer moved to an ajax datatable in
  bug 29016, so this replaces the earlier json_found change to
  viewlog.pl/viewlog.tt.

misc/maintenance/migrate_action_logs_to_json.pl:
- Extended to handle legacy pre-Bug 40866 HOLDS CREATE logs where info
  is a bare hold_id, recovering branchcode / biblionumber / itemnumber
  from old_reserves / reserves.
- Uses the same keyset-pagination pattern as the circulation loop so
  rows are not skipped under --commit.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 
Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #33 from Lisette Scheer  ---
Created attachment 201670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201670&action=edit
Bug 41358: Log forced overrides for offline and ILL checkouts

This patch updates offline circulation and ILL checkouts to properly
record their nature in circulation logs as forced transactions.

Offline circulation (process_koc.pl):
- Offline transactions have already occurred without access to normal
  circulation checks
- Now marks these as forced with 'OFFLINE_CIRCULATION' override code
- This helps identify historical transactions that bypassed checks

ILL checkouts (Koha/ILL/Request.pm):
- ILL checkouts are system-initiated and may bypass certain restrictions
  by design
- Now marks these as forced with 'ILL_CHECKOUT' override code
- This helps track and report on ILL circulation activity separately

Display updates (action-logs.inc):
- Added translation strings for both new override codes:
  - OFFLINE_CIRCULATION: "Offline circulation checkout"
  - ILL_CHECKOUT: "ILL system checkout"
- These will now display properly in Tools > Log viewer

This ensures these special checkout types are properly identified in
reporting and analysis, making it easier to understand the context
of historical transactions.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 
Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #32 from Lisette Scheer  ---
Created attachment 201669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201669&action=edit
Bug 41358: Add migration script for legacy circulation logs

This patch adds an out-of-band migration script to convert legacy
CIRCULATION ISSUE action logs from the old itemnumber-only format
to the new consistent JSON format.

The script:
- Finds all CIRCULATION ISSUE logs where info is just an itemnumber
- Converts them to JSON format with the standard structure
- Attempts to recover issue_id and branchcode from old_issues/issues
- Runs in dry-run mode by default (--commit flag to actually update)
- Processes in batches to handle large databases safely
- Includes verbose mode for detailed output

Usage:
  perl misc/maintenance/migrate_action_logs_to_json.pl --help
  perl misc/maintenance/migrate_action_logs_to_json.pl --verbose
  perl misc/maintenance/migrate_action_logs_to_json.pl --commit

This is designed as an out-of-band maintenance script rather than
an atomic update because:
1. May be expensive on large databases with many log entries
2. Migration is optional - display code handles both formats
3. Can be run during off-peak hours at admin's discretion

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 
Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #31 from Lisette Scheer  ---
Created attachment 201668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201668&action=edit
Bug 41358: Always store circulation logs in consistent JSON format

Previously, CIRCULATION ISSUE logs would store just the itemnumber when
there were no confirmations or forced overrides, but would store a full
JSON structure when overrides were present. This inconsistency makes
reporting difficult as queries need to handle both formats.

This patch changes AddIssue to always store logs in JSON format,
matching the pattern already used in AddRenewal. The JSON structure
now consistently includes:
- issue: issue_id
- branchcode: branchcode
- itemnumber: itemnumber
- confirmations: array of confirmation codes (empty array if none)
- forced: array of forced override codes (empty array if none)

Benefits:
- Consistent data format simplifies reporting and analysis
- Matches existing RENEWAL logging pattern
- Display code (tools/viewlog.pl) already handles both formats,
  so backward compatibility is maintained

Test plan:
1. prove t/db_dependent/Circulation.t
2. Perform a normal checkout - verify action log contains JSON
3. Perform a checkout with overrides - verify confirmations/forced
   are populated in the JSON
4. Check Tools > Log viewer - both types should display correctly

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 
Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Lisette Scheer  changed:

   What|Removed |Added

 Attachment #201578|0   |1
is obsolete||
 Attachment #201579|0   |1
is obsolete||
 Attachment #201580|0   |1
is obsolete||
 Attachment #201581|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Lisette Scheer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #30 from Lisette Scheer  ---
Worked great. The error I was getting before was because of my custom.sql file.

The logs show nice text for the confirmations (example: Item was issued to
another patron prior to this checkout) but the JSON is stored ({ "branchcode" :
"CPL", "confirmations" : [ "ISSUED_TO_ANOTHER" ], "forced" : [], "issue" : 151,
"itemnumber" : 20 } ).
There's a seperate Bug 43014 that I discovered during testing. It's also
present on main.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #29 from Martin Renvoize (ashimema) 
 ---
Created attachment 201581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201581&action=edit
Bug 41358: Apply consistent JSON logging to holds (Bug 40866)

Bug 40866 introduced JSON logging for HOLDS CREATE but stored null for
'confirmations' and 'forced' when no overrides were present. This patch
mirrors the earlier change to CIRCULATION ISSUE by defaulting them to
empty arrays, keeping the two log streams structurally identical and
simplifying reporting queries.

Changes:

C4/Reserves.pm:
- Default confirmations/forced to [] in the AddReserve log payload.

t/db_dependent/Reserves.t:
- Update the Bug 40866 subtest to assert the empty-array defaults on
  normal holds, and fix a 'my $log_data' redeclaration.

tools/viewlog.pl:
- Extend the CSV export JSON-decode block to also cover HOLDS logs,
  guarding the item lookup on itemnumber being present (HOLDS payloads
  may lack one) and filling the CSV item columns from the decoded
  payload. The legacy bare-itemnumber fallback is restricted to
  CIRCULATION so a legacy HOLDS hold_id is not mistaken for an
  itemnumber.

koha-tmpl/intranet-tmpl/prog/js/viewlog.js:
- Extend the info column override rendering (renderCircInfo) to HOLDS
  entries so forced/confirmations arrays display translated, exactly as
  they do for CIRCULATION. The log viewer moved to an ajax datatable in
  bug 29016, so this replaces the earlier json_found change to
  viewlog.pl/viewlog.tt.

misc/maintenance/migrate_action_logs_to_json.pl:
- Extended to handle legacy pre-Bug 40866 HOLDS CREATE logs where info
  is a bare hold_id, recovering branchcode / biblionumber / itemnumber
  from old_reserves / reserves.
- Uses the same keyset-pagination pattern as the circulation loop so
  rows are not skipped under --commit.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #28 from Martin Renvoize (ashimema) 
 ---
Created attachment 201580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201580&action=edit
Bug 41358: Log forced overrides for offline and ILL checkouts

This patch updates offline circulation and ILL checkouts to properly
record their nature in circulation logs as forced transactions.

Offline circulation (process_koc.pl):
- Offline transactions have already occurred without access to normal
  circulation checks
- Now marks these as forced with 'OFFLINE_CIRCULATION' override code
- This helps identify historical transactions that bypassed checks

ILL checkouts (Koha/ILL/Request.pm):
- ILL checkouts are system-initiated and may bypass certain restrictions
  by design
- Now marks these as forced with 'ILL_CHECKOUT' override code
- This helps track and report on ILL circulation activity separately

Display updates (action-logs.inc):
- Added translation strings for both new override codes:
  - OFFLINE_CIRCULATION: "Offline circulation checkout"
  - ILL_CHECKOUT: "ILL system checkout"
- These will now display properly in Tools > Log viewer

This ensures these special checkout types are properly identified in
reporting and analysis, making it easier to understand the context
of historical transactions.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #27 from Martin Renvoize (ashimema) 
 ---
Created attachment 201579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201579&action=edit
Bug 41358: Add migration script for legacy circulation logs

This patch adds an out-of-band migration script to convert legacy
CIRCULATION ISSUE action logs from the old itemnumber-only format
to the new consistent JSON format.

The script:
- Finds all CIRCULATION ISSUE logs where info is just an itemnumber
- Converts them to JSON format with the standard structure
- Attempts to recover issue_id and branchcode from old_issues/issues
- Runs in dry-run mode by default (--commit flag to actually update)
- Processes in batches to handle large databases safely
- Includes verbose mode for detailed output

Usage:
  perl misc/maintenance/migrate_action_logs_to_json.pl --help
  perl misc/maintenance/migrate_action_logs_to_json.pl --verbose
  perl misc/maintenance/migrate_action_logs_to_json.pl --commit

This is designed as an out-of-band maintenance script rather than
an atomic update because:
1. May be expensive on large databases with many log entries
2. Migration is optional - display code handles both formats
3. Can be run during off-peak hours at admin's discretion

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #26 from Martin Renvoize (ashimema) 
 ---
Created attachment 201578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201578&action=edit
Bug 41358: Always store circulation logs in consistent JSON format

Previously, CIRCULATION ISSUE logs would store just the itemnumber when
there were no confirmations or forced overrides, but would store a full
JSON structure when overrides were present. This inconsistency makes
reporting difficult as queries need to handle both formats.

This patch changes AddIssue to always store logs in JSON format,
matching the pattern already used in AddRenewal. The JSON structure
now consistently includes:
- issue: issue_id
- branchcode: branchcode
- itemnumber: itemnumber
- confirmations: array of confirmation codes (empty array if none)
- forced: array of forced override codes (empty array if none)

Benefits:
- Consistent data format simplifies reporting and analysis
- Matches existing RENEWAL logging pattern
- Display code (tools/viewlog.pl) already handles both formats,
  so backward compatibility is maintained

Test plan:
1. prove t/db_dependent/Circulation.t
2. Perform a normal checkout - verify action log contains JSON
3. Perform a checkout with overrides - verify confirmations/forced
   are populated in the JSON
4. Check Tools > Log viewer - both types should display correctly

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #201568|0   |1
is obsolete||
 Attachment #201569|0   |1
is obsolete||
 Attachment #201570|0   |1
is obsolete||
 Attachment #201571|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #25 from Martin Renvoize (ashimema) 
 ---
Created attachment 201571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201571&action=edit
Bug 41358: Apply consistent JSON logging to holds (Bug 40866)

Bug 40866 introduced JSON logging for HOLDS CREATE but stored null for
'confirmations' and 'forced' when no overrides were present. This patch
mirrors the earlier change to CIRCULATION ISSUE by defaulting them to
empty arrays, keeping the two log streams structurally identical and
simplifying reporting queries.

Changes:

C4/Reserves.pm:
- Default confirmations/forced to [] in the AddReserve log payload.

t/db_dependent/Reserves.t:
- Update the Bug 40866 subtest to assert the empty-array defaults on
  normal holds, and fix a 'my $log_data' redeclaration.

tools/viewlog.pl:
- Extend the CSV export JSON-decode block to also cover HOLDS logs,
  guarding the item lookup on itemnumber being present (HOLDS payloads
  may lack one) and filling the CSV item columns from the decoded
  payload. The legacy bare-itemnumber fallback is restricted to
  CIRCULATION so a legacy HOLDS hold_id is not mistaken for an
  itemnumber.

koha-tmpl/intranet-tmpl/prog/js/viewlog.js:
- Extend the info column override rendering (renderCircInfo) to HOLDS
  entries so forced/confirmations arrays display translated, exactly as
  they do for CIRCULATION. The log viewer moved to an ajax datatable in
  bug 29016, so this replaces the earlier json_found change to
  viewlog.pl/viewlog.tt.

misc/maintenance/migrate_action_logs_to_json.pl:
- Renamed from migrate_circulation_logs_to_json.pl.
- Extended to handle legacy pre-Bug 40866 HOLDS CREATE logs where info
  is a bare hold_id, recovering branchcode / biblionumber / itemnumber
  from old_reserves / reserves.
- Uses the same keyset-pagination pattern as the circulation loop so
  rows are not skipped under --commit.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #24 from Martin Renvoize (ashimema) 
 ---
Created attachment 201570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201570&action=edit
Bug 41358: Log forced overrides for offline and ILL checkouts

This patch updates offline circulation and ILL checkouts to properly
record their nature in circulation logs as forced transactions.

Offline circulation (process_koc.pl):
- Offline transactions have already occurred without access to normal
  circulation checks
- Now marks these as forced with 'OFFLINE_CIRCULATION' override code
- This helps identify historical transactions that bypassed checks

ILL checkouts (Koha/ILL/Request.pm):
- ILL checkouts are system-initiated and may bypass certain restrictions
  by design
- Now marks these as forced with 'ILL_CHECKOUT' override code
- This helps track and report on ILL circulation activity separately

Display updates (action-logs.inc):
- Added translation strings for both new override codes:
  - OFFLINE_CIRCULATION: "Offline circulation checkout"
  - ILL_CHECKOUT: "ILL system checkout"
- These will now display properly in Tools > Log viewer

This ensures these special checkout types are properly identified in
reporting and analysis, making it easier to understand the context
of historical transactions.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #23 from Martin Renvoize (ashimema) 
 ---
Created attachment 201569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201569&action=edit
Bug 41358: Add migration script for legacy circulation logs

This patch adds an out-of-band migration script to convert legacy
CIRCULATION ISSUE action logs from the old itemnumber-only format
to the new consistent JSON format.

The script:
- Finds all CIRCULATION ISSUE logs where info is just an itemnumber
- Converts them to JSON format with the standard structure
- Attempts to recover issue_id and branchcode from old_issues/issues
- Runs in dry-run mode by default (--commit flag to actually update)
- Processes in batches to handle large databases safely
- Includes verbose mode for detailed output

Usage:
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --help
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --verbose
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --commit

This is designed as an out-of-band maintenance script rather than
an atomic update because:
1. May be expensive on large databases with many log entries
2. Migration is optional - display code handles both formats
3. Can be run during off-peak hours at admin's discretion

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #22 from Martin Renvoize (ashimema) 
 ---
Created attachment 201568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201568&action=edit
Bug 41358: Always store circulation logs in consistent JSON format

Previously, CIRCULATION ISSUE logs would store just the itemnumber when
there were no confirmations or forced overrides, but would store a full
JSON structure when overrides were present. This inconsistency makes
reporting difficult as queries need to handle both formats.

This patch changes AddIssue to always store logs in JSON format,
matching the pattern already used in AddRenewal. The JSON structure
now consistently includes:
- issue: issue_id
- branchcode: branchcode
- itemnumber: itemnumber
- confirmations: array of confirmation codes (empty array if none)
- forced: array of forced override codes (empty array if none)

Benefits:
- Consistent data format simplifies reporting and analysis
- Matches existing RENEWAL logging pattern
- Display code (tools/viewlog.pl) already handles both formats,
  so backward compatibility is maintained

Test plan:
1. prove t/db_dependent/Circulation.t
2. Perform a normal checkout - verify action log contains JSON
3. Perform a checkout with overrides - verify confirmations/forced
   are populated in the JSON
4. Check Tools > Log viewer - both types should display correctly

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #198288|0   |1
is obsolete||
 Attachment #198289|0   |1
is obsolete||
 Attachment #198290|0   |1
is obsolete||
 Attachment #198291|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-07-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Depends on||29016


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29016
[Bug 29016] Improve performance of the Log viewer when working with a high
volume of action logs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-06-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

David Nind  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #21 from David Nind  ---
The patches no longer apply for me...

git bz apply 41358

📋 Bug 41358 - action logs info column should always store JSON

  • 198288 - Bug 41358: Always store circulation logs in consistent JSON format
  • 198289 - Bug 41358: Add migration script for legacy circulation logs
  • 198290 - Bug 41358: Log forced overrides for offline and ILL checkouts
  • 198291 - Bug 41358: Apply consistent JSON logging to holds (Bug 40866)

Apply? [(y)es, (n)o, (i)nteractive] y

Preparing 4 patch(es):
  ✓ Prepared 4 patch(es)

Applying 4 patch(es):
✓ [1/4] Applied Bug 41358: Always store circulation logs in consistent
JSON…
✓ [2/4] Applied Bug 41358: Add migration script for legacy circulation logs
✓ [3/4] Applied Bug 41358: Log forced overrides for offline and ILL
checkou…

Patch application failed for attachment 198291 - Bug 41358: Apply consistent
JSON logging to holds (Bug 40866)
...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-06-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #20 from Martin Renvoize (ashimema) 
 ---
I still can't replicate that failure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-05-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #19 from Martin Renvoize (ashimema) 
 ---
Hmm, I can't seem to replicate that failure :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Lisette Scheer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #18 from Lisette Scheer  ---
Tests are still failing, but otherwise worked well.


Running tests (2)
* Proving /kohadevbox/koha/t/db_dependent/Circulation.t FAIL
# Transfer limit: Holding -> Return
 # Transfer limit: Return -> Home
 # Transfer limit: Return -> Holding
 # No tests run!

#   Failed test 'No tests run for subtest "Test CanBookBeIssued param
ignore_reserves (Bug 35322)"'
#   at /kohadevbox/koha/t/db_dependent/Circulation.t line 7887.
encountered object '2026-04-30T19:45:32', but neither allow_blessed,
convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method
missing) at /usr/share/perl5/JSON.pm line 173.
 # Looks like your test exited with 11 just after 81.
 /kohadevbox/koha/t/db_dependent/Circulation.t .. 
Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 7/87 subtests  

Test Summary Report
---
 /kohadevbox/koha/t/db_dependent/Circulation.t (Wstat: 2816 (exited 11) Tests:
81 Failed: 1)
  Failed test:   80
  Non-zero exit status: 11
   Parse errors: Bad plan.  You planned 87 tests but ran 81.
Files=1, Tests=81, 52 wallclock secs ( 0.09 usr  0.01 sys + 39.25 cusr  4.55
csys = 43.90 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Keywords||rel_26_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #17 from Martin Renvoize (ashimema) 
 ---
Created attachment 198291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198291&action=edit
Bug 41358: Apply consistent JSON logging to holds (Bug 40866)

Bug 40866 introduced JSON logging for HOLDS CREATE but stored null for
'confirmations' and 'forced' when no overrides were present. This patch
mirrors the earlier change to CIRCULATION ISSUE by defaulting them to
empty arrays, keeping the two log streams structurally identical and
simplifying reporting queries.

Changes:

C4/Reserves.pm:
- Default confirmations/forced to [] in the AddReserve log payload.

t/db_dependent/Reserves.t:
- Update the Bug 40866 subtest to assert the empty-array defaults on
  normal holds, and fix a 'my $log_data' redeclaration.

tools/viewlog.pl:
- Extend the JSON-decode block to also cover HOLDS logs so the
  viewlog.tt HOLDS branch (ELSIF loopro.json_found) actually fires.
  Previously json_found was set only for CIRCULATION, so HOLDS rendered
  the raw pretty-printed JSON blob.

misc/maintenance/migrate_action_logs_to_json.pl:
- Renamed from migrate_circulation_logs_to_json.pl.
- Extended to handle legacy pre-Bug 40866 HOLDS CREATE logs where info
  is a bare hold_id, recovering branchcode / biblionumber / itemnumber
  from old_reserves / reserves.
- Uses the same keyset-pagination pattern as the circulation loop so
  rows are not skipped under --commit.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #16 from Martin Renvoize (ashimema) 
 ---
Created attachment 198290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198290&action=edit
Bug 41358: Log forced overrides for offline and ILL checkouts

This patch updates offline circulation and ILL checkouts to properly
record their nature in circulation logs as forced transactions.

Offline circulation (process_koc.pl):
- Offline transactions have already occurred without access to normal
  circulation checks
- Now marks these as forced with 'OFFLINE_CIRCULATION' override code
- This helps identify historical transactions that bypassed checks

ILL checkouts (Koha/ILL/Request.pm):
- ILL checkouts are system-initiated and may bypass certain restrictions
  by design
- Now marks these as forced with 'ILL_CHECKOUT' override code
- This helps track and report on ILL circulation activity separately

Display updates (action-logs.inc):
- Added translation strings for both new override codes:
  - OFFLINE_CIRCULATION: "Offline circulation checkout"
  - ILL_CHECKOUT: "ILL system checkout"
- These will now display properly in Tools > Log viewer

This ensures these special checkout types are properly identified in
reporting and analysis, making it easier to understand the context
of historical transactions.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #15 from Martin Renvoize (ashimema) 
 ---
Created attachment 198289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198289&action=edit
Bug 41358: Add migration script for legacy circulation logs

This patch adds an out-of-band migration script to convert legacy
CIRCULATION ISSUE action logs from the old itemnumber-only format
to the new consistent JSON format.

The script:
- Finds all CIRCULATION ISSUE logs where info is just an itemnumber
- Converts them to JSON format with the standard structure
- Attempts to recover issue_id and branchcode from old_issues/issues
- Runs in dry-run mode by default (--commit flag to actually update)
- Processes in batches to handle large databases safely
- Includes verbose mode for detailed output

Usage:
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --help
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --verbose
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --commit

This is designed as an out-of-band maintenance script rather than
an atomic update because:
1. May be expensive on large databases with many log entries
2. Migration is optional - display code handles both formats
3. Can be run during off-peak hours at admin's discretion

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #14 from Martin Renvoize (ashimema) 
 ---
Created attachment 198288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198288&action=edit
Bug 41358: Always store circulation logs in consistent JSON format

Previously, CIRCULATION ISSUE logs would store just the itemnumber when
there were no confirmations or forced overrides, but would store a full
JSON structure when overrides were present. This inconsistency makes
reporting difficult as queries need to handle both formats.

This patch changes AddIssue to always store logs in JSON format,
matching the pattern already used in AddRenewal. The JSON structure
now consistently includes:
- issue: issue_id
- branchcode: branchcode
- itemnumber: itemnumber
- confirmations: array of confirmation codes (empty array if none)
- forced: array of forced override codes (empty array if none)

Benefits:
- Consistent data format simplifies reporting and analysis
- Matches existing RENEWAL logging pattern
- Display code (tools/viewlog.pl) already handles both formats,
  so backward compatibility is maintained

Test plan:
1. prove t/db_dependent/Circulation.t
2. Perform a normal checkout - verify action log contains JSON
3. Perform a checkout with overrides - verify confirmations/forced
   are populated in the JSON
4. Check Tools > Log viewer - both types should display correctly

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #195093|0   |1
is obsolete||
 Attachment #195094|0   |1
is obsolete||
 Attachment #195095|0   |1
is obsolete||
 Attachment #195096|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off
Comma delimited||OpenFifth
   list of Sponsors||
 Sponsorship status|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-04-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Lisette Scheer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #13 from Lisette Scheer  ---
Patch doesn't apply and when I rebased I got errors:
[FAIL] misc/maintenance/migrate_circulation_logs_to_json.pl
   FAIL   git_manipulation
The file has been added and deleted or renamed in the same
patchset
[PASS] offline_circ/process_koc.pl
[PASS] t/db_dependent/Circulation.t
[PASS] t/db_dependent/Reserves.t

Processing additional checks PASS!

Running tests (2)
* Proving /kohadevbox/koha/t/db_dependent/Circulation.t FAIL
# Transfer limit: Holding -> Return
 # Transfer limit: Return -> Home
 # Transfer limit: Return -> Holding
 # No tests run!

#   Failed test 'No tests run for subtest "Test CanBookBeIssued param
ignore_reserves (Bug 35322)"'
#   at /kohadevbox/koha/t/db_dependent/Circulation.t line 7887.
encountered object '2026-04-21T22:07:44', but neither allow_blessed,
convert_blessed nor allow_tags settings are enabled (or TO_JSON/FREEZE method
missing) at /usr/share/perl5/JSON.pm line 173.
 # Looks like your test exited with 11 just after 81.
 /kohadevbox/koha/t/db_dependent/Circulation.t .. 
Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 7/87 subtests 

Test Summary Report
---
/kohadevbox/koha/t/db_dependent/Circulation.t (Wstat: 2816 (exited 11) Tests:
81 Failed: 1)
  Failed test:  80
   Non-zero exit status: 11
  Parse errors: Bad plan.  You planned 87 tests but ran 81.
Files=1, Tests=81, 69 wallclock secs ( 0.13 usr  0.02 sys + 50.52 cusr  6.18
csys = 56.85 CPU)
Result: FAIL

* Proving /kohadevbox/koha/t/db_dependent/Reserves.t FAIL
# Looks like you planned 9 tests but ran 11.

#   Failed test 'Bug 40866: AddReserve override JSON logging'
#   at /kohadevbox/koha/t/db_dependent/Reserves.t line 2183.
 # Looks like you failed 1 test of 70.
 /kohadevbox/koha/t/db_dependent/Reserves.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/70 subtests 

Test Summary Report
---
/kohadevbox/koha/t/db_dependent/Reserves.t (Wstat: 256 (exited 1) Tests: 70
Failed: 1)
  Failed test:   68
   Non-zero exit status: 1
Files=1, Tests=70, 17 wallclock secs ( 0.05 usr  0.00 sys + 12.30 cusr  1.85
csys = 14.20 CPU)
 Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-03-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 QA Contact|[email protected] |[email protected]
   |y.org   |m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-03-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Steve, OSLRI, USA  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-03-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

David Nind  changed:

   What|Removed |Added

 Attachment #190627|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 195096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195096&action=edit
Bug 41358: Apply consistent JSON logging to holds (Bug 40866)

This patch extends the bug fix to also cover HOLDS CREATE logs, which
had the same inconsistent logging pattern introduced in Bug 40866.

Similar to CIRCULATION ISSUE logs, HOLDS CREATE logs would store just
the hold ID when there were no confirmations or forced overrides, but
would store a full JSON structure when overrides were present. This
makes reporting difficult as queries need to handle both formats.

Changes:

C4/Reserves.pm:
- Updated AddReserve to always store logs in JSON format
- Removed conditional logic - now always creates consistent JSON with
  confirmations and forced defaulting to empty arrays

t/db_dependent/Reserves.t:
- Updated "Bug 40866: AddReserve override JSON logging" test
- Changed test plan from 8 to 11 tests
- Now expects JSON format even for normal holds without overrides
- Fixed variable redeclaration warning

misc/maintenance/migrate_action_logs_to_json.pl:
- Renamed from migrate_circulation_logs_to_json.pl
- Extended to handle both CIRCULATION ISSUE and HOLDS CREATE logs
- Processes both log types in batches
- Shows separate and combined statistics
- Added Koha::Holds and Koha::Old::Holds imports
- For HOLDS logs, attempts to recover branchcode, biblionumber,
  and itemnumber from old_reserves/reserves tables

This ensures both circulation and holds logs use consistent JSON
format for easier reporting and analysis.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-03-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

David Nind  changed:

   What|Removed |Added

 Attachment #190626|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 195095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195095&action=edit
Bug 41358: Log forced overrides for offline and ILL checkouts

This patch updates offline circulation and ILL checkouts to properly
record their nature in circulation logs as forced transactions.

Offline circulation (process_koc.pl):
- Offline transactions have already occurred without access to normal
  circulation checks
- Now marks these as forced with 'OFFLINE_CIRCULATION' override code
- This helps identify historical transactions that bypassed checks

ILL checkouts (Koha/ILL/Request.pm):
- ILL checkouts are system-initiated and may bypass certain restrictions
  by design
- Now marks these as forced with 'ILL_CHECKOUT' override code
- This helps track and report on ILL circulation activity separately

Display updates (action-logs.inc):
- Added translation strings for both new override codes:
  - OFFLINE_CIRCULATION: "Offline circulation checkout"
  - ILL_CHECKOUT: "ILL system checkout"
- These will now display properly in Tools > Log viewer

This ensures these special checkout types are properly identified in
reporting and analysis, making it easier to understand the context
of historical transactions.

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-03-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

David Nind  changed:

   What|Removed |Added

 Attachment #190625|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 195094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195094&action=edit
Bug 41358: Add migration script for legacy circulation logs

This patch adds an out-of-band migration script to convert legacy
CIRCULATION ISSUE action logs from the old itemnumber-only format
to the new consistent JSON format.

The script:
- Finds all CIRCULATION ISSUE logs where info is just an itemnumber
- Converts them to JSON format with the standard structure
- Attempts to recover issue_id and branchcode from old_issues/issues
- Runs in dry-run mode by default (--commit flag to actually update)
- Processes in batches to handle large databases safely
- Includes verbose mode for detailed output

Usage:
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --help
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --verbose
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --commit

This is designed as an out-of-band maintenance script rather than
an atomic update because:
1. May be expensive on large databases with many log entries
2. Migration is optional - display code handles both formats
3. Can be run during off-peak hours at admin's discretion

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-03-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

David Nind  changed:

   What|Removed |Added

 Attachment #190624|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 195093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195093&action=edit
Bug 41358: Always store circulation logs in consistent JSON format

Previously, CIRCULATION ISSUE logs would store just the itemnumber when
there were no confirmations or forced overrides, but would store a full
JSON structure when overrides were present. This inconsistency makes
reporting difficult as queries need to handle both formats.

This patch changes AddIssue to always store logs in JSON format,
matching the pattern already used in AddRenewal. The JSON structure
now consistently includes:
- issue: issue_id
- branchcode: branchcode
- itemnumber: itemnumber
- confirmations: array of confirmation codes (empty array if none)
- forced: array of forced override codes (empty array if none)

Benefits:
- Consistent data format simplifies reporting and analysis
- Matches existing RENEWAL logging pattern
- Display code (tools/viewlog.pl) already handles both formats,
  so backward compatibility is maintained

Test plan:
1. prove t/db_dependent/Circulation.t
2. Perform a normal checkout - verify action log contains JSON
3. Perform a checkout with overrides - verify confirmations/forced
   are populated in the JSON
4. Check Tools > Log viewer - both types should display correctly

Sponsored-by: OpenFifth 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-03-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-03-09 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #8 from Martin Renvoize (ashimema) 
 ---
That all looks correct to me David, but you're right, Lucas could do with
reviewing this really as he requested the change... perhaps he could do the QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2026-01-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Christine Lee  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

David Nind  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #7 from David Nind  ---
I'm probably not the right person to test this one. If the results I got are
what is expected, I'm happy to sign off.

Testing notes (using KTD):

1. System prferences:
   - Enable HoldsLog
   - Enable RenewalLog
   - Enable AllowNotForLoanOverride
   - The IssueLog is already enabled

2. Items to use (all located in Centerville):
   - 31
   - 305776
   - 305134
   - 300498
   - 311418

3. Actions (before and after the patch) to see what is logged:
   - Check out an item to Mary Burton
   - Check out an item to Mary Burton, with the due date set before the current
date - prompted to confirm
   - Place a hold for Mary Burton
   - Change an item for a record to Not for loan, attempt to issue, confirm
override and check out
   - Renew an item

4. Before and after database and log viewer entries - SQL: select * from
action_logs;

Before
==

Database:

|17 | 2025-12-26 09:07:50 |   51 | CIRCULATION  | ISSUE  | 49 |
{
   "branchcode" : "CPL",
   "confirmations" : [],
   "forced" : [],
   "issue" : 1,
   "itemnumber" : 563
} | intranet  | NULL   | NULL  | NULL |

|18 | 2025-12-26 09:08:08 |   51 | CIRCULATION  | ISSUE  | 49 |
{
   "branchcode" : "CPL",
   "confirmations" : [
  "INVALID_DATE"
   ],
   "forced" : [],
   "issue" : 2,
   "itemnumber" : 296
}  | intranet  | NULL   | NULL  | NULL |

|19 | 2025-12-26 09:08:39 |   51 | HOLDS| CREATE |  1 |
1  | api  | NULL   | NULL  | NULL |

|23 | 2025-12-26 09:28:52 |   51 | CIRCULATION  | ISSUE   | 49
| {
   "branchcode" : "CPL",
   "confirmations" : [
  "NOT_FOR_LOAN_FORCING"
   ],
   "forced" : [],
   "issue" : 3,
   "itemnumber" : 32
} | intranet  | NULL   | NULL  | NULL |

|24 | 2025-12-26 09:29:32 |   51 | CIRCULATION  | RENEWAL | 49
| {
   "confirmations" : [],
   "forced" : [],
   "issue" : 2,
   "itemnumber" : "296"
} | intranet  | NULL   | NULL  | NULL |

How they show in the log viewer:

... Circulation Checkout Mary Burton (49) Item 31 CPL Staff
interface
... Circulation Checkout Mary Burton (49) Item 305776 CPL Invalid date
confirmed Staff interface
... Holds Create 1 1 REST API
... Circulation Checkout Mary Burton (49) Item 300498 CPL Item was not
for loan Staff interface
... Circulation Renew Mary Burton (49) Item 305776 CPL Staff interface

After
=

Database:

|27 | 2025-12-26 09:38:09 |   51 | CIRCULATION  | ISSUE   | 49
| {
   "branchcode" : "CPL",
   "confirmations" : [],
   "forced" : [],
   "issue" : 4,
   "itemnumber" : 578
} | intranet  | NULL   | NULL  | NULL |

|31 | 2025-12-26 09:40:52 |   51 | CIRCULATION  | ISSUE   | 49
| {
   "branchcode" : "CPL",
   "confirmations" : [
  "INVALID_DATE"
   ],
   "forced" : [],
   "issue" : 6,
   "itemnumber" : 264
} | intranet  | NULL   | NULL  | NULL |

|29 | 2025-12-26 09:39:04 |   51 | HOLDS| CREATE  |  2
| {
   "biblionumber" : "19",
   "branchcode" : "FPL",
   "confirmations" : [],
   "forced" : [],
   "hold" : 2,
   "itemnumber" : null
} | intranet  | NULL   | NULL  | NULL |

|28 | 2025-12-26 09:38:31 |   51 | CIRCULATION  | ISSUE   | 49
| {
   "branchcode" : "CPL",
   "confirmations" : [
  "INVALID_DATE",
  "NOT_FOR_LOAN_FORCING"
   ],
   "forced" : [],
   "issue" : 5,
   "itemnumber" : 32
} | intranet  | NULL   | NULL  | NULL  |

|34 | 2025-12-26 09:41:09 |   51 | CIRCULATION  | RENEWAL | 49
| {
   "confirmations" : [],
   "forced" : [],
   "issue" : 4,
   "itemnumber" : "578"
} | intranet  | NULL   | NULL  | NULL |

How they show in the log viewer:

...Circulation Checkout Mary Burton (49) Item 311418 CPL Staff
interface
...Circulation Checkout Mary Burton (49) Item 305134 CPL Invalid date
confirmed Staff interface
...Holds Create 2 { "biblionumber" : "19", "branchcode" : "FPL",
"confirmations" : [], "forced" : [], "hold" : 2, "itemnumber" : null } Staff
interface
...Circulation Checkout Mary Burton (49) Item 300498 CPL Invalid date
confirmed Item was not for loan Staff interface
...Circulation Renew Mary Burton (49) Item 305134 CPL Staff interface

Tests (these pass)
=

prove t/db_dependent/Circulation.t
prove t/db_dependent/Reserves.t

Migration script


perl misc/maintenance/migrate_action_logs_to_json.pl  --help
perl misc/maintenance/migrate_action_logs_to_json.pl  --verbose
perl misc/maintenance/migrate_action_logs_to_json.pl  --commit

perl misc/maintenance/migrate_action_logs_to_json.pl -c
Starting migration of action logs to JSON format...

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #6 from Martin Renvoize (ashimema) 
 ---
I did some analysis of the what we pass into info whilst I was digging here:

We have 13 different forms in this field.. explained below.. I'd love to try
and bring that down a bit :S

  ---
  1. Empty String ("")

  Usage: When no additional info is needed beyond module/action/object
  logaction( "MEMBERS", "CREATE", $borrowernumber, "" )
  logaction( "SERIAL", "ADD", $subscriptionid, "" )
  Modules: MEMBERS (CREATE, DELETE), SERIAL (ADD, MODIFY, RENEW, DELETE)

  ---
  2. Simple String Literal

  Usage: Fixed descriptive text
  logaction( "AUTHORITIES", "ADD", $authid, "authority" )
  logaction( "CATALOGUING", "ADD", $biblionumber, "biblio" )
  logaction( "CATALOGUING", "ADD", $itemnumber, "item" )
  Modules: AUTHORITIES, CATALOGUING

  ---
  3. Simple ID/Number (Now deprecated for CIRCULATION/HOLDS)

  Usage: Just the item/hold ID (your bug fixes this!)
  logaction( "CIRCULATION", "RETURN", $borrowernumber, $item->itemnumber )
  Modules: CIRCULATION (RETURN only - ISSUE now uses JSON)

  ---
  4. Concatenated String with Context

  Usage: Pipe-separated values or descriptive messages
  logaction( 'SYSTEMPREFERENCE', 'MODIFY', undef, $variable . ' | ' . $value )
  logaction( "REPORTS", "DELETE", $id, $report_name . " | " . $savedsql )
  logaction( 'AUTH', 'SUCCESS', $patron_id, "Valid password for $userid", $type
)
  logaction( 'RECALLS', 'CANCEL', $recall_id, "Recall cancelled", 'INTRANET' )
  Modules: SYSTEMPREFERENCE, REPORTS, AUTH, RECALLS
  Format: Usually "field1 | field2" or descriptive message

  ---
  5. BEFORE/AFTER Comparison

  Usage: Stores state before modification for comparison
  logaction( "AUTHORITIES", "MODIFY", $authid,
  "authority BEFORE=>" . $oldrecord->as_formatted )

  logaction( "CATALOGUING", "MODIFY", $biblionumber,
  "biblio $decoding_error BEFORE=>" . $record->as_formatted )
  Modules: AUTHORITIES, CATALOGUING
  Format: "BEFORE=>..."  (full MARC record dump)
  Purpose: Enables visual diff comparison in log viewer

  ---
  6. JSON Structure ✨ (Modern, Consistent)

  Usage: Structured data with overrides, changes, or complex info

  6a. Override/Confirmation Pattern (Your fixes!)

  logaction( "CIRCULATION", "ISSUE", $borrowernumber,
  to_json({
  issue => $issue_id,
  branchcode=> $branchcode,
  itemnumber=> $itemnumber,
  confirmations => ['DEBT', 'AGE_RESTRICTION'],
  forced=> ['OFFLINE_CIRCULATION']
  }, { pretty => 1, canonical => 1 })
  )
  Modules: CIRCULATION (ISSUE, RENEWAL), HOLDS (CREATE)

  6b. Change Tracking Pattern

  logaction( "MEMBERS", "MODIFY", $borrowernumber,
  to_json($info, { utf8 => 1, pretty => 1, canonical => 1 })
  )
  Where $info contains:
  {
"firstname": { "before": "John", "after": "Jane" },
"surname": { "before": "Doe", "after": "Smith" }
  }
  Modules: MEMBERS (MODIFY, MODIFY_CARDNUMBER)

  6c. Attribute Changes

  logaction( "MEMBERS", "MODIFY", $borrowernumber,
  to_json({ "attribute.$code" => $change }, { pretty => 1, canonical => 1
})
  )
  Modules: MEMBERS (extended patron attributes)

  6d. ILL Status Changes

  logaction( 'ILL', 'STATUS_CHANGE', $request_id,
  to_json({
  log_origin=> 'core',
  status_before => $old_status,
  status_after  => $new_status
  })
  )
  Modules: ILL

  6e. Acquisition Baskets

  logaction( 'ACQUISITIONS', 'APPROVE_BASKET', $basketno,
  to_json( $basket->unblessed )
  )
  Modules: ACQUISITIONS

  ---
  7. Object Reference (Koha::Object)

  Usage: Pass entire object for before/after comparison
  logaction( 'HOLDS', 'MODIFY', $hold_id, $hold, undef, $original )
  logaction( "CATALOGUING", "MODIFY", $itemnumber, $self, undef, $original )
  Format: 4th parameter is new object, 6th parameter is original
  Modules: HOLDS, CATALOGUING (items), MEMBERS
  Display: Serialized to JSON by C4::Log internally

  ---
  8. Text Content (Full documents)

  Usage: Stores entire content for comparison
  logaction( 'NOTICES', 'MODIFY', $notice_id, $notice_content )
  logaction( 'NEWS', 'MODIFY', $news_id, $news_content )
  Modules: NOTICES, NEWS, REPORTS
  Display: Special comparison UI with diff viewer

  ---
  9. Descriptive Messages

  Usage: Human-readable action descriptions
  logaction( "FINES", "MODIFY", $borrowernumber,
  "Overdue forgiven: item $item" )

  logaction( "MEMBERS", "PATRON_MERGE", $patron_id,
  "$old_name ($old_cardnumber) has been merged into $new_name" )
  Modules: FINES, MEMBERS (PATRON_MERGE, CIRCMESSAGE actions)

  ---
  Summary Statistics

  From ~190 logaction calls analyzed:

  | Format  | Count | Modules  
 |
 
|-|---||
  | JSON (structured)   | ~35%  | CIRCULATION, HOLDS, MEMBERS, ILL,
ACQUISITIONS |
  | Object Reference

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 CC||[email protected]
   ||o.uk
   Assignee|[email protected] |[email protected]
   |ity.org |o.uk

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #5 from Martin Renvoize (ashimema) 
 ---
Created attachment 190627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190627&action=edit
Bug 41358: Apply consistent JSON logging to holds (Bug 40866)

This patch extends the bug fix to also cover HOLDS CREATE logs, which
had the same inconsistent logging pattern introduced in Bug 40866.

Similar to CIRCULATION ISSUE logs, HOLDS CREATE logs would store just
the hold ID when there were no confirmations or forced overrides, but
would store a full JSON structure when overrides were present. This
makes reporting difficult as queries need to handle both formats.

Changes:

C4/Reserves.pm:
- Updated AddReserve to always store logs in JSON format
- Removed conditional logic - now always creates consistent JSON with
  confirmations and forced defaulting to empty arrays

t/db_dependent/Reserves.t:
- Updated "Bug 40866: AddReserve override JSON logging" test
- Changed test plan from 8 to 11 tests
- Now expects JSON format even for normal holds without overrides
- Fixed variable redeclaration warning

misc/maintenance/migrate_action_logs_to_json.pl:
- Renamed from migrate_circulation_logs_to_json.pl
- Extended to handle both CIRCULATION ISSUE and HOLDS CREATE logs
- Processes both log types in batches
- Shows separate and combined statistics
- Added Koha::Holds and Koha::Old::Holds imports
- For HOLDS logs, attempts to recover branchcode, biblionumber,
  and itemnumber from old_reserves/reserves tables

This ensures both circulation and holds logs use consistent JSON
format for easier reporting and analysis.

Sponsored-by: OpenFifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #4 from Martin Renvoize (ashimema) 
 ---
Created attachment 190626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190626&action=edit
Bug 41358: Log forced overrides for offline and ILL checkouts

This patch updates offline circulation and ILL checkouts to properly
record their nature in circulation logs as forced transactions.

Offline circulation (process_koc.pl):
- Offline transactions have already occurred without access to normal
  circulation checks
- Now marks these as forced with 'OFFLINE_CIRCULATION' override code
- This helps identify historical transactions that bypassed checks

ILL checkouts (Koha/ILL/Request.pm):
- ILL checkouts are system-initiated and may bypass certain restrictions
  by design
- Now marks these as forced with 'ILL_CHECKOUT' override code
- This helps track and report on ILL circulation activity separately

Display updates (action-logs.inc):
- Added translation strings for both new override codes:
  - OFFLINE_CIRCULATION: "Offline circulation checkout"
  - ILL_CHECKOUT: "ILL system checkout"
- These will now display properly in Tools > Log viewer

This ensures these special checkout types are properly identified in
reporting and analysis, making it easier to understand the context
of historical transactions.

Sponsored-by: OpenFifth 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #3 from Martin Renvoize (ashimema) 
 ---
Created attachment 190625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190625&action=edit
Bug 41358: Add migration script for legacy circulation logs

This patch adds an out-of-band migration script to convert legacy
CIRCULATION ISSUE action logs from the old itemnumber-only format
to the new consistent JSON format.

The script:
- Finds all CIRCULATION ISSUE logs where info is just an itemnumber
- Converts them to JSON format with the standard structure
- Attempts to recover issue_id and branchcode from old_issues/issues
- Runs in dry-run mode by default (--commit flag to actually update)
- Processes in batches to handle large databases safely
- Includes verbose mode for detailed output

Usage:
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --help
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --verbose
  perl misc/maintenance/migrate_circulation_logs_to_json.pl --commit

This is designed as an out-of-band maintenance script rather than
an atomic update because:
1. May be expensive on large databases with many log entries
2. Migration is optional - display code handles both formats
3. Can be run during off-peak hours at admin's discretion

Sponsored-by: OpenFifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #2 from Martin Renvoize (ashimema) 
 ---
Created attachment 190624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190624&action=edit
Bug 41358: Always store circulation logs in consistent JSON format

Previously, CIRCULATION ISSUE logs would store just the itemnumber when
there were no confirmations or forced overrides, but would store a full
JSON structure when overrides were present. This inconsistency makes
reporting difficult as queries need to handle both formats.

This patch changes AddIssue to always store logs in JSON format,
matching the pattern already used in AddRenewal. The JSON structure
now consistently includes:
- issue: issue_id
- branchcode: branchcode
- itemnumber: itemnumber
- confirmations: array of confirmation codes (empty array if none)
- forced: array of forced override codes (empty array if none)

Benefits:
- Consistent data format simplifies reporting and analysis
- Matches existing RENEWAL logging pattern
- Display code (tools/viewlog.pl) already handles both formats,
  so backward compatibility is maintained

Test plan:
1. prove t/db_dependent/Circulation.t
2. Perform a normal checkout - verify action log contains JSON
3. Perform a checkout with overrides - verify confirmations/forced
   are populated in the JSON
4. Check Tools > Log viewer - both types should display correctly

Sponsored-by: OpenFifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Depends on||9762


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762
[Bug 9762] Log circulation overrides
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 41358] action logs info column should always store JSON

2025-12-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358

--- Comment #1 from Lucas Gass (lukeg)  ---
Almost everywhere I see AddIssue called there is:

confirmations => [ grep { /^[A-Z_]+$/ } keys %{$confirmation}
],
forced=> [ keys %{$impossible} ]


I don't think this will ever be undef. An empty array is not undef. 

The only place I don't see something like this is offline_circ/process_koc.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

56 matches

Mail list logo