[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 David Nind changed: What|Removed |Added Text to go in the||This fixes SIP2 based release notes||payments, so that a ||branchcode (institution id) ||is now recorded for the ||payment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 --- Comment #9 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||26.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Marcel de Rooy changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Marcel de Rooy changed: What|Removed |Added Attachment #190133|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 190280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190280&action=edit Bug 41369: SIP payments have no branchcode For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id (i.e. branchcode) for SIP payments. Test plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 --- Comment #7 from Marcel de Rooy --- Seems that AutomaticItemReturn was the cause; enabling it makes the test pass. Seems logical given the error message.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 --- Comment #6 from Marcel de Rooy --- (In reply to Kyle M Hall (khall) from comment #5) > (In reply to Marcel de Rooy from comment #4) > > * Proving /usr/share/koha/t/db_dependent/SIP/Transaction.t FAIL > > # Looks like you planned 14 tests but ran 9. > > > > # Failed test 'do_checkin' > > # at /usr/share/koha/t/db_dependent/SIP/Transaction.t line 714. > > Can't call method "branchtransfer_id" on an undefined value at > > /usr/share/koha/t/db_dependent/SIP/Transaction.t line 501. > > > > Do we need to mock some circ preferences to get this always working ? > > Possibly, but this would be unrelated to this patch. The failed unit test is > not even in the subtest I modified! Ah. Thats true. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Kyle M Hall (khall) changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #5 from Kyle M Hall (khall) --- (In reply to Marcel de Rooy from comment #4) > * Proving /usr/share/koha/t/db_dependent/SIP/Transaction.t FAIL > # Looks like you planned 14 tests but ran 9. > > # Failed test 'do_checkin' > # at /usr/share/koha/t/db_dependent/SIP/Transaction.t line 714. > Can't call method "branchtransfer_id" on an undefined value at > /usr/share/koha/t/db_dependent/SIP/Transaction.t line 501. > > Do we need to mock some circ preferences to get this always working ? Possibly, but this would be unrelated to this patch. The failed unit test is not even in the subtest I modified! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||[email protected] --- Comment #4 from Marcel de Rooy --- * Proving /usr/share/koha/t/db_dependent/SIP/Transaction.t FAIL # Looks like you planned 14 tests but ran 9. # Failed test 'do_checkin' # at /usr/share/koha/t/db_dependent/SIP/Transaction.t line 714. Can't call method "branchtransfer_id" on an undefined value at /usr/share/koha/t/db_dependent/SIP/Transaction.t line 501. Do we need to mock some circ preferences to get this always working ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Lisette Scheer changed: What|Removed |Added CC||[email protected] ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 David Nind changed: What|Removed |Added CC||[email protected] Attachment #190129|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 --- Comment #3 from David Nind --- Created attachment 190133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190133&action=edit Bug 41369: SIP payments have no branchcode For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id (i.e. branchcode) for SIP payments. Test plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Kyle M Hall (khall) changed: What|Removed |Added Attachment #190127|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall (khall) --- Created attachment 190129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190129&action=edit Bug 41369 - SIP payments have no branchcode For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id ( i.e. branchcode ) for SIP payments. Test plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Kyle M Hall (khall) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 --- Comment #1 from Kyle M Hall (khall) --- Created attachment 190127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190127&action=edit Bug 41369 - SIP payments have no branchcode For SIP based payments, no branchcode is recorded for the corresponding credit. Koha should be recording the institution id ( i.e. branchcode ) for SIP payments. Test plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 41369] SIP payments have no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41369 Kyle M Hall (khall) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
