[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

David Nind  changed:

   What|Removed |Added

 Attachment #194563|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #17 from David Nind  ---
Created attachment 194611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194611&action=edit
Bug 41769: Make ', by' string translatable in suggestions

This fixes a translation issue in the purchase suggestions
table in the staff interface - a ", by" is added between the
title and the author in the suggestion column, the "by" is
not translated when the language for the staff interface
is a language other than English.

Test plan:

1. Add another language to Koha:
   ./misc/translator/translate install fr-CA

2. Enable the new language in StaffInterfaceLanguages:
   2.1. Go to Administration > System preferences
   2.2. Search for StaffInterfaceLanguages
   2.3. Check the new language
   2.4. Click Save all I18N/L10N preferences

3. Create a new purchase suggestion:
   3.1. Go to More > Suggestions
   3.2. Click New purchase suggestion
   3.3. Fill out the title AND the author at least
   3.4. Click Submit your suggestion

4. View the suggestion in the table
   --> It says title, by author

5. Switch language
   --> The ", by" is still in English

6. Apply patch.

7. Run these commands to update the translation:
   7.1 ./misc/translator/translate update fr-CA
   7.2 ./misc/translator/translate install fr-CA

8. Reload page.

9. Notice that ", by" is now translated.
   --> in this instance, you will see ", par"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #16 from Ayoub Glizi-Vicioso  ---
I have cleaned up the patches by obsoleting the previous ones and keeping only
the necessary follow-up.

I am also providing an updated test plan below.

Since there are already two successful sign-offs and I have re-verified the
fix, I am setting this to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Attachment #194562|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Attachment #194368|0   |1
is obsolete||

--- Comment #15 from Ayoub Glizi-Vicioso  ---
Created attachment 194563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194563&action=edit
Bug 41769: (follow-up) Make ', by' string translatable in suggestions

To test:

1. Add another language to Koha

./misc/translator/translate install fr-CA

2. Enable the new language in StaffInterfaceLanguages
   2.1. Go to Administration > System preferences
   2.2. Search for StaffInterfaceLanguages
   2.3. Check the new language
   2.4. Click Save all I18N/L10N preferences

3. Create a new purchase suggestion
   3.1. Go to More > Suggestions
   3.2. Click New purchase suggestion
   3.3. Fill out the title AND the author at least
   3.4. Click Submit your suggestion

4. View the suggestion in the table
   --> It says title, by author

5. Switch language
   --> The ", by" is still in English

6. Apply patch.

7. run those command:
--> ./misc/translator/translate update fr-CA
--> ./misc/translator/translate install fr-CA

8. Reload page.

9. Notice that ", by" is now translated.
--> in this instance, you will see ", par"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #14 from Ayoub Glizi-Vicioso  ---
Created attachment 194562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194562&action=edit
Bug 41769: (follow-up) Make ', by' string translatable in suggestions To test:

1. Add another language to Koha

./misc/translator/translate install fr-CA

2. Enable the new language in StaffInterfaceLanguages
   2.1. Go to Administration > System preferences
   2.2. Search for StaffInterfaceLanguages
   2.3. Check the new language
   2.4. Click Save all I18N/L10N preferences

3. Create a new purchase suggestion
   3.1. Go to More > Suggestions
   3.2. Click New purchase suggestion
   3.3. Fill out the title AND the author at least
   3.4. Click Submit your suggestion

4. View the suggestion in the table
   --> It says title, by author

5. Switch language
   --> The ", by" is still in English

6. Apply patch.

7. run those command:
--> ./misc/translator/translate update fr-CA
--> ./misc/translator/translate install fr-CA

8. Reload page.

9. Notice that ", by" is now translated.
--> in this instance, you will see ", par"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #13 from Caroline Cyr La Rose  ---
Works for me. I can't sign off bc I work with Ayoub, but there are already two
sign offs. Should it go directly to Signed Off to get QA'ed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Attachment #194367|0   |1
is obsolete||

--- Comment #12 from Ayoub Glizi-Vicioso  ---
Created attachment 194368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194368&action=edit
Bug 41769: (follow-up) Make ', by' string translatable in suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Attachment #194366|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #11 from Ayoub Glizi-Vicioso  ---
Created attachment 194367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194367&action=edit
Bug 41769: (follow-up) Make ', by' string translatable in suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-03-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Attachment #192579|0   |1
is obsolete||

--- Comment #10 from Ayoub Glizi-Vicioso  ---
Created attachment 194366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194366&action=edit
Bug 41769: Make ', by' string translatable in suggestions

To test:

1. Add another language to Koha

./misc/translator/translate install fr-CA

2. Enable the new language in StaffInterfaceLanguages
   2.1. Go to Administration > System preferences
   2.2. Search for StaffInterfaceLanguages
   2.3. Check the new language
   2.4. Click Save all I18N/L10N preferences

3. Create a new purchase suggestion
   3.1. Go to More > Suggestions
   3.2. Click New purchase suggestion
   3.3. Fill out the title AND the author at least
   3.4. Click Submit your suggestion

4. View the suggestion in the table
   --> It says title, by author

5. Switch language
   --> The ", by" is still in English

6. Apply patch.

7. run those command:
--> ./misc/translator/translate update fr-CA
--> ./misc/translator/translate install fr-CA

8. Reload page.

9. Notice that ", by" is now translated.
--> in this instance, you will see ", par"

Signed-off-by: David Nind 
Signed-off-by: Ray Delahunty 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 QA Contact|[email protected] |[email protected]
   |y.org   |

--- Comment #9 from Katrin Fischer  ---
I believe this works, but I wonder about the empty parameters:

node += _("%s%s, by %s%s").format("", "", row.author.escapeHtml(), "")

Why the additional %s?
Why not:

node += _(", by %s").format(row.author.escapeHtml())

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #8 from Ray Delahunty  ---
Whether my signoff is valid or not is for others to decide, as I only used a
sandbox, not this KTD. (Reading and learning about the KTD is on this weekend's
'to do list'). Rather than run the update of the already installed language
pack, I ran patch in the sandbox and then installed the language, and 'by' was
'von' for the DE language option.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

OpenFifth Sandboxes  changed:

   What|Removed |Added

 Attachment #192546|0   |1
is obsolete||

--- Comment #7 from OpenFifth Sandboxes  ---
Created attachment 192579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192579&action=edit
Bug 41769: Make ', by' string translatable in suggestions

To test:

1. Add another language to Koha

./misc/translator/translate install fr-CA

2. Enable the new language in StaffInterfaceLanguages
   2.1. Go to Administration > System preferences
   2.2. Search for StaffInterfaceLanguages
   2.3. Check the new language
   2.4. Click Save all I18N/L10N preferences

3. Create a new purchase suggestion
   3.1. Go to More > Suggestions
   3.2. Click New purchase suggestion
   3.3. Fill out the title AND the author at least
   3.4. Click Submit your suggestion

4. View the suggestion in the table
   --> It says title, by author

5. Switch language
   --> The ", by" is still in English

6. Apply patch.

7. run those command:
--> ./misc/translator/translate update fr-CA
--> ./misc/translator/translate install fr-CA

8. Reload page.

9. Notice that ", by" is now translated.
--> in this instance, you will see ", par"

Signed-off-by: David Nind 
Signed-off-by: Ray Delahunty 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #6 from David Nind  ---
(In reply to Ayoub Glizi-Vicioso from comment #4)
> (In reply to David Nind from comment #3)
> > Testing notes (using KTD):
> > 
> > 1. After applying the patch you need to update the translation (this worked
> > for me, not sure if both steps required):
> >. ./misc/translator/translate update fr-CA
> >. ./misc/translator/translate install fr-CA
> 
> Yes indeed, i forgot to specify.

No problem! 8-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Attachment #192545|0   |1
is obsolete||

--- Comment #5 from Ayoub Glizi-Vicioso  ---
Created attachment 192546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192546&action=edit
Bug 41769: Make ', by' string translatable in suggestions

To test:

1. Add another language to Koha

./misc/translator/translate install fr-CA

2. Enable the new language in StaffInterfaceLanguages
   2.1. Go to Administration > System preferences
   2.2. Search for StaffInterfaceLanguages
   2.3. Check the new language
   2.4. Click Save all I18N/L10N preferences

3. Create a new purchase suggestion
   3.1. Go to More > Suggestions
   3.2. Click New purchase suggestion
   3.3. Fill out the title AND the author at least
   3.4. Click Submit your suggestion

4. View the suggestion in the table
   --> It says title, by author

5. Switch language
   --> The ", by" is still in English

6. Apply patch.

7. run those command:
--> ./misc/translator/translate update fr-CA
--> ./misc/translator/translate install fr-CA

8. Reload page.

9. Notice that ", by" is now translated.
--> in this instance, you will see ", par"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #4 from Ayoub Glizi-Vicioso  ---
(In reply to David Nind from comment #3)
> Testing notes (using KTD):
> 
> 1. After applying the patch you need to update the translation (this worked
> for me, not sure if both steps required):
>. ./misc/translator/translate update fr-CA
>. ./misc/translator/translate install fr-CA

Yes indeed, i forgot to specify.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

David Nind  changed:

   What|Removed |Added

   Assignee|[email protected] |ayoub.glizi-vicioso@inLibro
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

David Nind  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #3 from David Nind  ---
Testing notes (using KTD):

1. After applying the patch you need to update the translation (this worked for
me, not sure if both steps required):
   . ./misc/translator/translate update fr-CA
   . ./misc/translator/translate install fr-CA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #2 from David Nind  ---
Created attachment 192545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192545&action=edit
Bug 41769: Make ', by' string translatable in suggestions

To test:

1. Add another language to Koha

./misc/translator/translate install fr-CA

2. Enable the new language in StaffInterfaceLanguages
   2.1. Go to Administration > System preferences
   2.2. Search for StaffInterfaceLanguages
   2.3. Check the new language
   2.4. Click Save all I18N/L10N preferences

3. Create a new purchase suggestion
   3.1. Go to More > Suggestions
   3.2. Click New purchase suggestion
   3.3. Fill out the title AND the author at least
   3.4. Click Submit your suggestion

4. View the suggestion in the table
   --> It says title, by author

5. Switch language
   --> The ", by" is still in English

6. Apply patch.

7. Reload page.

8. Notice that ", by" is now translated.
--> in this instance, you will see ", par"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

David Nind  changed:

   What|Removed |Added

 Attachment #192541|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

--- Comment #1 from Ayoub Glizi-Vicioso  ---
Created attachment 192541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192541&action=edit
Bug 41769: Make ', by' string translatable in suggestions

To test:

1. Add another language to Koha

./misc/translator/translate install fr-CA

2. Enable the new language in StaffInterfaceLanguages
   2.1. Go to Administration > System preferences
   2.2. Search for StaffInterfaceLanguages
   2.3. Check the new language
   2.4. Click Save all I18N/L10N preferences

3. Create a new purchase suggestion
   3.1. Go to More > Suggestions
   3.2. Click New purchase suggestion
   3.3. Fill out the title AND the author at least
   3.4. Click Submit your suggestion

4. View the suggestion in the table
   --> It says title, by author

5. Switch language
   --> The ", by" is still in English

6. Apply patch.

7. Reload page.

8. Notice that ", by" is now translated.
--> in this instance, you will see ", par"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ayoub Glizi-Vicioso  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Ray Delahunty  changed:

   What|Removed |Added

 CC||[email protected]
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 41769] ", by" in suggestions is untranslatable

2026-02-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||33430


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430
[Bug 33430] Use REST API for suggestions tables
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/