[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #30 from Martin Renvoize (ashimema) 
 ---
Created attachment 194272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194272&action=edit
Bug 4858: Refine OPAC print notice UX for patrons without an email address

When a patron has no email address on file:
- Print transport checkboxes are forced checked and disabled (print is the
  system fallback when no email exists); a hidden input ensures the print
  preference is submitted despite the checkbox being disabled.
- Email transport checkboxes are disabled (there is no address to send to).

Merge the two separate alert blocks (warning before the form, info after the
table) into a single alert at the top of the page. Use alert-warning styling
when the patron has no email address (charges will apply, no choice) and
alert-info styling when they do have an email (charges are avoidable by
selecting email delivery).

Also move the has_print_transport calculation before the form so the
unified alert can use it.

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #29 from Martin Renvoize (ashimema) 
 ---
Created attachment 194271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194271&action=edit
Bug 4858: (QA follow-up) Miscellaneous fixes

- Add print_notice_charge to Koha::Patron::Category to_api_mapping.

- Remove over-defensive branchcode and letter_code regex validation in
  gather_print_notices.pl::apply_print_notice_charge; the data is
  internal (from GetPrintMessages DB query) and the regex could
  silently skip charges for libraries with spaces or special characters
  in their branchcode.

- Fix cronlogaction indentation inside apply_print_notice_charge.

- Move test file from t/db_dependent/Koha/Account/PrintNoticeCharges.t
  to t/db_dependent/Koha/Patron/PrintNoticeCharge.t to match the class
  being tested (Koha::Patron, not Koha::Account::PrintNoticeCharges).

- Add missing trailing newline to
t/db_dependent/PrintNoticeCharging_EndToEnd.t.

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #28 from Martin Renvoize (ashimema) 
 ---
Created attachment 194270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194270&action=edit
Bug 4858: (QA follow-up) Fix high-priority issues

- Remove duplicate 'use Scalar::Util' import introduced by this patch;
  the import already existed at line 26 of Koha/Patron.pm.

- Pass notice_code as the note field on the add_debit call in
  add_print_notice_charge_if_needed. Previously the notice_code
  parameter was accepted but silently dropped, meaning all print notice
  charges looked identical in the account with no way to identify which
  letter triggered the charge.

- Add print transport column to the OPAC messaging preferences table
  (opac-messaging.tt). The original patch added a print notice charging
  warning in the OPAC that told patrons to "uncheck print notice options"
  but never actually gave them a column to do so. This adds the print
  column to the OPAC table header and body rows (mirroring the staff
  messaging-preference-form.inc implementation), and adds a pmp_print
  JS click handler for the toggle_digest function, so patrons can
  opt out of print notices themselves.

- Align PRINT_NOTICE debit type default_amount between fresh install and
  upgrade: account_debit_types.yml correctly set this to NULL (charge
  amount is per patron category, not a global default) but the
  atomicupdate was inserting 0.50. Changed atomicupdate to NULL.

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #26 from Martin Renvoize (ashimema) 
 ---
Created attachment 194268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194268&action=edit
Bug 4858: DO NOT PUSH - DBIC

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #27 from Martin Renvoize (ashimema) 
 ---
Created attachment 194269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194269&action=edit
Bug 4858: (QA follow-up) Fix installer issues after rebase

- Fix SQL syntax error in sample_notices_message_transports.sql: the
  print transport row for RETURN_RECALLED_ITEM was terminated with a
  semicolon instead of a comma, prematurely ending the INSERT statement
  and leaving the three MEMBERSHIP_EXPIRY rows as invalid bare tuples.
  This would break fresh installations by failing to insert those rows.

- Fix atomicupdate ALTER TABLE AFTER clause: the column was being added
  AFTER reservefee which does not exist in the categories table (it
  exists on items). This would cause the ALTER TABLE to fail on all
  upgrades. Changed to AFTER overduenoticerequired to match the column
  order in kohastructure.sql.

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #25 from Martin Renvoize (ashimema) 
 ---
Created attachment 194267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194267&action=edit
Bug 4858: Add print_notice_charge to categories api definition

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #24 from Martin Renvoize (ashimema) 
 ---
Created attachment 194266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194266&action=edit
Bug 4858: Add print message transports to installer and atomic update

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #23 from Martin Renvoize (ashimema) 
 ---
Created attachment 194265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194265&action=edit
Bug 4858: Messaging print preference should be checked by default

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #22 from Martin Renvoize (ashimema) 
 ---
Created attachment 194264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194264&action=edit
Bug 4858: Add validation enhancements to print notice charging

- Add input validation in add_print_notice_charge method

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #21 from Martin Renvoize (ashimema) 
 ---
Created attachment 194263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194263&action=edit
Bug 4858: Add OPAC interface updates for print notice charging

- Enhanced opac-messaging.pl to provide print notice charging context
- Added warnings in OPAC messaging preferences for patrons without email
- Implemented helpful information section about avoiding print charges
- Updated OPAC account page with explanatory information about print
charges

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #20 from Martin Renvoize (ashimema) 
 ---
Created attachment 194262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194262&action=edit
Bug 4858: Add tests for print notice charging

- Covers enabled/disabled states, custom amounts, error conditions

Add missing executable privs

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #19 from Martin Renvoize (ashimema) 
 ---
Created attachment 194261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194261&action=edit
Bug 4858: Add category based print notice charging support to patron.pm

This adds the ability to define print charge notice amounts at a patron
category level.

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #18 from Martin Renvoize (ashimema) 
 ---
Created attachment 194260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194260&action=edit
Bug 4858: Add staff messaging preferences interface for print notice charging

- Update messaging-preference-form.inc to include print transport column
- Update memberentry.pl controller with print charging context
- Add print charge warning to memberentrygen.tt template

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #17 from Martin Renvoize (ashimema) 
 ---
Created attachment 194259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194259&action=edit
Bug 4858: Add print notice charge account management interface updates

- Update accounts.inc templates to display PRINT_NOTICE debit type
  * Staff interface:
koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc
  * OPAC interface:
koha-tmpl/opac-tmpl/bootstrap/en/includes/accounts.inc
  * Test templates: t/mock_templates for English and French-Canadian
  * All show 'Print notice charge' description for PRINT_NOTICE debits

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #16 from Martin Renvoize (ashimema) 
 ---
Created attachment 194258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194258&action=edit
Bug 4858: Implement print notice charging backend logic to scripts

- Update misc/cronjobs/gather_print_notices.pl to apply charges
- Add --skip-charges option for testing purposes

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #15 from Martin Renvoize (ashimema) 
 ---
Created attachment 194257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194257&action=edit
Bug 4858: Add patron category column and debit type for print notice charging

- Add print_notice_charge patron category column to set charge amount
- Add PRINT_NOTICE debit type for billing system integration
- Create atomic update for existing installations

This provides the foundation for implementing print notice charging
to recover postage and processing costs.

To test:
prove -vv t/db_dependent/Koha/Account/PrintNoticeCharges.t
prove -vv t/db_dependent/Koha/Patron/Category.t
prove -vv t/db_dependent/PrintNoticeCharging_EndToEnd.t

Navigate to patron categories, and check that you can set a print notice
charge amount
Check that in messaging preferences, you can amend the preferences of
print notices for both patrons and patron categories
Check that in messaging preferences on the opac, you will receive a
warning if print notice charging is enabled (set to anything other than
0 for this patron category) and a recommendation to set up email to
avoid charges.

Sponsored-by: OpenFifth 
Signed-off-by: Jackie Usher 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186502|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186501|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186500|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186499|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186498|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186497|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186496|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186495|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186494|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186493|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186492|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #186491|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Needs Signoff   |Signed Off
 Sponsorship status|--- |Sponsored
Comma delimited||OpenFifth
   list of Sponsors||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #14 from Chris Cormack  ---
Automatic patch test results:

â ï¸ The patch applies with fuzzy option (ignoring whitespace).
This may indicate minor conflicts that need to be resolved.

Details: Patch applies with fuzzy option (ignoring whitespace)

This is an automated message from the patch testing system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #8 from Jacob O'Mara  ---
Created attachment 186497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186497&action=edit
Bug 4858: Add OPAC interface updates for print notice charging

- Enhanced opac-messaging.pl to provide print notice charging context
- Added warnings in OPAC messaging preferences for patrons without email
- Implemented helpful information section about avoiding print charges
- Updated OPAC account page with explanatory information about print
charges

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #7 from Jacob O'Mara  ---
Created attachment 186496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186496&action=edit
Bug 4858: Add tests for print notice charging

- Covers enabled/disabled states, custom amounts, error conditions

Add missing executable privs

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #3 from Jacob O'Mara  ---
Created attachment 186492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186492&action=edit
Bug 4858: Implement print notice charging backend logic to scripts

- Update misc/cronjobs/gather_print_notices.pl to apply charges
- Add --skip-charges option for testing purposes

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #2 from Jacob O'Mara  ---
Created attachment 186491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186491&action=edit
Bug 4858: Add patron category column and debit type for print notice charging

- Add print_notice_charge patron category column to set charge amount
- Add PRINT_NOTICE debit type for billing system integration
- Create atomic update for existing installations

This provides the foundation for implementing print notice charging
to recover postage and processing costs.

To test:
prove -vv t/db_dependent/Koha/Account/PrintNoticeCharges.t
prove -vv t/db_dependent/Koha/Patron/Category.t
prove -vv t/db_dependent/PrintNoticeCharging_EndToEnd.t

Navigate to patron categories, and check that you can set a print notice
charge amount
Check that in messaging preferences, you can amend the preferences of
print notices for both patrons and patron categories
Check that in messaging preferences on the opac, you will receive a
warning if print notice charging is enabled (set to anything other than
0 for this patron category) and a recommendation to set up email to
avoid charges.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #5 from Jacob O'Mara  ---
Created attachment 186494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186494&action=edit
Bug 4858: Add staff messaging preferences interface for print notice charging

- Update messaging-preference-form.inc to include print transport column
- Update memberentry.pl controller with print charging context
- Add print charge warning to memberentrygen.tt template

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #13 from Jacob O'Mara  ---
Created attachment 186502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186502&action=edit
Bug 4858: DO NOT PUSH - DBIC

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #11 from Jacob O'Mara  ---
Created attachment 186500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186500&action=edit
Bug 4858: Add print message transports to installer and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #10 from Jacob O'Mara  ---
Created attachment 186499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186499&action=edit
Bug 4858: Messaging print preference should be checked by default

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #12 from Jacob O'Mara  ---
Created attachment 186501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186501&action=edit
Bug 4858: Add print_notice_charge to categories api definition

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Jacob O'Mara  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #9 from Jacob O'Mara  ---
Created attachment 186498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186498&action=edit
Bug 4858: Add validation enhancements to print notice charging

- Add input validation in add_print_notice_charge method

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #6 from Jacob O'Mara  ---
Created attachment 186495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186495&action=edit
Bug 4858: Add category based print notice charging support to patron.pm

This adds the ability to define print charge notice amounts at a patron
category level.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

--- Comment #4 from Jacob O'Mara  ---
Created attachment 186493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186493&action=edit
Bug 4858: Add print notice charge account management interface updates

- Update accounts.inc templates to display PRINT_NOTICE debit type
  * Staff interface:
koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc
  * OPAC interface:
koha-tmpl/opac-tmpl/bootstrap/en/includes/accounts.inc
  * Test templates: t/mock_templates for English and French-Canadian
  * All show 'Print notice charge' description for PRINT_NOTICE debits

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Assignee|martin.renvoize@openfifth.c |jacob.om...@openfifth.co.uk
   |o.uk|

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@openfifth.c
   |ity.org |o.uk
 CC||martin.renvoize@openfifth.c
   ||o.uk

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12769

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4858] Ability to Charge for Print Notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Version|3.4 |master
   Assignee|henridam...@koha-fr.org |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #1 from Katrin Fischer  ---
i had libraries asking for a way to charge postage fees too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/