subject:"\[Koha\-bugs\] \[Bug 9762\] Log circulation overrides"

[Koha-bugs] [Bug 9762] Log circulation overrides

2026-01-16 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2026-01-09 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lisette Scheer  changed:

   What|Removed |Added

 Blocks||41590


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41590
[Bug 41590] Circulation Log shows logged in branch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-12-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

David Nind  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #123 from David Nind  ---
Fantastic video about this change from Nick and Jessie on ByWater Solutions'
Monday Minutes https://zurl.co/PKMDz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-12-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Blocks||41358


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41358
[Bug 41358] action logs info column should always store JSON
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-12-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 Blocks||41339


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41339
[Bug 41339] Typo 'Too many checkout'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-10-31 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||41163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41163
[Bug 41163] Circulation logs record issuing branch in database but show
logged-in branch in log viewer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-10-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #121 from Martin Renvoize (ashimema) 
 ---
I've submitted a comprehensive fix on Bug 40866 - Corrections to override
logging.

Lets move on with that bug as the cleanup for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-10-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #117 from Jonathan Druart  ---
+$message = "Restriction overridden temporarily";
+@message = ("Restriction overridden temporarily");

793 No patron matched [% message | html
%]

Then the message is not translatable?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #119 from Martin Renvoize (ashimema) 
 ---
OK.. So I 'think' what's happened here is that over the period of working on
this and then it being pushed we've somehow managed to merge in both the
original implementation and the alternative one I proposed and then stamped as
good to go

Anyway.. that's why some translations issues and things appear to be in main
and why I hadn't failed it for those.

So.. We have a follow-up bug where Hammut started to unpick.. I'm going to
adopt it and basically use it to do a thorough revert of the original patches
and ensure the alternate approach is used consistently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Fridolin Somers  changed:

   What|Removed |Added

 CC||[email protected]
   ||m
 Status|Pushed to stable|Needs documenting

--- Comment #122 from Fridolin Somers  ---
Enhancement not pushed to 24.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-10-13 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #120 from Lucas Gass (lukeg)  ---
(In reply to Martin Renvoize (ashimema) from comment #119)
> OK.. So I 'think' what's happened here is that over the period of working on
> this and then it being pushed we've somehow managed to merge in both the
> original implementation and the alternative one I proposed and then stamped
> as good to go
> 
> Anyway.. that's why some translations issues and things appear to be in main
> and why I hadn't failed it for those.
> 
> So.. We have a follow-up bug where Hammut started to unpick.. I'm going to
> adopt it and basically use it to do a thorough revert of the original
> patches and ensure the alternate approach is used consistently.

This is really bad because it is backported to 24.05.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lucas Gass (lukeg)  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #118 from Lucas Gass (lukeg)  ---
There is a regression here that is now packaged in v25.05.04-1

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Blocks||40866


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866
[Bug 40866] Weird and untranslatable message appears every time something is
checked out
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #116 from Paul Derscheid  ---
Nice work everyone!

Pushed to 25.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Paul Derscheid  changed:

   What|Removed |Added

 Version(s)|25.11.00|25.11.00,25.05.04
released in||
 Status|Pushed to main  |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #108 from Jonathan Druart  ---
And finally:

xt/use-test-no-warnings.t .. 1/2 
#   Failed test 'All Perl test files should contain Test::NoWarnings'
#   at xt/use-test-no-warnings.t line 52.
#  got: '1'
# expected: '0'
# The following test files should use Test::NoWarnings:
#   t/db_dependent/Circulation/CanBookBeIssued.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Jonathan Druart  changed:

   What|Removed |Added

 CC||[email protected]
   Keywords||additional_work_needed

--- Comment #106 from Jonathan Druart  ---
t/db_dependent/Circulation/NoIssuesChargeGuarantees.t is failing

Git bisect blames this patch set

$ prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t   
t/db_dependent/Circulation/NoIssuesChargeGuarantees.t .. Can't use an undefined
value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 1420.  
t/db_dependent/Circulation/NoIssuesChargeGuarantees.t .. 1/8 # Looks like your
test exited with 11 just after 1.   
t/db_dependent/Circulation/NoIssuesChargeGuarantees.t .. Dubious, test returned
11 (wstat 2816, 0xb00)
Failed 7/8 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #115 from Jonathan Druart  ---
(In reply to Lucas Gass (lukeg) from comment #113)
> Can someone put some eyes on my 3 follow-ups?

Looks good to me. Maybe you could have passrf the generated patron to
mock_userenv instead of creating a new library but it's not a big deal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #110 from Lucas Gass (lukeg)  ---
Created attachment 186150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186150&action=edit
Bug 9762: Adjust number of tests in CanBookBeIssued.t

Without this patch:

t/db_dependent/Circulation/CanBookBeIssued.t failes

With this patch:

t/db_dependent/Circulation/CanBookBeIssued.t passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #109 from Lucas Gass (lukeg)  ---
Created attachment 186149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186149&action=edit
Bug 9762: (follow-up) Add Test::NoWarnings to CanBookBeIssued.t

Without this patch:

prove -v /kohadevbox/koha/xt/use-test-no-warnings.t fails

With this patch:

prove -v /kohadevbox/koha/xt/use-test-no-warnings.t passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lucas Gass (lukeg)  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #114 from Lucas Gass (lukeg)  ---
Follow-ups pushed to main.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #113 from Lucas Gass (lukeg)  ---
Can someone put some eyes on my 3 follow-ups?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Attachment #186162|0   |1
is obsolete||

--- Comment #112 from Lucas Gass (lukeg)  ---
Created attachment 186163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186163&action=edit
Bug 9762: (follow-up) Mock the user branch in NoIssuesChargeGuarantees.t and
dateexpiry.t tests

Without the patch:

t/db_dependent/Circulation/NoIssuesChargeGuarantees.t fails
t/db_dependent/Circulation/dateexpiry.t fails

With the patch:

t/db_dependent/Circulation/NoIssuesChargeGuarantees.t passes
t/db_dependent/Circulation/dateexpiry.t passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #111 from Lucas Gass (lukeg)  ---
Created attachment 186162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186162&action=edit
Bug 9762: (follow-up) Mock the user branch in NoIssuesChargeGuarantees.t and
dateexpiry.t tests

Without the patch:

t/db_dependent/Circulation/NoIssuesChargeGuarantees.t fails
t/db_dependent/Circulation/dateexpiry.t fails

With the patch:

t/db_dependent/Circulation/NoIssuesChargeGuarantees.t passes
t/db_dependent/Circulation/dateexpiry.t passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #107 from Jonathan Druart  ---
Also

$ prove t/db_dependent/Circulation/dateexpiry.t   
t/db_dependent/Circulation/dateexpiry.t .. # No tests run!  
t/db_dependent/Circulation/dateexpiry.t .. 1/3  
#   Failed test 'No tests run for subtest "Tests for CanBookBeIssued related to
dateexpiry"'  
#   at t/db_dependent/Circulation/dateexpiry.t line 41. 
Can't use an undefined value as a HASH reference at
/kohadevbox/koha/C4/Circulation.pm line 1420.

Looks like the same cause.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #105 from Lucas Gass (lukeg)  ---
Nice work everyone!

Pushed to main for 25.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-09-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Version(s)||25.11.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185318|0   |1
is obsolete||

--- Comment #95 from Martin Renvoize (ashimema) 
 ---
Created attachment 185819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185819&action=edit
Bug 9762: (QA follow-up) Add missing issueconfirmed check

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185315|0   |1
is obsolete||

--- Comment #92 from Martin Renvoize (ashimema) 
 ---
Created attachment 185816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185816&action=edit
Bug 9762: Change how to pass the param

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #102 from Martin Renvoize (ashimema) 
 ---
Created attachment 185826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185826&action=edit
Bug 9762: (follow-up) Fix failing Circulation.t test

The test was failing with RegisterRequired exception because payin_amount()
requires a cash register when UseCashRegisters preference is enabled.

Fixed by setting UseCashRegisters to 0 in the lost item return policies test
to allow payments without requiring a cash register.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #101 from Martin Renvoize (ashimema) 
 ---
Created attachment 185825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185825&action=edit
Bug 9762: (follow-up) Fix failing CanBookBeIssued test

The test was failing because:
1. IssuingInProcess preference was not explicitly set, affecting the code path
for message logging
2. The patron category had a random noissuescharge value that overrode the
system preference

Fixed by:
- Setting IssuingInProcess to 0 to ensure correct code path
- Setting patron category noissuescharge to undef to use system preference

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

  Text to go in the||**Summary:**
  release notes||Koha circulation actions
   ||(checkout, renewal, return)
   ||previously lacked detailed
   ||logging when staff overrode
   ||system restrictions, making
   ||it difficult to audit and
   ||track these important
   ||decisions.
   ||
   ||**Fix:**
   ||Added comprehensive
   ||override logging that
   ||captures when staff bypass
   ||circulation restrictions:
   ||  - **JSON Action Logs:**
   ||All circulation overrides
   ||now log structured data
   ||including confirmation
   ||codes (`DEBT`,
   ||`AGE_RESTRICTION`,
   ||`ON_RESERVE`, etc.) and
   ||forced override reasons
   ||  - **Consistent Format:**
   ||Standardized JSON logging
   ||across all circulation
   ||operations (AddIssue,
   ||AddRenewal)
   ||  - **Enhanced Display:**
   ||Action log viewer shows
   ||human-readable descriptions
   ||of overrides (e.g., "Patron
   ||is restricted", "Renewal
   ||limit override")
   ||  - **Comprehensive
   ||Coverage:** Tracks
   ||overrides for patron
   ||restrictions, age limits,
   ||checkout limits, holds
   ||conflicts, fine overrides,
   ||and more
   ||
   ||**Impact:**
   ||Provides complete audit
   ||trail for circulation
   ||policy overrides, improving
   ||accountability and
   ||compliance reporting.
   ||Librarians can now easily
   ||track when and why staff
   ||bypassed system
   ||restrictions during
   ||checkout, renewal, and
   ||return operations.
   ||
   ||  **Technical Details:**
   ||  Override information is
   ||stored as JSON in action
   ||logs with format:
   ||  ```json
   ||  {
   ||"issue": 123,
   ||"itemnumber": 456,
   ||"confirmations":
   ||["DEBT",
   ||"AGE_RESTRICTION"],
   ||"forced": ["TOO_MANY"]
   ||  }
   |

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #104 from Martin Renvoize (ashimema) 
 ---
I think this has gone through enough testing and enough hands now to push it
through QA.

I'm happy with the final results and code and whilst I'd love to add some
signoff lines to this, I have no doubt it's in use in production at inLibro
already, and I'm taking Hammat's continuation of my proposed alternative as
agreement of that approach.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #103 from Martin Renvoize (ashimema) 
 ---
Created attachment 185827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185827&action=edit
Bug 9762: (follow-up) Add integration tests and improve AddRenewal logging
consistency

This commit adds two key improvements to the Bug 9762 circulation override
logging:

1. **Consistent JSON Logging**: Updated AddRenewal to always log in JSON
format,
   matching AddIssue behavior. Previously AddRenewal only logged JSON when
   confirmations/forced were present, otherwise logged just the item number.

2. **Integration Tests**: Added comprehensive tests for both AddIssue and
AddRenewal
   JSON logging functionality:
   - Test normal operations (empty confirmations/forced arrays)
   - Test override operations (populated confirmations/forced arrays)
   - Verify JSON structure and content accuracy

The AddRenewal function now consistently logs:
```json
{
  "issue": 123,
  "itemnumber": 456,
  "confirmations": [...],
  "forced": [...]
}
```

This ensures uniform action log format across all circulation operations and
provides better integration test coverage for the override logging
functionality.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185320|0   |1
is obsolete||

--- Comment #97 from Martin Renvoize (ashimema) 
 ---
Created attachment 185821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185821&action=edit
Bug 9762: (QA follow-up) Remove superflous string construction

We never actually pass `$message` back to anywhere so there's no reason
to create it in the first place.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185323|0   |1
is obsolete||

--- Comment #100 from Martin Renvoize (ashimema) 
 ---
Created attachment 185824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185824&action=edit
Bug 9762: (follow-up) Add branchcode to Log circulation and add some override
confirmations in action logs, fix typos

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185322|0   |1
is obsolete||

--- Comment #99 from Martin Renvoize (ashimema) 
 ---
Created attachment 185823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185823&action=edit
Bug 9762: (Alternative) Handle renewals

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185321|0   |1
is obsolete||

--- Comment #98 from Martin Renvoize (ashimema) 
 ---
Created attachment 185822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185822&action=edit
Bug 9762: (Alternative) Log circulation overrides

An alternative approach to the original submission for bug 9762. Instead
of recording a distinct action log line for a set of override messages
in addition to the standard issue record, this patch updates the
existing issue log to include any confirmation or impossible responses
from the preceeding CanBookBeIssued call.

We continue to record these as a JSON structure as the prior patch did,
but instead of human messages we use the predefined codes as returned
from the existing CanBookBeIssued response.

To test:

After each step, a single action log message should be displayed under
`Tools > Log viewer`. The message itself will now consist of a JSON
string with an array of 'confirmations' and 'forced' strings
representing the overriden feedback from CanBookBeIssued.

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
   syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
   (AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
   and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
   (AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else
(AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item
type on hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of
holds
17) Place an item-level hold when rules dictate that this is not
allowed

Sponsored-by: OpenFifth 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185319|0   |1
is obsolete||

--- Comment #96 from Martin Renvoize (ashimema) 
 ---
Created attachment 185820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185820&action=edit
Bug 9762: (QA follow-up) Fix failing test

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185317|0   |1
is obsolete||

--- Comment #94 from Martin Renvoize (ashimema) 
 ---
Created attachment 185818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185818&action=edit
Bug 9762: (QA follow-up) Fix executable bit

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185316|0   |1
is obsolete||

--- Comment #93 from Martin Renvoize (ashimema) 
 ---
Created attachment 185817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185817&action=edit
Bug 9762: Test CanBookBeIssued.pm

To test:

1) Apply the patch
2) run prove t/db_dependent/Circulation/CanBookBeIssued.t

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #185314|0   |1
is obsolete||

--- Comment #91 from Martin Renvoize (ashimema) 
 ---
Created attachment 185815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185815&action=edit
Bug 9762: Log circulation overrides

This patch allows you to save commands that have been overridden by someone.

The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17
are still not functional. Tests 15 and 16 need to be fixed as they do not
display the barcode. All other tests should be functional.

To test:

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

Sponsored-by: Solutions inLibro inc. 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #185118|0   |1
is obsolete||

--- Comment #90 from Hammat wele  ---
Created attachment 185323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185323&action=edit
Bug 9762: (follow-up) Add branchcode to Log circulation and add some override
confirmations in action logs, fix typos

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181546|0   |1
is obsolete||

--- Comment #89 from Hammat wele  ---
Created attachment 185322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185322&action=edit
Bug 9762: (Alternative) Handle renewals

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181545|0   |1
is obsolete||

--- Comment #88 from Hammat wele  ---
Created attachment 185321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185321&action=edit
Bug 9762: (Alternative) Log circulation overrides

An alternative approach to the original submission for bug 9762. Instead
of recording a distinct action log line for a set of override messages
in addition to the standard issue record, this patch updates the
existing issue log to include any confirmation or impossible responses
from the preceeding CanBookBeIssued call.

We continue to record these as a JSON structure as the prior patch did,
but instead of human messages we use the predefined codes as returned
from the existing CanBookBeIssued response.

To test:

After each step, a single action log message should be displayed under
`Tools > Log viewer`. The message itself will now consist of a JSON
string with an array of 'confirmations' and 'forced' strings
representing the overriden feedback from CanBookBeIssued.

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
   syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
   (AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
   and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
   (AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else
(AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item
type on hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of
holds
17) Place an item-level hold when rules dictate that this is not
allowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181363|0   |1
is obsolete||

--- Comment #87 from Hammat wele  ---
Created attachment 185320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185320&action=edit
Bug 9762: (QA follow-up) Remove superflous string construction

We never actually pass `$message` back to anywhere so there's no reason
to create it in the first place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181362|0   |1
is obsolete||

--- Comment #86 from Hammat wele  ---
Created attachment 185319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185319&action=edit
Bug 9762: (QA follow-up) Fix failing test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181361|0   |1
is obsolete||

--- Comment #85 from Hammat wele  ---
Created attachment 185318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185318&action=edit
Bug 9762: (QA follow-up) Add missing issueconfirmed check

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181360|0   |1
is obsolete||

--- Comment #84 from Hammat wele  ---
Created attachment 185317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185317&action=edit
Bug 9762: (QA follow-up) Fix executable bit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181359|0   |1
is obsolete||

--- Comment #83 from Hammat wele  ---
Created attachment 185316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185316&action=edit
Bug 9762: Test CanBookBeIssued.pm

To test:

1) Apply the patch
2) run prove t/db_dependent/Circulation/CanBookBeIssued.t

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

Bug 9762: change permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181358|0   |1
is obsolete||

--- Comment #82 from Hammat wele  ---
Created attachment 185315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185315&action=edit
Bug 9762: Change how to pass the param

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Hammat wele  changed:

   What|Removed |Added

 Attachment #181357|0   |1
is obsolete||

--- Comment #81 from Hammat wele  ---
Created attachment 185314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185314&action=edit
Bug 9762: Log circulation overrides

This patch allows you to save commands that have been overridden by someone.

The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17
are still not functional. Tests 15 and 16 need to be fixed as they do not
display the barcode. All other tests should be functional.

To test:

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #80 from Hammat wele  ---
Created attachment 185118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185118&action=edit
Bug 9762: (follow-up) Add branchcode to Log circulation and add some override
confirmations in action logs, fix typos

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC|[email protected] |
   |,   |
   |[email protected],  |
   |[email protected]  |
   Assignee|[email protected]  |[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181393|0   |1
is obsolete||

--- Comment #78 from Martin Renvoize (ashimema) 
 ---
Created attachment 181545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181545&action=edit
Bug 9762: (Alternative) Log circulation overrides

An alternative approach to the original submission for bug 9762. Instead
of recording a distinct action log line for a set of override messages
in addition to the standard issue record, this patch updates the
existing issue log to include any confirmation or impossible responses
from the preceeding CanBookBeIssued call.

We continue to record these as a JSON structure as the prior patch did,
but instead of human messages we use the predefined codes as returned
from the existing CanBookBeIssued response.

To test:

After each step, a single action log message should be displayed under
`Tools > Log viewer`. The message itself will now consist of a JSON
string with an array of 'confirmations' and 'forced' strings
representing the overriden feedback from CanBookBeIssued.

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
   syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
   (AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
   and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
   (AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else
(AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item
type on hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of
holds
17) Place an item-level hold when rules dictate that this is not
allowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #79 from Martin Renvoize (ashimema) 
 ---
Created attachment 181546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181546&action=edit
Bug 9762: (Alternative) Handle renewals

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #62 from Martin Renvoize (ashimema) 
 ---
Comment on attachment 181340
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181340
Bug 9762: Log circulation overrides

Review of attachment 181340:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9762&attachment=181340)
-

::: C4/Circulation.pm
@@ +832,4 @@
>  my $circ_library = Koha::Libraries->find( _GetCircControlBranch( 
> $item_object, $patron ) );
>  
>  my $now = dt_from_string();
> +my $message;

I don't see `$message` passed anywhere.. we seem to construct what could be a
huge concatenated string below, but then never output it anywhere.

We also have this on line 1822:

  `my ( $allowed, $message ) = CanBookBeReturned( $item_unblessed,
C4::Context->userenv->{branch} );`

This will overwrite whatever was in $message above.. and it's intended to just
be a branchcode passed back in that case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #77 from Martin Renvoize (ashimema) 
 ---
Forgot to mention.. this version is translatable ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181390|0   |1
is obsolete||

--- Comment #76 from Martin Renvoize (ashimema) 
 ---
Created attachment 181393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181393&action=edit
Bug 9762: (Alternative) Log circulation overrides

An alternative approach to the original submission for bug 9762. Instead
of recording a distinct action log line for a set of override messages
in addition to the standard issue record, this patch updates the
existing issue log to include any confirmation or impossible responses
from the preceeding CanBookBeIssued call.

We continue to record these as a JSON structure as the prior patch did,
but instead of human messages we use the predefined codes as returned
from the existing CanBookBeIssued response.

To test:

After each step, a single action log message should be displayed under
`Tools > Log viewer`. The message itself will now consist of a JSON
string with an array of 'confirmations' and 'forced' strings
representing the overriden feedback from CanBookBeIssued.

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
   syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
   (AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
   and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
   (AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else
(AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item
type on hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of
holds
17) Place an item-level hold when rules dictate that this is not
allowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181381|0   |1
is obsolete||

--- Comment #75 from Martin Renvoize (ashimema) 
 ---
Created attachment 181390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181390&action=edit
Bug 9762: (Alternative) Log circulation overrides

An alternative approach to the original submission for bug 9762. Instead
of recording a distinct action log line for a set of override messages
in addition to the standard issue record, this patch updates the
existing issue log to include any confirmation or impossible responses
from the preceeding CanBookBeIssued call.

We continue to record these as a JSON structure as the prior patch did,
but instead of human messages we use the predefined codes as returned
from the existing CanBookBeIssued response.

To test:

After each step, a single action log message should be displayed under
`Tools > Log viewer`. The message itself will now consist of a JSON
string with an array of 'confirmations' and 'forced' strings
representing the overriden feedback from CanBookBeIssued.

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
   syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
   (AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
   and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
   (AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else
(AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item
type on hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of
holds
17) Place an item-level hold when rules dictate that this is not
allowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181371|0   |1
is obsolete||

--- Comment #74 from Martin Renvoize (ashimema) 
 ---
Created attachment 181381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181381&action=edit
Bug 9762: (Alternative) Log circulation overrides

An alternative approach to the original submission for bug 9762. Instead
of recording a distinct action log line for a set of override messages
in addition to the standard issue record, this patch updates the
existing issue log to include any confirmation or impossible responses
from the preceeding CanBookBeIssued call.

We continue to record these as a JSON structure as the prior patch did,
but instead of human messages we use the predefined codes as returned
from the existing CanBookBeIssued response.

To test:

After each step, a single action log message should be displayed under
`Tools > Log viewer`. The message itself will now consist of a JSON
string with an array of 'confirmations' and 'forced' strings
representing the overriden feedback from CanBookBeIssued.

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
   syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
   (AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
   and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
   (AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else
(AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item
type on hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of
holds
17) Place an item-level hold when rules dictate that this is not
allowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #73 from Martin Renvoize (ashimema) 
 ---
So.. I've added an alternative approach for comment.  It's not fully
implemented yet as it only covers calls to AddIssue and we should also consider
Renewal and Return override as the original patchset does.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #72 from Martin Renvoize (ashimema) 
 ---
Created attachment 181371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181371&action=edit
Bug 9762: (Alternative) Log circulation overrides

An alternative approach to the original submission for bug 9762. Instead
of recording a distinct action log line for a set of override messages
in addition to the standard issue record, this patch updates the
existing issue log to include any confirmation or impossible responses
from the preceeding CanBookBeIssued call.

We continue to record these as a JSON structure as the prior patch did,
but instead of human messages we use the predefined codes as returned
from the existing CanBookBeIssued response.

To test:

After each step, a single action log message should be displayed under
`Tools > Log viewer`. The message itself will now consist of a JSON
string with an array of 'confirmations' and 'forced' strings
representing the overriden feedback from CanBookBeIssued.

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
   syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
   (AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
   and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
   (AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else
(AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item
type on hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of
holds
17) Place an item-level hold when rules dictate that this is not
allowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181305|0   |1
is obsolete||

--- Comment #57 from Martin Renvoize (ashimema) 
 ---
Created attachment 181342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181342&action=edit
Bug 9762: Test CanBookBeIssued.pm

To test:

1) Apply the patch
2) run prove t/db_dependent/Circulation/CanBookBeIssued.t

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

Bug 9762: change permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181346|0   |1
is obsolete||

--- Comment #67 from Martin Renvoize (ashimema) 
 ---
Created attachment 181361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181361&action=edit
Bug 9762: (QA follow-up) Add missing issueconfirmed check

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #70 from Martin Renvoize (ashimema) 
 ---
Squashed rebase follow-ups and made some more rebase corrections.

One test is still failing, and the string type record is still an issue.. I
still need to test this all in detail too before I think it's QA runnnable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181345|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181344|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #71 from Martin Renvoize (ashimema) 
 ---
This somehow feels like it's recording twice or is just at the wrong level to
me.. 

I think I'd remove the changes to C4::Circulation::CanBookBeIssued and perform
the record in the controllers.. or perhaps in AddIssue, AddRenewal.. those are
the places we actually store the Issue/Renewal so it seems somewhat odd to
record the override before the actual Issue/Renewal takes place to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181341|0   |1
is obsolete||

--- Comment #64 from Martin Renvoize (ashimema) 
 ---
Created attachment 181358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181358&action=edit
Bug 9762: Change how to pass the param

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181343|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #69 from Martin Renvoize (ashimema) 
 ---
Created attachment 181363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181363&action=edit
Bug 9762: (QA follow-up) Remove superflous string construction

We never actually pass `$message` back to anywhere so there's no reason
to create it in the first place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #68 from Martin Renvoize (ashimema) 
 ---
Created attachment 181362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181362&action=edit
Bug 9762: (QA follow-up) Fix failing test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #66 from Martin Renvoize (ashimema) 
 ---
Created attachment 181360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181360&action=edit
Bug 9762: (QA follow-up) Fix executable bit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181342|0   |1
is obsolete||

--- Comment #65 from Martin Renvoize (ashimema) 
 ---
Created attachment 181359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181359&action=edit
Bug 9762: Test CanBookBeIssued.pm

To test:

1) Apply the patch
2) run prove t/db_dependent/Circulation/CanBookBeIssued.t

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

Bug 9762: change permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181340|0   |1
is obsolete||

--- Comment #63 from Martin Renvoize (ashimema) 
 ---
Created attachment 181357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181357&action=edit
Bug 9762: Log circulation overrides

This patch allows you to save commands that have been overridden by someone.

The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17
are still not functional. Tests 15 and 16 need to be fixed as they do not
display the barcode. All other tests should be functional.

To test:

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181306|0   |1
is obsolete||

--- Comment #58 from Martin Renvoize (ashimema) 
 ---
Created attachment 181343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181343&action=edit
Bug 9762: (follow-up) Re-instate bug 17729

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #61 from Martin Renvoize (ashimema) 
 ---
Created attachment 181346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181346&action=edit
Bug 9762: (QA follow-up) Add missing issueconfirmed check

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181308|0   |1
is obsolete||

--- Comment #60 from Martin Renvoize (ashimema) 
 ---
Created attachment 181345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181345&action=edit
Bug 9762:(QA follow-up) Fix executable bit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181307|0   |1
is obsolete||

--- Comment #59 from Martin Renvoize (ashimema) 
 ---
Created attachment 181344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181344&action=edit
Bug 9762: (follow-up) Re-instate bug 37868

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181304|0   |1
is obsolete||

--- Comment #56 from Martin Renvoize (ashimema) 
 ---
Created attachment 181341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181341&action=edit
Bug 9762: Change how to pass the param

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181303|0   |1
is obsolete||

--- Comment #55 from Martin Renvoize (ashimema) 
 ---
Created attachment 181340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181340&action=edit
Bug 9762: Log circulation overrides

This patch allows you to save commands that have been overridden by someone.

The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17
are still not functional. Tests 15 and 16 need to be fixed as they do not
display the barcode. All other tests should be functional.

To test:

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #54 from Martin Renvoize (ashimema) 
 ---
Rebased, but still failed QA for now with the following tests failing:

Running tests (1)
* Proving /kohadevbox/koha/t/db_dependent/Circulation/CanBookBeIssued.t
KO!

#   Failed test 'Borrower had amend message displayed'
#   at /kohadevbox/koha/t/db_dependent/Circulation/CanBookBeIssued.t line 231.
#  got: undef
# expected: 'borrower had amend'
 # Looks like you failed 1 test of 9.
 /kohadevbox/koha/t/db_dependent/Circulation/CanBookBeIssued.t ..
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/9 subtests

Test Summary Report
---
 /kohadevbox/koha/t/db_dependent/Circulation/CanBookBeIssued.t (Wstat: 256
(exited 1) Tests: 9 Failed: 1)
  Failed test:   4
   Non-zero exit status: 1
Files=1, Tests=9,  2 wallclock secs ( 0.01 usr  0.00 sys +  1.40 cusr  0.16
csys =  1.57 CPU)
 Result: FAIL


Running more tests (1)
* Proving t/db_dependent/Circulation.t KO!
# Looks like you planned 27 tests but ran 5.

#   Failed test 'CanBookBeIssued & AllowReturnToBranch'
#   at t/db_dependent/Circulation.t line 2546.
Can't call method "itemnumber" on an undefined value at
/kohadevbox/koha/C4/Circulation.pm line 1478.
 # Looks like your test exited with 11 just after 27.
 t/db_dependent/Circulation.t ..
Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 50/76 subtests

Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 2816 (exited 11) Tests: 27 Failed: 1)
  Failed test:  26
  Non-zero exit status: 11
  Parse errors: Bad plan.  You planned 76 tests but ran 27.
Files=1, Tests=27,  5 wallclock secs ( 0.01 usr  0.01 sys +  3.57 cusr  0.44
csys =  4.03 CPU)
 Result: FAIL

I've not got a moment right now to work through those test failures I'm afraid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #53 from Martin Renvoize (ashimema) 
 ---
Created attachment 181308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181308&action=edit
Bug 9762:(QA follow-up) Fix executable bit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #52 from Martin Renvoize (ashimema) 
 ---
Created attachment 181307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181307&action=edit
Bug 9762: (follow-up) Re-instate bug 37868

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #51 from Martin Renvoize (ashimema) 
 ---
Created attachment 181306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181306&action=edit
Bug 9762: (follow-up) Re-instate bug 17729

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #170273|0   |1
is obsolete||

--- Comment #50 from Martin Renvoize (ashimema) 
 ---
Created attachment 181305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181305&action=edit
Bug 9762: Test CanBookBeIssued.pm

To test:

1) Apply the patch
2) run prove t/db_dependent/Circulation/CanBookBeIssued.t

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

Bug 9762: change permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #170272|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize (ashimema) 
 ---
Created attachment 181304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181304&action=edit
Bug 9762: Change how to pass the param

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #170271|0   |1
is obsolete||

--- Comment #48 from Martin Renvoize (ashimema) 
 ---
Created attachment 181303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181303&action=edit
Bug 9762: Log circulation overrides

This patch allows you to save commands that have been overridden by someone.

The patch has been updated but is not yet completed. Tests 10, 13, 14, and 17
are still not functional. Tests 15 and 16 need to be fixed as they do not
display the barcode. All other tests should be functional.

To test:

--After each step, a message will be displayed in the action_logs table and in
Tools > Log viewer --

Circulation -- Checking out

1) Check out an item that is age-restricted (AgeRestrictionOverride syspref)
2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride
syspref)
3) Check out an item that has a “lost” status (IssueLostItem syspref)
4) Check out an item to a patron who has reached the checkout limit
(AllowTooManyOverride syspref)
5) Check out an item to a patron who is not allowed to borrow this item type
6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride
and/or AllowFineOverride + noissuescharge sysprefs)
7) Check out an item on hold for someone else
8) Check out an item on hold ready for pickup by someone else
9) Check out an item already checked out to someone else
(AutoReturnCheckedOutItems syspref)
10) Check out to a patron who has restrictions

Circulation -- Checking in

11) Ignore a hold upon check in
12) Ignore a hold and transfer upon check in

Circulation – Renewing

13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref)
14) Renew an item that has reached the maximum number of renewals
(AllowRenewalLimitOverride syspref)

Holds

15) Place a hold for a patron who is not allowed to place this item type on
hold (AllowHoldPolicyOverride syspref)
16) Place a hold for a patron who has reached the maximum number of holds
17) Place an item-level hold when rules dictate that this is not allowed (In
circulation rules put "On shelf holds allowed" to "If any unavailable")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

William Lavoie  changed:

   What|Removed |Added

 Attachment #170273|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-04 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

William Lavoie  changed:

   What|Removed |Added

 Attachment #178036|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #47 from Lucas Gass (lukeg)  ---
(In reply to William Lavoie from comment #46)
> This needed a rebase.

Sorry William, there are quite a few problems now:


1. There are some code issues:

"my" variable $dbh masks earlier declaration in same scope at
/kohadevbox/koha/C4/Circulation.pm line 3669.
"my" variable $patron masks earlier declaration in same scope at
/kohadevbox/koha/C4/Circulation.pm line 3676.


2. I would check your release_tools, many things are not tidy 

3. Unit tests are failing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

William Lavoie  changed:

   What|Removed |Added

 Attachment #178029|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

William Lavoie  changed:

   What|Removed |Added

 Attachment #170271|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

William Lavoie  changed:

   What|Removed |Added

 Attachment #170272|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9762] Log circulation overrides

2025-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

William Lavoie  changed:

   What|Removed |Added

 Attachment #178030|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 161 matches

Mail list logo