Re: Virtualbox svga card in KVM

2013-04-05 Thread Sriram Murthy
For starters, virtual box has better SVGA WDDM drivers that allows for a much richer display when the VM display is local. I am yet to completely understand both the KVM and the virtualbox SVGA card (actually, the virtualbox SVGA card is based off of the KVM VGA card), so I may not be the author

Re: RFC: vfio API changes needed for powerpc (v3)

2013-04-05 Thread Scott Wood
On 04/04/2013 05:10:27 PM, Yoder Stuart-B08248 wrote: /* * VFIO_IOMMU_PAMU_UNMAP_MSI_BANK * * Unmaps the MSI bank at the specified iova. * Caller provides struct vfio_pamu_msi_bank_unmap with all fields set. * Operates on VFIO file descriptor (/dev/vfio/vfio). * Return: 0 on success, -er

[PATCH 3/4] KVM: Move kvm_rebooting declaration out of x86

2013-04-05 Thread Geoff Levand
The variable kvm_rebooting is a common kvm variable, so move its declaration from arch/x86/include/asm/kvm_host.h to include/asm/kvm_host.h. Fixes this sparse warning when building on arm64: virt/kvm/kvm_main.c:warning: symbol 'kvm_rebooting' was not declared. Should it be static? Signed-off-

[PATCH 2/4] KVM: Move kvm_spurious_fault to x86.c

2013-04-05 Thread Geoff Levand
The routine kvm_spurious_fault() is an x86 specific routine, so move it from virt/kvm/kvm_main.c to arch/x86/kvm/x86.c. Fixes this sparse warning when building on arm64: virt/kvm/kvm_main.c:warning: symbol 'kvm_spurious_fault' was not declared. Should it be static? Signed-off-by: Geoff Levand

[PATCH 1/4] KVM: Make local routines static

2013-04-05 Thread Geoff Levand
The routines get_user_page_nowait(), kvm_io_bus_sort_cmp(), kvm_io_bus_insert_dev() and kvm_io_bus_get_first_dev() are only referenced within kvm_main.c, so give them static linkage. Fixes sparse warnings like these: virt/kvm/kvm_main.c: warning: symbol 'get_user_page_nowait' was not declared

[PATCH 4/4] KVM: Move vm_list kvm_lock declarations out of x86

2013-04-05 Thread Geoff Levand
The variables vm_list and kvm_lock are common to all architectures, so move the declarations from arch/x86/include/asm/kvm_host.h to include/linux/kvm_host.h. Fixes sparse warnings like these when building for arm64: virt/kvm/kvm_main.c: warning: symbol 'kvm_lock' was not declared. Should it b

[PATCH v2 0/4] KVM minor fixups

2013-04-05 Thread Geoff Levand
Hi Paolo, I fixed up the series as requested. -Geoff V2: o Removed arm patches. o Moved kvm_spurious_fault to arch/x86/kvm/x86.c. o Fixed commit comments. The following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31 15:12:43 -0700) are available in

Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

2013-04-05 Thread Scott Wood
On 04/05/2013 01:09:50 AM, Alexander Graf wrote: Am 05.04.2013 um 00:35 schrieb Scott Wood : > On 04/04/2013 05:30:05 PM, Alexander Graf wrote: >> Am 04.04.2013 um 20:41 schrieb Scott Wood : >> > On 04/04/2013 07:54:20 AM, Alexander Graf wrote: >> >> On 03.04.2013, at 03:57, Scott Wood wrot

Re: [PATCH 6/7] ARM: KVM: switch to a dual-step HYP init code

2013-04-05 Thread Marc Zyngier
On 05/04/13 17:46, Geoff Levand wrote: Hi Geoff, > On Fri, 2013-04-05 at 10:08 +0100, Marc Zyngier wrote: >> On 04/04/13 23:10, Geoff Levand wrote: >>> On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote: + @ Jump to the trampoline page + ldr r2, =#PAGE_MASK + adr r3,

Re: [PATCH 6/7] ARM: KVM: switch to a dual-step HYP init code

2013-04-05 Thread Geoff Levand
Hi Marc, On Fri, 2013-04-05 at 10:08 +0100, Marc Zyngier wrote: > On 04/04/13 23:10, Geoff Levand wrote: > > On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote: > >> + @ Jump to the trampoline page > >> + ldr r2, =#PAGE_MASK > >> + adr r3, target > >> + bic r3, r3, r2 > >> + ld

Re: [PATCH 6/7] ARM: KVM: switch to a dual-step HYP init code

2013-04-05 Thread Marc Zyngier
On 04/04/13 23:10, Geoff Levand wrote: > Hi, > > On Tue, 2013-04-02 at 14:25 +0100, Marc Zyngier wrote: >> +@ Jump to the trampoline page >> +ldr r2, =#PAGE_MASK >> +adr r3, target >> +bic r3, r3, r2 >> +ldr r2, =#TRAMPOLINE_VA >> +add r3, r3, r2 >> +

Re: [PATCH V7 0/5] virtio-scsi multiqueue

2013-04-05 Thread Wanlong Gao
On 03/28/2013 10:22 AM, Wanlong Gao wrote: > On 03/23/2013 07:28 PM, Wanlong Gao wrote: >> This series implements virtio-scsi queue steering, which gives >> performance improvements of up to 50% (measured both with QEMU and >> tcm_vhost backends). >> >> This version rebased on Rusty's virtio ring r

Re: [PATCH] kvm: fix MMIO/PIO collision misdetection

2013-04-05 Thread Paolo Bonzini
Il 04/04/2013 12:27, Michael S. Tsirkin ha scritto: > PIO and MMIO are separate address spaces, but > ioeventfd registration code mistakenly detected > two eventfds as duplicate if they use the same address, > even if one is PIO and another one MMIO. > > Signed-off-by: Michael S. Tsirkin Reviewe

Re: [PATCH 0/7] KVM minor fixups

2013-04-05 Thread Paolo Bonzini
Il 05/04/2013 01:33, Geoff Levand ha scritto: > Hi Marcelo, > > These are a few fixups I found when running sparse and building Marc's 64 bit > ARM tree. Please consider for 3.10. Thanks, nice cleanups. Please resubmit patches 1-4 with the small fixes I suggested and, since you're at it, please

Re: [PATCH 3/7] kvm: Move kvm_spurious_fault dec out of x86

2013-04-05 Thread Paolo Bonzini
Il 05/04/2013 01:33, Geoff Levand ha scritto: > The routine kvm_spurious_fault() is a common kvm routine, so > move its declaration from arch/x86/include/asm/kvm_host.h to > arch/arm/include/asm/kvm_host.h. > > Fixes sparse warning when building on arm64: > > virt/kvm/kvm_main.c:warning: symbol

RE: [PATCH] bookehv: Handle debug exception on guest exit

2013-04-05 Thread Bhushan Bharat-R65777
Hi Kumar/Benh, After further looking into the code I think that if we correct the vector range below in DebugDebug handler then we do not need the change I provided in this patch. Here is the snapshot for 32 bit (head_booke.h, same will be true for 64 bit): #define DEBUG_DEBUG_EXCEPTION

Re: [PATCH 3/7] kvm: Move kvm_spurious_fault dec out of x86

2013-04-05 Thread Paolo Bonzini
Il 05/04/2013 01:33, Geoff Levand ha scritto: > The routine kvm_spurious_fault() is a common kvm routine, so > move its declaration from arch/x86/include/asm/kvm_host.h to > arch/arm/include/asm/kvm_host.h. Typo in the commit message. Paolo > Fixes sparse warning when building on arm64: > > v

Re: Virtualbox svga card in KVM

2013-04-05 Thread Stefan Hajnoczi
On Thu, Mar 21, 2013 at 10:53:21AM -0400, Alon Levy wrote: > > I am planning on bringing in the virtualbox svga card into kvm > > as a new svga card type (vbox probably?) so that we can load > > the VirtualBox SVGA card drivers in the guest. I'm curious if the vbox SVGA card has fea