Re: [PATCH v5 4/4] powerpc/eeh: Avoid event on passed PE

2014-05-21 Thread Gavin Shan
On Wed, May 21, 2014 at 03:13:11PM +0200, Alexander Graf wrote: > >On 21.05.14 07:03, Gavin Shan wrote: >>If we detects frozen state on PE that has been passed to guest, we >>needn't handle it. Instead, we rely on the guest to detect and recover >>it. The patch avoid EEH event on the frozen passed

Re: [PATCH v5 3/4] drivers/vfio: EEH support for VFIO PCI device

2014-05-21 Thread Gavin Shan
On Wed, May 21, 2014 at 03:07:26PM +0200, Alexander Graf wrote: > >On 21.05.14 07:03, Gavin Shan wrote: >>The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device >>to support EEH functionality for PCI devices, which have been >>passed from host to guest via VFIO. >> >>Signed-off-by: Gavin S

Re: [PATCH v5 3/4] drivers/vfio: EEH support for VFIO PCI device

2014-05-21 Thread Benjamin Herrenschmidt
On Wed, 2014-05-21 at 15:07 +0200, Alexander Graf wrote: > > +#ifdef CONFIG_VFIO_PCI_EEH > > +int eeh_vfio_open(struct pci_dev *pdev) > > Why vfio? Also that config option will not be set if vfio is compiled as > a module. > > > +{ > > + struct eeh_dev *edev; > > + > > + /* No PCI device ?

Re: [PATCH v5 4/4] powerpc/eeh: Avoid event on passed PE

2014-05-21 Thread Alexander Graf
On 21.05.14 07:03, Gavin Shan wrote: If we detects frozen state on PE that has been passed to guest, we needn't handle it. Instead, we rely on the guest to detect and recover it. The patch avoid EEH event on the frozen passed PE so that the guest can have chance to handle that. Signed-off-by: G

Re: [PATCH v5 3/4] drivers/vfio: EEH support for VFIO PCI device

2014-05-21 Thread Alexander Graf
On 21.05.14 07:03, Gavin Shan wrote: The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device to support EEH functionality for PCI devices, which have been passed from host to guest via VFIO. Signed-off-by: Gavin Shan --- Documentation/vfio.txt | 6 +- arch/powerpc/include/

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-21 Thread Gavin Shan
On Wed, May 21, 2014 at 05:24:22PM +1000, Benjamin Herrenschmidt wrote: >On Wed, 2014-05-21 at 08:23 +0200, Alexander Graf wrote: >> > Note to Alex: This definitely kills the notifier idea for now >> though, >> > at least as a first class citizen of the design. We can add it as an >> > optional opt

Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO

2014-05-21 Thread Benjamin Herrenschmidt
On Wed, 2014-05-21 at 08:23 +0200, Alexander Graf wrote: > > Note to Alex: This definitely kills the notifier idea for now > though, > > at least as a first class citizen of the design. We can add it as an > > optional optimization on top later. > > I don't think it does. The notifier would just g