[Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

Christophe de Vienne  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #6 from Christophe de Vienne  ---
A workaround was found that does not involve patching LibreOffice:

https://github.com/dveselov/go-libreofficekit/pull/16

I therefore close the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

--- Comment #5 from QA Administrators  ---
Dear Christophe de Vienne,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||143781


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143781
[Bug 143781] [META] Development- and code-related bug reports and tasks
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

--- Comment #4 from Stephan Bergmann  ---
I don't know if including SA_ONSTACK in sigaction calls could have any negative
consequences.  The main issue that comes to mind might be if a JVM is running
in-process alongside the LibreOffice code, and the JVM might for some reason be
picky about receiving its signals not on an altstack.  (I looked at
 as an example, to see whether or not the JVM
itself would routinely include SA_ONSTACK in sigaction calls.  But it appears
to not include it in general and only use it for one specific signal on macOS,
see

"8009302: Mac OS X: JVM crash on infinite recursion on Appkit Thread".)

Alternatively, LibreOfficeKit in general or that go-libreofficekit in
particular might want to not call osl_addSignalHandler (which is the only code
path that leads to that

> act.sa_flags = SA_RESTART | SA_SIGINFO;

line) in the first place?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #3 from Buovjaga  ---
Thanks for the patch! If possible could you submit it to our code review
system:

https://wiki.documentfoundation.org/Development/gerrit/setup
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch
https://wiki.documentfoundation.org/Development/GetInvolved#License_statement

If you need help, you can contact me via email.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

--- Comment #2 from gschrei...@diligent.com ---
I can confirm that the same issue is still present with

* go 1.18.5 and go 1.19
* LibreOffice 7.0.4.2 00(Build:2)
* Debian 11 (bullseye)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

Xisco Faulí  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

Christophe de Vienne  changed:

   What|Removed |Added

URL||https://github.com/dveselov
   ||/go-libreofficekit/issues/1
   ||3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

Christophe de Vienne  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Christophe de Vienne  ---
The bug is confirmed by other users on:
https://github.com/dveselov/go-libreofficekit/issues/13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140189] libreofficekit & golang: fatal error: non-Go code set up signal handler without SA_ONSTACK flag

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140189

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs