[Bug 165763] After adding a toolbar item, saving apparently hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=165763 --- Comment #6 from Buovjaga --- Created attachment 205365 --> https://bugs.documentfoundation.org/attachment.cgi?id=205365&action=edit Perf flamegraph of saving Took a perf trace of several seconds of saving. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 165763] After adding a toolbar item, saving apparently hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=165763 Buovjaga changed: What|Removed |Added Version|24.8.4.2 release|6.0.0.3 release Keywords||bibisected, haveBacktrace, ||perf, regression Status|UNCONFIRMED |NEW Whiteboard| QA:needsComment| OS|Linux (All) |All CC||ilmari.lauhakangas@libreoff ||ice.org Ever confirmed|0 |1 --- Comment #5 from Buovjaga --- (In reply to studog from comment #0) > # A "hung" save > 8a. Open the other copy > 8b. Tools -> Customize -> Toolbars > 8c. Scope -> Holdings--save-hang-blank.ods > 8d. Target -> HoldingsBar > 8e. Category -> Macros > 8f. Available Commands -> Holdings--save-hang-blank.ods :: Standard :: > Module1 :: Create_Blank > 8g. Click the Add Item button to add Create_Blank to the Assigned Commands > list, it should be the second item after "About LibreOffice" > 8h. Ok > 8i. Observe that the custom toolbar now has a text entry "Create_Blank" > 8j. Save the ODS > 8k. Observe that the save takes an unreasonable amount of time: I timed this > at around 1:42. Repro on Linux and Windows. After the file has been saved, reloading and saving again is quick. Saving used to take only about 5 secs, but then came the new Customize dialog: https://wiki.documentfoundation.org/ReleaseNotes/6.0#Dialogs I bibisected with linux-64-6.0 repo. With this commit we could no longer assign a macro: d69f9436b59e249af8dcac88ccadf09b920b1bab Convert UI of Customize Dialog to the new design This commit restored the ability, but the long saving time was already apparent: 3b12778af71951bfce321c73509e8b0c59b02853 tdf#112207: Allow assigning macros to ui elements I'm not sure, if anything in the dialog revamp itself could have caused this, or if it just masks a bug introduced within the period when it was impossible to add macros to toolbars. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 165763] After adding a toolbar item, saving apparently hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=165763 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 165763] After adding a toolbar item, saving apparently hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=165763 studog changed: What|Removed |Added Ever confirmed|1 |0 Status|NEW |UNCONFIRMED --- Comment #4 from studog --- Setting back to UNCONFIRMED. After some lurking of the "Bugs reported in the last 24 hours" list, I see that UNCONFIRMED is the default status for a newly reported bug. I had assumed NEW would be the default status and was wrong. Apologies. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 165763] After adding a toolbar item, saving apparently hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=165763 studog changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from studog --- Not sure how this got set to unconfirmed. The reproduction is 100%. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 165763] After adding a toolbar item, saving apparently hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=165763 --- Comment #2 from studog --- Part of the problem is the experience the end user receives: the save progress bar appears immediately and then nothing happens for a long long time. Reproduced, timed at 1:36, on: Version: 25.2.5.2 (X86_64) / LibreOffice Community Build ID: 520(Build:2) CPU threads: 16; OS: Linux 6.11; UI render: default; VCL: gtk3 Locale: en-US (C.UTF-8); UI: en-US Ubuntu package version: 4:25.2.5~rc2-0ubuntu0.24.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 165763] After adding a toolbar item, saving apparently hangs
https://bugs.documentfoundation.org/show_bug.cgi?id=165763 --- Comment #1 from studog --- Created attachment 199832 --> https://bugs.documentfoundation.org/attachment.cgi?id=199832&action=edit Example test case, broken -- You are receiving this mail because: You are the assignee for the bug.
