Re: [Libvir] Linker dependancoes [Re: [kvm-devel] QEMU / KVM support in libvirt & virt-manager]

2007-02-26 Thread David Lutterkort
On Mon, 2007-02-26 at 00:07 +0100, Karel Zak wrote: > On Sun, Feb 25, 2007 at 08:48:12PM +, Daniel P. Berrange wrote: > > See this thread on kvm-devel for a question about link time dependancies > > in libvirt. I'm not sure what the optimal approach is for us to deal with > > this is - just som

[Libvir] Remote patch, 2007-02-26

2007-02-26 Thread Richard W.M. Jones
I was really hoping to have a patch which could be applied out today. This isn't quite that patch, so my apologies. Nevertheless, this demonstrates what can be done, and works on a selection of the important libvirt API calls. http://www.annexia.org/tmp/libvirt-tls-20070226.patch Li

[Libvir] [PATCH] Add a default network

2007-02-26 Thread Mark McLoughlin
Hey, So, we want to install a default network which guests can connect to. This can be seen as e.g. a replacement for xenbr0 as the default bridge for xen guests. A few things concern me about the patch, see below for my thinking. However, I'm happy to punt on all of these issues f

Re: [Libvir] [patch 3/3] Use libuuid to generate UUIDs

2007-02-26 Thread Daniel P. Berrange
On Mon, Feb 26, 2007 at 03:10:24PM +, Mark McLoughlin wrote: > On Mon, 2007-02-26 at 14:50 +, Daniel P. Berrange wrote: > > On Mon, Feb 26, 2007 at 02:28:30PM +, Mark McLoughlin wrote: > > > If libuuid from e2fsprogs is available, we use that to > > > generate UUIDs. > > > > On the one

Re: [Libvir] [patch 3/3] Use libuuid to generate UUIDs

2007-02-26 Thread Mark McLoughlin
On Mon, 2007-02-26 at 14:50 +, Daniel P. Berrange wrote: > On Mon, Feb 26, 2007 at 02:28:30PM +, Mark McLoughlin wrote: > > If libuuid from e2fsprogs is available, we use that to > > generate UUIDs. > > On the one hand I think its good to re-use existing libraries where > they fullfill our

Re: [Libvir] [patch 3/3] Use libuuid to generate UUIDs

2007-02-26 Thread Daniel P. Berrange
On Mon, Feb 26, 2007 at 02:28:30PM +, Mark McLoughlin wrote: > If libuuid from e2fsprogs is available, we use that to > generate UUIDs. On the one hand I think its good to re-use existing libraries where they fullfill our needs, but then we need to keep a built-in impl of UUID generator for no

Re: [Libvir] [patch 1/3] Add UUID generation to qemud

2007-02-26 Thread Richard W.M. Jones
Mark McLoughlin wrote: +static int +qemudGenerateRandomBytes(unsigned char *buf, + int buflen) +{ +int fd; + +if ((fd = open("/dev/urandom", O_RDONLY)) < 0) +return errno; + +while (buflen > 0) { +int n; + +if ((n = read(fd, buf, buflen

Re: [Libvir] [patch 0/3] Automatically generate UUIDs in qemud

2007-02-26 Thread Richard W.M. Jones
Mark McLoughlin wrote: Hey, We currently require guests and networks to have a UUID defined. This patch automatically generates a UUID if one isn't supplied. This is needed because the default network we install won't have a UUID assigned, since we'll want the UUID to be differen

[Libvir] [patch 3/3] Use libuuid to generate UUIDs

2007-02-26 Thread Mark McLoughlin
If libuuid from e2fsprogs is available, we use that to generate UUIDs. Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/configure.in === --- libvirt.orig/configure.in +++ libvirt/configure.in @@ -189,6 +189,22 @@ dnl

[Libvir] [patch 1/3] Add UUID generation to qemud

2007-02-26 Thread Mark McLoughlin
If a guest or network does not have a UUID assigned to it, we generate a random UUID preferably using /dev/urandom, but falling back to pseudo-random number generation if that fails. Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/Makefile.am ==

[Libvir] [patch 0/3] Automatically generate UUIDs in qemud

2007-02-26 Thread Mark McLoughlin
Hey, We currently require guests and networks to have a UUID defined. This patch automatically generates a UUID if one isn't supplied. This is needed because the default network we install won't have a UUID assigned, since we'll want the UUID to be different on different hosts. Ch

[Libvir] [patch 2/3] Move qemudParseUUID() to uuid.

2007-02-26 Thread Mark McLoughlin
Seems like the obvious place for it now ... Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Index: libvirt/qemud/conf.c === --- libvirt.orig/qemud/conf.c +++ libvirt/qemud/conf.c @@ -47,54 +47,6 @@ #include "iptables.h" #include

Re: [Libvir] PATCH: Don't auto-set VNC port to 5900+domid

2007-02-26 Thread Saori Fukuta
Hi, Dan On Thu, 22 Feb 2007 22:10:02 + "Daniel P. Berrange" wrote: > The current code for stuffing the VNC port number into the XML looks in > XenStore for the VNC port number, and if it does not find it there falls > back to using 5900+domid. This is a problem because it leaves open a > race