Re: [Libvir] Proposed remote protocol (XDR source file qemud/remote_protocol.x)

2007-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2007 at 06:48:26PM +0100, Richard W.M. Jones wrote: > Richard W.M. Jones wrote: > >The only problem area are the upper limits imposed on the lengths of > >various strings and arrays. The upper limits seem to be required for > >safely decoding messages from untrusted sources. Som

Re: [Libvir] Proposed remote protocol (XDR source file qemud/remote_protocol.x)

2007-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2007 at 06:42:01PM +0100, Richard W.M. Jones wrote: > Attached are the args (*_args) and return structures (*_ret) for all the > calls covered by the remote protocol, that is to say everything except > Save, Restore and CoreDump (see previous email). > > The only problem area are

Re: [Libvir] Proposed remote protocol (XDR source file qemud/remote_protocol.x)

2007-04-30 Thread Richard W.M. Jones
Richard W.M. Jones wrote: The only problem area are the upper limits imposed on the lengths of various strings and arrays. The upper limits seem to be required for safely decoding messages from untrusted sources. Some of them however would impose limits on such things as the number of CPUs su

[Libvir] Proposed remote protocol (XDR source file qemud/remote_protocol.x)

2007-04-30 Thread Richard W.M. Jones
Attached are the args (*_args) and return structures (*_ret) for all the calls covered by the remote protocol, that is to say everything except Save, Restore and CoreDump (see previous email). The only problem area are the upper limits imposed on the lengths of various strings and arrays. The

Re: [Libvir] [PATCH] Remove VIR_DRV_OPEN_QUIET

2007-04-30 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Mon, Apr 30, 2007 at 12:41:52PM +0100, Richard W.M. Jones wrote: VIR_DRV_OPEN_QUIET causes important diagnostic error messages to be thrown away. This patch removes this. We used to use this flag to make the Xen drivers keep quite when connecting to test, or qemu

Re: [Libvir] [PATCH] Remove VIR_DRV_OPEN_QUIET

2007-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2007 at 12:41:52PM +0100, Richard W.M. Jones wrote: > VIR_DRV_OPEN_QUIET causes important diagnostic error messages to be > thrown away. This patch removes this. We used to use this flag to make the Xen drivers keep quite when connecting to test, or qemu backends. The refactoring

Re: [Libvir] [PATCH] Xen proxy - adds getCapabilities call

2007-04-30 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Mon, Apr 30, 2007 at 12:35:04PM +0100, Richard W.M. Jones wrote: Seems to me that it should be safe to allow non-root callers to use the getCapabilities call over the Xen proxy. This patch adds that feature. Yes, that's a reasonable use case. The patch looks OK to

Re: [Libvir] [PATCH] Fix xen-unified to work in non-root case

2007-04-30 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Mon, Apr 30, 2007 at 12:32:00PM +0100, Richard W.M. Jones wrote: Xen-unified introduced a stupid bug, down to me, when running in the non-root case. It didn't keep track of which drivers successfully opened, so will try and perform operations on drivers which didn'

Re: [Libvir] Difference between API functions virConnectNumOfDefinedDomains and virConnectNumOfDomains

2007-04-30 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Mon, Apr 30, 2007 at 10:12:43AM +0100, Richard W.M. Jones wrote: Jan Michael wrote: Hello libvirt fellows, I have some problems to distinguish between those function calls in libvirt API: virConnectNumOfDefinedDomains virConnectNumOfDomains The API description s

Re: [Libvir] Difference between API functions virConnectNumOfDefinedDomains and virConnectNumOfDomains

2007-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2007 at 10:12:43AM +0100, Richard W.M. Jones wrote: > Jan Michael wrote: > >Hello libvirt fellows, > > > >I have some problems to distinguish between those function calls in libvirt > >API: > > > >>virConnectNumOfDefinedDomains > >>virConnectNumOfDomains > > > >The API description s

Re: [Libvir] [PATCH] Fix xen-unified to work in non-root case

2007-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2007 at 12:32:00PM +0100, Richard W.M. Jones wrote: > Xen-unified introduced a stupid bug, down to me, when running in the > non-root case. It didn't keep track of which drivers successfully > opened, so will try and perform operations on drivers which didn't open. > I suggest

Re: [Libvir] [PATCH] Xen proxy - adds getCapabilities call

2007-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2007 at 12:35:04PM +0100, Richard W.M. Jones wrote: > Seems to me that it should be safe to allow non-root callers to use the > getCapabilities call over the Xen proxy. This patch adds that feature. Yes, that's a reasonable use case. The patch looks OK to me. Dan. -- |=- Red Ha

[Libvir] RFC: Behaviour of virConnectSave, Restore and CoreDump in the remote case

2007-04-30 Thread Richard W.M. Jones
virDomainSave (for example) is currently defined like this: /** * virDomainSave: * @domain: a domain object * @to: path for the output file * * This method will suspend a domain and save its memory contents to * a file on disk. After the call, if successful, the domain is not * listed as r

[Libvir] [PATCH] Remove VIR_DRV_OPEN_QUIET

2007-04-30 Thread Richard W.M. Jones
VIR_DRV_OPEN_QUIET causes important diagnostic error messages to be thrown away. This patch removes this. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 Registered Address: Red Hat UK Ltd, Amberley Place, 10

[Libvir] [PATCH] Xen proxy - adds getCapabilities call

2007-04-30 Thread Richard W.M. Jones
Seems to me that it should be safe to allow non-root callers to use the getCapabilities call over the Xen proxy. This patch adds that feature. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 Registered Addres

[Libvir] [PATCH] Fix xen-unified to work in non-root case

2007-04-30 Thread Richard W.M. Jones
Xen-unified introduced a stupid bug, down to me, when running in the non-root case. It didn't keep track of which drivers successfully opened, so will try and perform operations on drivers which didn't open. I suggest that if people approve of the attached patch, then it is applied with some

Re: [Libvir] Difference between API functions virConnectNumOfDefinedDomains and virConnectNumOfDomains

2007-04-30 Thread Richard W.M. Jones
Jan Michael wrote: Hello libvirt fellows, I have some problems to distinguish between those function calls in libvirt API: virConnectNumOfDefinedDomains virConnectNumOfDomains The API description states on both function that they will return me the number of active domain. Am I right if I as

Re: [Libvir] Re: [PATCH] allocate virBuffer* routines

2007-04-30 Thread Karel Zak
On Tue, Apr 24, 2007 at 09:48:09PM +0900, S.Sakamoto wrote: > diff -u -p -r1.110 xend_internal.c > --- src/xend_internal.c 23 Apr 2007 07:41:23 - 1.110 > +++ src/xend_internal.c 24 Apr 2007 11:00:55 - > @@ -587,24 +587,33 @@ static int > xend_op_ext2(virConnectPtr xend, co

[Libvir] Difference between API functions virConnectNumOfDefinedDomains and virConnectNumOfDomains

2007-04-30 Thread Jan Michael
Hello libvirt fellows, I have some problems to distinguish between those function calls in libvirt API: > virConnectNumOfDefinedDomains > virConnectNumOfDomains The API description states on both function that they will return me the number of active domain. Am I right if I assume that the first