Re: [Libvir] PATCH: Disable xm_internal.c on newer XenD

2007-05-02 Thread Daniel P. Berrange
On Tue, May 01, 2007 at 01:33:29PM +0100, Daniel P. Berrange wrote: > The xm_internal.c driver (that processes /etc/xen config files) is only ever > intended to be used on XenD <= 3.0.3 There are impls of all the methods in > xend_internal.c that take priority on newer XenD, since the xend driver

Re: [Libvir] PATCH: Use --strict-order with dnsmasq

2007-05-02 Thread Daniel P. Berrange
On Tue, May 01, 2007 at 01:24:35PM +0100, Daniel P. Berrange wrote: > A bug reported by David Lutterkort... > > The 'man resolv.conf' docs for 'nameserver' say > > [quote] >nameserver Name server IP address > Internet address (in dot notation) of a name server that > t

[PATCH] Remote 1/8: Additional error handling (was: Re: [Libvir] [PATCH] Remote 0/8: Plan)

2007-05-02 Thread Richard W.M. Jones
Richard W.M. Jones wrote: Richard W.M. Jones wrote: 1 Additional error handling Ooops - subject line of that email was wrong. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 Registered Address: Red Hat UK L

Re: [Libvir] [PATCH] Remote 0/8: Plan

2007-05-02 Thread Richard W.M. Jones
Richard W.M. Jones wrote: 1 Additional error handling --- M include/libvirt/virterror.h M src/virterror.c Attached is the patch to add the additional types of errors to virterror. VIR_FROM_REMOTE indicates that the error originated in the remote driver. There are tw

[Libvir] [PATCH] Remote 0/8: Plan

2007-05-02 Thread Richard W.M. Jones
Below is the plan for delivering the remote patch for review in stages. More details about in each email. I only expect to get through the first two emails today. Rich. 1 Additional error handling --- M include/libvirt/virterror.h M src/virterror.c 2 Client-server

Re: [Libvir] [PATCH] Synchronous daemon restart

2007-05-02 Thread Daniel P. Berrange
On Wed, May 02, 2007 at 06:02:56PM +0100, Mark McLoughlin wrote: > On Wed, 2007-05-02 at 17:52 +0100, Daniel P. Berrange wrote: > > On Wed, May 02, 2007 at 05:50:41PM +0100, Mark McLoughlin wrote: > > > > The fix is simple - if you don't pass a kill level argument to > > > killproc(), then it wi

Re: [Libvir] [PATCH] Allow network drivers to decline to take a connection

2007-05-02 Thread Richard W.M. Jones
Richard W.M. Jones wrote: A couple of problems fixed in the attached patch. Firstly the path used to connect to the network driver in non-root mode was wrong. This may have affected you if you tried to use the test:///default driver as non-root. I haven't tested this fully, but in any case

Re: [Libvir] [PATCH] Don't throw away errors in virConnectOpen (at least not so often)

2007-05-02 Thread Richard W.M. Jones
This patch has been committed. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered

Re: [Libvir] [PATCH] Synchronous daemon restart

2007-05-02 Thread Mark McLoughlin
On Wed, 2007-05-02 at 17:52 +0100, Daniel P. Berrange wrote: > On Wed, May 02, 2007 at 05:50:41PM +0100, Mark McLoughlin wrote: > > The fix is simple - if you don't pass a kill level argument to > > killproc(), then it will block for a few seconds until the daemon has > > shutdown before killi

Re: [Libvir] [PATCH] Synchronous daemon restart

2007-05-02 Thread Daniel P. Berrange
On Wed, May 02, 2007 at 05:50:41PM +0100, Mark McLoughlin wrote: > Hey, > See: > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238492 > > Basically, doing a "service libvirtd restart", you see: > > libvirt-qemud: Failed to autostart network 'default': cannot create bridg

[Libvir] [PATCH] Synchronous daemon restart

2007-05-02 Thread Mark McLoughlin
Hey, See: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238492 Basically, doing a "service libvirtd restart", you see: libvirt-qemud: Failed to autostart network 'default': cannot create bridge 'virbr0' : File exists and the default network is broken.

Re: [Libvir] PATCH: Support poweroff in QEMU/KVM

2007-05-02 Thread Richard W.M. Jones
Daniel P. Berrange wrote: In doing this patch I had to change the way we read data from QEMU. We were over the 4096 buffer size, and also in some cases we were getting a short read which meant we lost the end of the help message. We now have a buffer of 8k (max QEMU help is 5k currently), and re

[Libvir] PATCH: Support poweroff in QEMU/KVM

2007-05-02 Thread Daniel P. Berrange
Currently in the QEMU driver we don't support any of the customizable shutdown operation behaviour elements in the XML. ie destroy restart restart This was principally because we don't particularly have a good way to actually implement some of them. Well, QEMU 0.9.0 added a -no-reboot flag

Re: [Libvir] [PATCH] Allow virDomainDefine to overwrite existing inactive domains for xen 3.0.3 userspace installations

2007-05-02 Thread Daniel P. Berrange
On Tue, May 01, 2007 at 01:30:23PM -0400, Hugh Brock wrote: > +if (!(olddomain = virGetDomain(conn, value->str, uuid))) > +goto error; > + > +if (olddomain->id != -1) { > +xenXMError(conn, VIR_ERR_INTERNAL_ERROR, "can't overwrite an > active domain"); > +

Re: [Libvir] [PATCH] Don't throw away errors in virConnectOpen (at least not so often)

2007-05-02 Thread Daniel P. Berrange
On Wed, May 02, 2007 at 08:15:11AM -0400, Daniel Veillard wrote: > On Tue, May 01, 2007 at 03:04:32PM +0100, Richard W.M. Jones wrote: > > Error messages, I like them. I don't like them to be thrown away. > > > > A nice feature of virterror is that it'll throw away errors under the > > following

[Libvir] Request for minimum memory level of dom0 (xen)

2007-05-02 Thread Jan Michael
Hi LibVirt-Mailreaders, Is it possible to provide information about the minimum memory level of domain 0 (xen)? The value is located in the xen deamon config file as "dom0-min-mem". I would like to calculate on the basis of this value if there is enough memory left to create additional domains.

Re: [Libvir] Remote patch, 2007-05-01

2007-05-02 Thread Richard W.M. Jones
Daniel Veillard wrote: On Tue, May 01, 2007 at 06:47:04PM +0100, Richard W.M. Jones wrote: This is a patch against CVS -- in other words, it includes the two previous patches I sent to this list today. Compared to the previous patch, it's just bug fixes and testing. Sorry, these patches are g

Re: [Libvir] Remote patch, 2007-05-01

2007-05-02 Thread Daniel Veillard
On Tue, May 01, 2007 at 06:47:04PM +0100, Richard W.M. Jones wrote: > This is a patch against CVS -- in other words, it includes the two > previous patches I sent to this list today. > > Compared to the previous patch, it's just bug fixes and testing. > > Sorry, these patches are getting rather

Re: [Libvir] [PATCH] Allow network drivers to decline to take a connection

2007-05-02 Thread Richard W.M. Jones
Daniel Veillard wrote: Looks fine, I assume no other network driver exist yet so there is only once to fix for return values. That's right, apart from remote in my private copy (which I've fixed). Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London

Re: [Libvir] [PATCH] Allow network drivers to decline to take a connection

2007-05-02 Thread Daniel Veillard
On Tue, May 01, 2007 at 05:55:16PM +0100, Richard W.M. Jones wrote: > A couple of problems fixed in the attached patch. > > Firstly the path used to connect to the network driver in non-root mode > was wrong. This may have affected you if you tried to use the > test:///default driver as non-roo

Re: [Libvir] [PATCH] Don't throw away errors in virConnectOpen (at least not so often)

2007-05-02 Thread Daniel Veillard
On Tue, May 01, 2007 at 03:04:32PM +0100, Richard W.M. Jones wrote: > Error messages, I like them. I don't like them to be thrown away. > > A nice feature of virterror is that it'll throw away errors under the > following conditions: > (1) You are in virConnectOpen, and > (2) You pass a non-NULL

Re: [Libvir] PATCH: Disable xm_internal.c on newer XenD

2007-05-02 Thread Daniel Veillard
On Tue, May 01, 2007 at 01:33:29PM +0100, Daniel P. Berrange wrote: > The xm_internal.c driver (that processes /etc/xen config files) is only ever > intended to be used on XenD <= 3.0.3 There are impls of all the methods in > xend_internal.c that take priority on newer XenD, since the xend driver

Re: [Libvir] RFC: Behaviour of virConnectSave, Restore and CoreDump in the remote case

2007-05-02 Thread Richard W.M. Jones
Daniel Veillard wrote: What do you think ? Agreed. I'll make it save remotely for now, we can extend the filename / URI syntax in those fancy ways later. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 Re

Re: [Libvir] RFC: Behaviour of virConnectSave, Restore and CoreDump in the remote case

2007-05-02 Thread Daniel Veillard
On Mon, Apr 30, 2007 at 03:35:54PM +0100, Richard W.M. Jones wrote: > virDomainSave (for example) is currently defined like this: > > /** > * virDomainSave: > * @domain: a domain object > * @to: path for the output file > * > * This method will suspend a domain and save its memory contents to

Re: [Libvir] [PATCH] Allow virDomainDefine to overwrite existing inactive domains for xen 3.0.3 userspace installations

2007-05-02 Thread Richard W.M. Jones
Hugh Brock wrote: virDomainDefineXML should overwrite an existing inactive domain config if it finds one; it does this successfully for later (post 3.0.3) xen versions. However on xen 3.0.3 overwriting an existing config would fail with a name conflict. This patch allows the overwrite, removing

Re: [Libvir] Re: [PATCH] allocate virBuffer* routines

2007-05-02 Thread Daniel Veillard
On Mon, Apr 30, 2007 at 10:02:36AM +0200, Karel Zak wrote: > On Tue, Apr 24, 2007 at 09:48:09PM +0900, S.Sakamoto wrote: > > diff -u -p -r1.110 xend_internal.c > > --- src/xend_internal.c 23 Apr 2007 07:41:23 - 1.110 > > +++ src/xend_internal.c 24 Apr 2007 11:00:55 - > > @@ -58

Re: [Libvir] PATCH: Use --strict-order with dnsmasq

2007-05-02 Thread Mark McLoughlin
On Tue, 2007-05-01 at 13:24 +0100, Daniel P. Berrange wrote: > Thus I think we should always use --strict-order when running dnsmasq. The > attached patch adds this Yep, sounds good to me. Cheers, Mark. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/li