Re: [Libvir] Question on acquiring cpuTime in struct _virDomainInfo

Hi Daniel, first I'd like to thank you for your speedy answer and the suggested solution. But I think it doesn't fit to my problem. The program I write is a sensor, which is executed by a given time intervall. So I'm not able to cache the domain handles. But that rises another question in m

Re: [Libvir] [PATCH] add scheduler API(take 3?)

Hi, Rich Thank you for detailed code review. I comment inline "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > +char * > +virDomainGetSchedulerType(virDomainPtr domain, int *nparams) > +{ > +virConnectPtr conn; > +char *schedtype; > + > +if (domain == NULL) { > +TODO > +

Re: [Libvir] [PATCH] Add Python binding for virGetVersion

Hey, So, the semantics for virGetVersion() are: - virGetVersion(&ver, NULL, NULL) returns the libvirt version only - virGetVersion(&ver, NULL, &xenVer) returns the libvirt version and the xen version - virGetVersion(&ver, "foo", &fooVer) returns the libvirt version and the

Re: [Libvir] [PATCH] add scheduler API(take 3?)

+char * +virDomainGetSchedulerType(virDomainPtr domain, int *nparams) +{ +virConnectPtr conn; +char *schedtype; + +if (domain == NULL) { +TODO +return NULL; +} Is this case an error, or were you thinking of adding more semantics later on here? (and the same comm

Re: [Libvir] [PATCH] output virsh log to file

On Tue, 2007-05-22 at 20:32 +0100, Daniel P. Berrange wrote: > On Tue, May 22, 2007 at 03:15:03PM +0100, Richard W.M. Jones wrote: > > > > I really think we should be looking at either a logging library, or > > (better) syslog. These problems -- like logfile maxsize, logfile > > location, log r

Re: [Libvir] [PATCH] output virsh log to file

Hi, Rich Thank you for your suggestion. We also think this kind of solution. But from our view, the best solution is inclusion of this patch to libvirt. the second solution is to use your suggestion. So his mail is asking the logging policy of libvirt. Thanks Atsushi SAKAI "Richard W.M. Jone

Re: [Libvir] [PATCH] output virsh log to file

Nobuhiro Itou wrote: Certainly, virsh does not provide enough information now. But I want virsh to provide useful information in the future. First, I want to implement this logging function. In addition, I think that we should not let customers take trouble. Cannot you apply this patch? The

Re: [Libvir] [PATCH] add scheduler API(take 3?)

Hi, Rich Thank you for your comments. I comment with inline. "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > +unsigned long long int ul; > > Is "long long" part of ANSI C? I thought it was a gcc extension. I > think you should use to give you integers of fixed sizes, > which see

Re: [Libvir] Please check my autoconf libvirt.m4

Hi Rich, I'd stick with just using pkg-config to check for the library itself and using a runtime check for supported drivers. As for checking for the python module, I don't really think virt-manager wants to do this at build time since it's not actually a build dep. Personally I t

Re: [Libvir] [PATCH] output virsh log to file

Hi, Dan Thank you for your comment. > > >>But my broader point is: What use would this feature be, since you can > > >>capture the output of virsh easily using shell redirection? The Xen > > >>'xm' command doesn't have this feature and I don't know if anyone has > > >>asked for it. > > > > >