Re: [Libvir] PATCH: Fix remote driver to handle network API for local non-QEMU

2007-06-29 Thread Richard W.M. Jones
OK, I ran the second version in a few local and remote cases and couldn't get it to do bad things, so +1. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingd

Re: [Libvir] Cleanup patch

2007-06-29 Thread Daniel Veillard
On Fri, Jun 29, 2007 at 02:40:23PM +0100, Richard W.M. Jones wrote: > >@@ -113,12 +128,19 @@ virBufferFree(virBufferPtr buf) > > * virBufferContentAndFree: > > * @buf: Buffer > > * > >- * Return the content from the buffer and free (only) the buffer > >structure. > >+ * Get the content from the

Re: [Libvir] PATCH: Fix remote driver to handle network API for local non-QEMU

2007-06-29 Thread Daniel Veillard
On Fri, Jun 29, 2007 at 03:08:47PM +0100, Daniel P. Berrange wrote: > On Wed, Jun 27, 2007 at 07:04:00PM +0100, Daniel P. Berrange wrote: > > The remote_internal.c code is basically a no-op in its remoteNetworkOpen > > method. This means the remote driver will only handle the networking > > APIs, i

Re: [Libvir] PATCH: Fix remote driver to handle network API for local non-QEMU

2007-06-29 Thread Daniel P. Berrange
On Wed, Jun 27, 2007 at 07:04:00PM +0100, Daniel P. Berrange wrote: > The remote_internal.c code is basically a no-op in its remoteNetworkOpen > method. This means the remote driver will only handle the networking > APIs, if it is also handling the main domain APIs. This works fine if > connecting

[Libvir] re: hvsupport html page

2007-06-29 Thread Philippe Berthault
A great work ! This new help page will be very useful for all developers :-) Thanks a lot. P.Berthault. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()

2007-06-29 Thread Daniel Veillard
On Fri, Jun 29, 2007 at 05:36:44PM +0900, Masayuki Sunou wrote: > Hi Rich, Dan > > Thank you for a reviewing and detailed suggestion. > I understand your suggestion as follows and remake a patch. > - The reason that the virDomain object is not cleared is the garbage >collector does not work w

Re: [PATCH] hvsupport page documents libvirt versions and supportedhypervisorcalls (was: Re: [Libvir] request for libvirt documentation improvement)

2007-06-29 Thread Atsushi SAKAI
Hi, Rich It is very useful to me too! Thanks Atsushi SAKAI "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > > The patch is attached. > > The web page will appear at http://libvirt.org/hvsupport.html within an > hour or so. > > Rich. > > -- > Emerging Technologies, Red Hat - http://et.re

Re: [Libvir] Cleanup patch

2007-06-29 Thread Richard W.M. Jones
Daniel Veillard wrote: Enclosed is a cleanup patch I applied, it corrects the XML api generation, fixes warning in the XSLT stylesheet, add comments to a number of internal functions, makes most function of the QEmu back-end static, fixes a few bugs found in the way. Looks fine, except my gene

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()

2007-06-29 Thread Daniel Veillard
On Fri, Jun 29, 2007 at 05:36:44PM +0900, Masayuki Sunou wrote: > Hi Rich, Dan > > Thank you for a reviewing and detailed suggestion. > I understand your suggestion as follows and remake a patch. > - The reason that the virDomain object is not cleared is the garbage >collector does not work w

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()

2007-06-29 Thread Richard W.M. Jones
Masayuki Sunou wrote: Hi Rich, Dan +1. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration N

Re: [PATCH] hvsupport page documents libvirt versions and supported hypervisor calls (was: Re: [Libvir] request for libvirt documentation improvement)

2007-06-29 Thread Daniel Veillard
On Fri, Jun 29, 2007 at 01:44:25PM +0100, Richard W.M. Jones wrote: > > The patch is attached. > > The web page will appear at http://libvirt.org/hvsupport.html within an > hour or so. Cool, it's there :-) The web site is actually updated every 30 mn (I could increase the frequency if needed,

[Libvir] Cleanup patch

2007-06-29 Thread Daniel Veillard
Enclosed is a cleanup patch I applied, it corrects the XML api generation, fixes warning in the XSLT stylesheet, add comments to a number of internal functions, makes most function of the QEmu back-end static, fixes a few bugs found in the way. Daniel -- Red Hat Virtualization group http://redh

[PATCH] hvsupport page documents libvirt versions and supported hypervisor calls (was: Re: [Libvir] request for libvirt documentation improvement)

2007-06-29 Thread Richard W.M. Jones
The patch is attached. The web page will appear at http://libvirt.org/hvsupport.html within an hour or so. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United K

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()

2007-06-29 Thread Masayuki Sunou
Hi Rich, Dan Thank you for a reviewing and detailed suggestion. I understand your suggestion as follows and remake a patch. - The reason that the virDomain object is not cleared is the garbage collector does not work well. And its cause is virsh.c misses the call of virDomainFree(). This p

Re: [Libvir] Proposal: New virDomainLookup function to indicate Not found vs Error

2007-06-29 Thread Richard W.M. Jones
Daniel P. Berrange wrote: That said, I'm not convinced we need this if we fix the error reporting of the original functions to allow the 'no such domain' error to be reliably caught & handled. OK, I tend to agree. I'll come up with a patch which adds the no-such-domain/network errors and make