Re: [Libvir] PATCH Fix a couple of mem leaks

2007-07-30 Thread Daniel P. Berrange
On Mon, Jul 30, 2007 at 10:14:25PM +0100, Daniel P. Berrange wrote: > I ran 'make valgrind' for the first time in too long and found a hanful of > memory leaks in code exercised by the test suite. The attached patch fixes > them all. BTW, someone might have the answer for a question about valgrind

[Libvir] PATCH Fix a couple of mem leaks

2007-07-30 Thread Daniel P. Berrange
I ran 'make valgrind' for the first time in too long and found a hanful of memory leaks in code exercised by the test suite. The attached patch fixes them all. I'm sure there are more lurking though - the test suite is mainly focused on exercising & validating correctness of parsing routines - its

Re: [Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen

2007-07-30 Thread Daniel Veillard
On Fri, Jul 27, 2007 at 04:24:46PM -0700, David Lutterkort wrote: > Updated patch, incorporating feedback. > > Besides formatting, changes how apic is reported - and that's not > pretty. As danpb found out, in cset 12423:ebed72718263 in xen-unstable, > setting the apic was removed from tools/libxc

Re: [Libvir] Re: PATCH 1/2: Qemu feature reporting

2007-07-30 Thread Daniel Veillard
On Fri, Jul 27, 2007 at 04:07:05PM -0700, David Lutterkort wrote: > Patch updated with feedback (mostly formatting) Looks great, applied and commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvir

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-30 Thread Daniel Veillard
On Mon, Jul 30, 2007 at 11:52:16AM +0900, Atsushi SAKAI wrote: > Hi, Dan > > Thank you for your suggestion. > My concern is if patch for sysctl v4 is applied or not. > Since previously Daniel commented, libvirt does not include the patch for > Xen-unstable only includes for versioned like Xen-3.x