[Libvir] PATCH: Explicit detection of KVM version

2007-09-19 Thread Daniel P. Berrange
Before starting any guest, the QEMU driver needs to figure out what version of QEMU is in use & thus determine whether it supports particular command line flags. We currently do that just by calling /usr/bin/qemu, since all the various qemu-system-XXX binaries share the same syntax. The only probl

Re: [Libvir] [PATCH] virConnectNumOfDefinedDomains should set virterror if cannot connect to xend

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 07:16:25PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 19, 2007 at 07:10:12PM +0100, Richard W.M. Jones wrote: > > As well as $SUBJECT this also adds a comment so that the apparent lack > > of error in another part of the code is clear. > > Looks good to me. same, +1

Re: [Libvir] PATCH: Allow remote driver to handle any connection URI

2007-09-19 Thread Daniel P. Berrange
On Wed, Sep 19, 2007 at 06:49:48PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 19, 2007 at 02:51:42PM +0100, Richard W.M. Jones wrote: > > > > Are you sure they don't go over the wire? My reading of doRemoteOpen > > suggests that they do: > > > > static int > > doRemoteOpen (virConnectPtr co

Re: [Libvir] Java bindings

2007-09-19 Thread Tóth István
A new version is available at http://tiger.3ginformatika.hu/java-libvirt-0.1.tgz Changes: -Javadoc documentation -Some fields weren't marked public -Minor consistency fixes -No new functionality regards István Tóth István wrote: Hello! A development version of the java bindings I've been work

Re: [Libvir] [PATCH] virConnectNumOfDefinedDomains should set virterror if cannot connect to xend

2007-09-19 Thread Daniel P. Berrange
On Wed, Sep 19, 2007 at 07:10:12PM +0100, Richard W.M. Jones wrote: > As well as $SUBJECT this also adds a comment so that the apparent lack > of error in another part of the code is clear. Looks good to me. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |

[Libvir] [PATCH] virConnectNumOfDefinedDomains should set virterror if cannot connect to xend

2007-09-19 Thread Richard W.M. Jones
As well as $SUBJECT this also adds a comment so that the apparent lack of error in another part of the code is clear. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE,

Re: [Libvir] PATCH: Remove Xen Proxy driver

2007-09-19 Thread Daniel P. Berrange
On Wed, Sep 19, 2007 at 06:27:39AM -0400, Daniel Veillard wrote: > On Wed, Sep 19, 2007 at 06:22:58AM -0400, Daniel Veillard wrote: > > On Wed, Sep 19, 2007 at 04:08:50AM +0100, Daniel P. Berrange wrote: > > > On Wed, Sep 19, 2007 at 04:05:53AM +0100, Daniel P. Berrange wrote: > > > > Since the pre

Re: [Libvir] PATCH: Allow remote driver to handle any connection URI

2007-09-19 Thread Daniel P. Berrange
On Wed, Sep 19, 2007 at 02:51:42PM +0100, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > >On Wed, Sep 19, 2007 at 02:08:33PM +0100, Richard W.M. Jones wrote: > /* Must not overlap with virDrvOpenFlags */ > enum virDrvOpenRemoteFlags { > VIR_DRV_OPEN_REMOTE_RO = (1 << 0), >

Re: [Libvir] PATCH 2/5: Use pkg-config for gnutls

2007-09-19 Thread Daniel P. Berrange
On Wed, Sep 19, 2007 at 04:28:48AM -0400, Daniel Veillard wrote: > On Wed, Sep 19, 2007 at 03:33:07AM +0100, Daniel P. Berrange wrote: > > On Tue, Sep 18, 2007 at 03:33:22AM -0400, Daniel Veillard wrote: > > > On Tue, Sep 18, 2007 at 02:32:59AM +0100, Daniel P. Berrange wrote: > > > > > > > > The

Re: [Libvir] PATCH 1/5: Use pkg-config for libxml

2007-09-19 Thread Daniel P. Berrange
On Wed, Sep 19, 2007 at 04:27:03AM -0400, Daniel Veillard wrote: > On Wed, Sep 19, 2007 at 03:31:50AM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 19, 2007 at 12:30:18AM +0100, Daniel P. Berrange wrote: > > > On Tue, Sep 18, 2007 at 02:29:50AM +0100, Daniel P. Berrange wrote: > > > > Currently

Re: [Libvir] PATCH: Allow remote driver to handle any connection URI

2007-09-19 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Wed, Sep 19, 2007 at 02:08:33PM +0100, Richard W.M. Jones wrote: /* Must not overlap with virDrvOpenFlags */ enum virDrvOpenRemoteFlags { VIR_DRV_OPEN_REMOTE_RO = (1 << 0), -VIR_DRV_OPEN_REMOTE_UNIX = (1 << 1), -VIR_DRV_OPEN_REMOTE_USER = (1 << 2), -V

Re: [Libvir] PATCH: Allow remote driver to handle any connection URI

2007-09-19 Thread Daniel P. Berrange
On Wed, Sep 19, 2007 at 02:08:33PM +0100, Richard W.M. Jones wrote: > >> /* Must not overlap with virDrvOpenFlags */ > >> enum virDrvOpenRemoteFlags { > >> VIR_DRV_OPEN_REMOTE_RO = (1 << 0), > >>-VIR_DRV_OPEN_REMOTE_UNIX = (1 << 1), > >>-VIR_DRV_OPEN_REMOTE_USER = (1 << 2), > >>-VIR

Re: [Libvir] PATCH: Allow remote driver to handle any connection URI

2007-09-19 Thread Richard W.M. Jones
/* Must not overlap with virDrvOpenFlags */ enum virDrvOpenRemoteFlags { VIR_DRV_OPEN_REMOTE_RO = (1 << 0), -VIR_DRV_OPEN_REMOTE_UNIX = (1 << 1), -VIR_DRV_OPEN_REMOTE_USER = (1 << 2), -VIR_DRV_OPEN_REMOTE_AUTOSTART = (1 << 3), +VIR_DRV_OPEN_REMOTE_USER = (1 << 1), +VIR_D

Re: [Libvir] PATCH: Cleanup conditionals from proxy driver in Xen code

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 04:07:28AM +0100, Daniel P. Berrange wrote: > The various xen drivers have alot of their code conditionally compiled using > #ifdef PROXY to avoid functions when built into the proxy. Without the proxy > this is no longer needed. There are a couple of functions that were onl

Re: [Libvir] PATCH: Remove Xen Proxy driver

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 06:22:58AM -0400, Daniel Veillard wrote: > On Wed, Sep 19, 2007 at 04:08:50AM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 19, 2007 at 04:05:53AM +0100, Daniel P. Berrange wrote: > > > Since the previous patch allows the remote daemon to serve all the > > > functions >

Re: [Libvir] PATCH: Remove Xen Proxy driver

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 04:08:50AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 19, 2007 at 04:05:53AM +0100, Daniel P. Berrange wrote: > > Since the previous patch allows the remote daemon to serve all the functions > > of the current Xen Proxy driver, this patch simply removes the Xen proxy > >

Re: [Libvir] PATCH: Allow remote driver to handle any connection URI

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 04:03:40AM +0100, Daniel P. Berrange wrote: > We currently have logic in the remote driver so that it handles the local > QEMU driver URIs, so they get re-directed to the daemon. It also handles > networking APIs for Xen driver. For normal APIs, Xen has the auto-spawned > se

Re: [Libvir] PATCH: Allow control over UNIX socket perms & group in libvirtd

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 03:35:50AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 18, 2007 at 04:17:32AM -0400, Daniel Veillard wrote: > > On Tue, Sep 18, 2007 at 05:38:09AM +0100, Daniel P. Berrange wrote: > > > NB, the virConf apis don't seem to recognise Octal numbers when parsing > > > the conf

Re: [Libvir] PATCH: Avahi advertisement for libvirtd

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 03:17:05AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 18, 2007 at 04:13:46AM -0400, Daniel Veillard wrote: > > On Tue, Sep 18, 2007 at 03:50:18AM +0100, Daniel P. Berrange wrote: > > > This is a serious patch at supporting Avahi advertisement of the libvirtd > > > servic

Re: [Libvir] PATCH: Allow updating of timer & file handle event watches

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 03:04:12AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 18, 2007 at 03:49:02AM -0400, Daniel Veillard wrote: > > From a stylistic POV I notice the function comment description is in the > > header files, not in the C file like others parts of libvirt, as long as > > one

Re: [Libvir] PATCH 2/5: Use pkg-config for gnutls

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 03:33:07AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 18, 2007 at 03:33:22AM -0400, Daniel Veillard wrote: > > On Tue, Sep 18, 2007 at 02:32:59AM +0100, Daniel P. Berrange wrote: > > > > > > The current GNU TLS tests in the configure script just use CHECK_HEADER > > >

Re: [Libvir] PATCH 1/5: Use pkg-config for libxml

2007-09-19 Thread Daniel Veillard
On Wed, Sep 19, 2007 at 03:31:50AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 19, 2007 at 12:30:18AM +0100, Daniel P. Berrange wrote: > > On Tue, Sep 18, 2007 at 02:29:50AM +0100, Daniel P. Berrange wrote: > > > Currently if you have a configured working directory and you touch some > > > file