Re: [Libvir] brSetForwardDelay / brSetEnableSTP

2007-11-20 Thread Daniel P. Berrange
On Tue, Nov 20, 2007 at 03:19:42PM +, Richard W.M. Jones wrote: > This code in qemu_driver.c doesn't look right to me. I think the second > should be a call to brSetEnableSTP? > > Rich. > > if (network->def->forwardDelay && > (err = brSetForwardDelay(driver->brctl, network->brid

[Libvir] brSetForwardDelay / brSetEnableSTP

2007-11-20 Thread Richard W.M. Jones
This code in qemu_driver.c doesn't look right to me. I think the second should be a call to brSetEnableSTP? Rich. if (network->def->forwardDelay && (err = brSetForwardDelay(driver->brctl, network->bridge, network->def->forwardDelay))) { qemudReportError(conn, NULL, NULL,

Re: [Libvir] [PATCH] virterror Cleanups

2007-11-20 Thread Richard W.M. Jones
Daniel Veillard wrote: On Tue, Nov 20, 2007 at 10:36:21AM +, Richard W.M. Jones wrote: Daniel Veillard wrote: On Tue, Nov 20, 2007 at 03:02:09PM +0900, Saori Fukuta wrote: Hi, The virsh command sometimes says wrong message that indicating where the error is coming from. So I have some fi

Re: [Libvir] [PATCH] virterror Cleanups

2007-11-20 Thread Daniel Veillard
On Tue, Nov 20, 2007 at 10:36:21AM +, Richard W.M. Jones wrote: > Daniel Veillard wrote: > >On Tue, Nov 20, 2007 at 03:02:09PM +0900, Saori Fukuta wrote: > >>Hi, > >> > >>The virsh command sometimes says wrong message that indicating where > >>the error is coming from. So I have some fixes for

Re: [Libvir] [PATCH] virterror Cleanups

2007-11-20 Thread Richard W.M. Jones
Daniel Veillard wrote: On Tue, Nov 20, 2007 at 03:02:09PM +0900, Saori Fukuta wrote: Hi, The virsh command sometimes says wrong message that indicating where the error is coming from. So I have some fixes for libvirt error. * Add two number for virErrorDomain (virterror.h) * Add six message i

Re: [Libvir] [PATCH] virterror Cleanups

2007-11-20 Thread Daniel Veillard
On Tue, Nov 20, 2007 at 03:02:09PM +0900, Saori Fukuta wrote: > Hi, > > The virsh command sometimes says wrong message that indicating where > the error is coming from. So I have some fixes for libvirt error. > * Add two number for virErrorDomain (virterror.h) > * Add six message indicating where