Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-03 Thread Daniel P. Berrange
On Mon, Dec 03, 2007 at 04:13:53PM -0500, Daniel Veillard wrote: > On Thu, Nov 29, 2007 at 05:19:31PM +, Daniel P. Berrange wrote: > > When the callback is invoked, it will be passed a list of > > virConnectCredentialPtr > > structs which contain details on all the credentials that the authent

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-03 Thread Daniel P. Berrange
On Mon, Dec 03, 2007 at 07:33:49PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > This patch introduces the public & driver APIs for collecting auth > > credentials via a callback. This allows username/password based auth > > schemes to be used. > ... > > diff -r e

Re: [Libvir] PATCH: 6/10: remote driver auth callback API

2007-12-03 Thread Daniel P. Berrange
On Mon, Dec 03, 2007 at 11:53:04PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > This patch implements internal driver API for authentication callbacks > > in the remote driver. It is basically a bunch of code to bridge from > > the libvirt public API for auth/cre

Re: [Libvir] PATCH: 6/10: remote driver auth callback API

2007-12-03 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > This patch implements internal driver API for authentication callbacks > in the remote driver. It is basically a bunch of code to bridge from > the libvirt public API for auth/credentials and the SASL equivalent > API. The libvirt API is very close

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-03 Thread Daniel Veillard
On Thu, Nov 29, 2007 at 05:19:31PM +, Daniel P. Berrange wrote: > This patch introduces the public & driver APIs for collecting auth > credentials via a callback. This allows username/password based auth > schemes to be used. > > This basically introduces a 3rd variant of the virConnectOpen ca

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > Without this patch, building without HAVE_AVAHI fails due to an unguarded > use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > and less maintainable), I've chosen to un-ifdef the declarations and > a few uses. The more code that we co

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-03 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > This patch introduces the public & driver APIs for collecting auth > credentials via a callback. This allows username/password based auth > schemes to be used. ... > diff -r ec2d8c632fd9 Makefile.am > --- a/Makefile.am Wed Nov 28 15:00:45 2007 -

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Daniel Veillard
On Mon, Dec 03, 2007 at 02:36:17PM +0100, Jim Meyering wrote: > Without this patch, building without HAVE_AVAHI fails due to an unguarded > use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > and less maintainable), I've chosen to un-ifdef the declarations and > a few uses. Th

Re: [Libvir] PATCH: Pull generic I/O apis out of QEMU driver

2007-12-03 Thread Daniel P. Berrange
On Mon, Dec 03, 2007 at 04:13:27PM +, Richard W.M. Jones wrote: > This breaks builds on Windows. The attached patch fixes it. Sure, add it. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/

Re: [Libvir] PATCH: Pull generic I/O apis out of QEMU driver

2007-12-03 Thread Richard W.M. Jones
This breaks builds on Windows. The attached patch fixes it. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Com

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Richard W.M. Jones
Richard W.M. Jones wrote: Strangely enough I didn't hit this problem when building on Cygwin, and I'm pretty sure they don't have avahi? Update: yes, I'm now hitting this problem, and your patch fixes it. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Addre

Re: [Libvir] testing libvirtd: don't hard-code $HOME/.libvirt/libvirt-sock

2007-12-03 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> I've written a test to exercise libvirtd a little. >> Unfortunately, if I'm already running libvirtd, that test fails >> and I can't do anything about it: >> >> $ ./libvirtd & ./libvirtd >> Failed to bind socket to '@/j/.

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Daniel P. Berrange
On Mon, Dec 03, 2007 at 02:43:30PM +, Richard W.M. Jones wrote: > Jim Meyering wrote: > >Without this patch, building without HAVE_AVAHI fails due to an unguarded > >use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > >and less maintainable), I've chosen to un-ifdef the dec

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Daniel P. Berrange
On Mon, Dec 03, 2007 at 02:36:17PM +0100, Jim Meyering wrote: > Without this patch, building without HAVE_AVAHI fails due to an unguarded > use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly > and less maintainable), I've chosen to un-ifdef the declarations and > a few uses. Th

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Without this patch, building without HAVE_AVAHI fails due to an unguarded >> use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly >> and less maintainable), I've chosen to un-ifdef the declarations and >> a

Re: [Libvir] testing libvirtd: don't hard-code $HOME/.libvirt/libvirt-sock

2007-12-03 Thread Richard W.M. Jones
Jim Meyering wrote: I've written a test to exercise libvirtd a little. Unfortunately, if I'm already running libvirtd, that test fails and I can't do anything about it: $ ./libvirtd & ./libvirtd Failed to bind socket to '@/j/.libvirt/libvirt-sock': Address already in use [Exit 2] Any obje

Re: [Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Richard W.M. Jones
Jim Meyering wrote: Without this patch, building without HAVE_AVAHI fails due to an unguarded use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly and less maintainable), I've chosen to un-ifdef the declarations and a few uses. The more code that we compile and use unconditiona

[Libvir] testing libvirtd: don't hard-code $HOME/.libvirt/libvirt-sock

2007-12-03 Thread Jim Meyering
I've written a test to exercise libvirtd a little. Unfortunately, if I'm already running libvirtd, that test fails and I can't do anything about it: $ ./libvirtd & ./libvirtd Failed to bind socket to '@/j/.libvirt/libvirt-sock': Address already in use [Exit 2] Any objection to providing an

[Libvir] [PATCH] Avoid compile failure when HAVE_AVAHI is not defined.

2007-12-03 Thread Jim Meyering
Without this patch, building without HAVE_AVAHI fails due to an unguarded use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly and less maintainable), I've chosen to un-ifdef the declarations and a few uses. The more code that we compile and use unconditionally, the fewer surpris

Re: [Libvir] PATCH: 3/10: auth configuration support

2007-12-03 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Thu, Nov 29, 2007 at 05:18:06PM +, Daniel P. Berrange wrote: >> This patch provides the ability to configure what authentication mechanism >> is used on each socket - UNIX RW, UNIX RO, TCP, and TLS sockets - all can >> have independant setti

Re: [Libvir] PATCH: Pull generic I/O apis out of QEMU driver

2007-12-03 Thread Daniel Veillard
On Sun, Dec 02, 2007 at 06:53:53PM +, Daniel P. Berrange wrote: > The QEMU driver has a number of handy APIs which I want to use from the > storage driver: > > - Read entire file in one go > - Check filename suffix > - Compare filename against name + suffix > - Check link destination > -

Re: [Libvir] Semantic of xenUnifiedType()

2007-12-03 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Fri, Nov 30, 2007 at 10:55:37AM -0500, Daniel Veillard wrote: It does the following: static const char * xenUnifiedType (virConnectPtr conn) { GET_PRIVATE(conn); int i; const char *ret; for (i = 0; i < XEN_UNIFIED_NR_DRIVERS; ++i) if (priv->

Re: [Libvir] PATCH: 9/10: disable Xen proxy automatically

2007-12-03 Thread Daniel Veillard
On Fri, Nov 30, 2007 at 10:35:17PM +, Daniel P. Berrange wrote: > On Thu, Nov 29, 2007 at 05:22:06PM +, Daniel P. Berrange wrote: > > This patch will automatically disable the Xen setuid proxy if > > PolicyKit support is found to be enabled. It is possible to > > override this and force use

Re: [Libvir] Semantic of xenUnifiedType()

2007-12-03 Thread Daniel Veillard
On Fri, Nov 30, 2007 at 03:59:29PM +, Daniel P. Berrange wrote: > On Fri, Nov 30, 2007 at 10:55:37AM -0500, Daniel Veillard wrote: > > It does the following: > > > > static const char * > > xenUnifiedType (virConnectPtr conn) > > { > > GET_PRIVATE(conn); > > int i; > > const char *

Re: [Libvir] PATCH: 1/10: SASL authentication support

2007-12-03 Thread Daniel Veillard
On Fri, Nov 30, 2007 at 10:32:40PM +, Daniel P. Berrange wrote: > On Thu, Nov 29, 2007 at 05:16:34PM +, Daniel P. Berrange wrote: > > This patch hooks up the basic authentication RPC calls, and the specific > > SASL implementation. The SASL impl can be enabled/disable via the configurre > >