Re: [Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-04 Thread Daniel P. Berrange
On Wed, Dec 05, 2007 at 12:33:24AM +0100, Jim Meyering wrote: > The first portability problem was to determine the total physical memory > available on the current system. Currently the code works only on > Linux-like systems that have /proc/meminfo of an expected form. However, > the gnulib phys

[Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-04 Thread Jim Meyering
Recently, I heard of two tricky portability problems in libvirt that are easy to solve with gnulib. Of course, gnulib provides a lot more, and is not exactly lightweight if you count "lines of code imported", but once the framework (this patch) is installed, adding an additional module is as easy

Re: [Libvir] PATCH: 7/10: python auth callback API

2007-12-04 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > This adds a binding for the virConnectOpenAuth() api in the python > API. This allows a python function to be used as the callback. > > This short example code illustrates the use of the API from a > python app which wants to support username/passwo

Re: [Libvir] [PATCH] Remove curses, don't require readline

2007-12-04 Thread Jim Meyering
Daniel Veillard <[EMAIL PROTECTED]> wrote: > On Tue, Dec 04, 2007 at 05:39:17PM +, Richard W.M. Jones wrote: >> This patch removes checking for curses/ncurses. It is never used. >> >> It also allows libvirt to be compiled without readline support. If >> readline support is not available then

Re: [Libvir] [PATCH] No rpcgen at all

2007-12-04 Thread Daniel Veillard
On Tue, Dec 04, 2007 at 05:44:34PM +, Richard W.M. Jones wrote: > If there is no 'rpcgen' program at all then ./configure fails. It > should not, because rpcgen is not necessary to build libvirt. Then makes sense, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/

Re: [Libvir] [PATCH] Remove curses, don't require readline

2007-12-04 Thread Daniel Veillard
On Tue, Dec 04, 2007 at 05:39:17PM +, Richard W.M. Jones wrote: > This patch removes checking for curses/ncurses. It is never used. > > It also allows libvirt to be compiled without readline support. If > readline support is not available then the only difference is that > 'virsh' will be

[Libvir] [PATCH] Miscellaneous fixes to #includes

2007-12-04 Thread Richard W.M. Jones
(1) #include ---> #include "libvirt/*.h" (2) src/internal.h has become a dumping ground for all sorts of includes. Removed the ones which are not actually used in this file (ie. almost all of them) and moved them down into the two files which actually needed them. (3) Remove , which is app

Re: [Libvir] PATCH: strip auto-generated VIF names from XML

2007-12-04 Thread Daniel Veillard
On Tue, Dec 04, 2007 at 05:49:10PM +, Daniel P. Berrange wrote: > On Tue, Dec 04, 2007 at 05:40:44PM +, Richard W.M. Jones wrote: > > Daniel P. Berrange wrote: > > >For the QEMU / KVM driver, if the user doesn't specify an explicit name for > > >the TAP device associated with a virtual NIC,

Re: [Libvir] PATCH: strip auto-generated VIF names from XML

2007-12-04 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Tue, Dec 04, 2007 at 05:40:44PM +, Richard W.M. Jones wrote: Daniel P. Berrange wrote: For the QEMU / KVM driver, if the user doesn't specify an explicit name for the TAP device associated with a virtual NIC, we auto-generate one with a name vnetXXX. You can se

Re: [Libvir] PATCH: strip auto-generated VIF names from XML

2007-12-04 Thread Daniel P. Berrange
On Tue, Dec 04, 2007 at 05:40:44PM +, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > >For the QEMU / KVM driver, if the user doesn't specify an explicit name for > >the TAP device associated with a virtual NIC, we auto-generate one with a > >name vnetXXX. You can see this if you dump

[Libvir] [PATCH] No rpcgen at all

2007-12-04 Thread Richard W.M. Jones
If there is no 'rpcgen' program at all then ./configure fails. It should not, because rpcgen is not necessary to build libvirt. Patch fixes. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Wind

Re: [Libvir] [PATCH] Remove curses, don't require readline

2007-12-04 Thread Daniel P. Berrange
On Tue, Dec 04, 2007 at 05:39:17PM +, Richard W.M. Jones wrote: > This patch removes checking for curses/ncurses. It is never used. > > It also allows libvirt to be compiled without readline support. If > readline support is not available then the only difference is that > 'virsh' will be

Re: [Libvir] PATCH: strip auto-generated VIF names from XML

2007-12-04 Thread Richard W.M. Jones
Daniel P. Berrange wrote: For the QEMU / KVM driver, if the user doesn't specify an explicit name for the TAP device associated with a virtual NIC, we auto-generate one with a name vnetXXX. You can see this if you dump XML for a running QEMU guest. Unfortunately if you dump XML, make a change an

[Libvir] [PATCH] Remove curses, don't require readline

2007-12-04 Thread Richard W.M. Jones
This patch removes checking for curses/ncurses. It is never used. It also allows libvirt to be compiled without readline support. If readline support is not available then the only difference is that 'virsh' will be built without it -- in other words, command line editing will not work in vi

[Libvir] PATCH: strip auto-generated VIF names from XML

2007-12-04 Thread Daniel P. Berrange
For the QEMU / KVM driver, if the user doesn't specify an explicit name for the TAP device associated with a virtual NIC, we auto-generate one with a name vnetXXX. You can see this if you dump XML for a running QEMU guest. Unfortunately if you dump XML, make a change and then feed it back in with

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-04 Thread Daniel Veillard
On Tue, Dec 04, 2007 at 04:06:32PM +, Daniel P. Berrange wrote: > On Tue, Dec 04, 2007 at 10:46:50AM -0500, Daniel Veillard wrote: > > On Tue, Dec 04, 2007 at 12:57:39PM +, Richard W.M. Jones wrote: > > > Daniel P. Berrange wrote: > > > > virConnectPtr virConnectOpenAuth (con

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-04 Thread Daniel Veillard
On Tue, Dec 04, 2007 at 03:50:46PM +, Richard W.M. Jones wrote: > Daniel Veillard wrote: > >On Tue, Dec 04, 2007 at 12:57:39PM +, Richard W.M. Jones wrote: > >>Daniel P. Berrange wrote: > >>>virConnectPtr virConnectOpenAuth (const char *name, > >>>

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-04 Thread Daniel P. Berrange
On Tue, Dec 04, 2007 at 10:46:50AM -0500, Daniel Veillard wrote: > On Tue, Dec 04, 2007 at 12:57:39PM +, Richard W.M. Jones wrote: > > Daniel P. Berrange wrote: > > > virConnectPtr virConnectOpenAuth (const char *name, > > >virConnectAu

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-04 Thread Richard W.M. Jones
Daniel Veillard wrote: On Tue, Dec 04, 2007 at 12:57:39PM +, Richard W.M. Jones wrote: Daniel P. Berrange wrote: virConnectPtr virConnectOpenAuth (const char *name, virConnectAuthPtr auth,

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-04 Thread Daniel Veillard
On Tue, Dec 04, 2007 at 12:57:39PM +, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > > virConnectPtr virConnectOpenAuth (const char *name, > > virConnectAuthPtr auth, > > int flags)

Re: [Libvir] Port forwarding

2007-12-04 Thread Daniel P. Berrange
On Tue, Dec 04, 2007 at 01:40:51PM +, Daniel P. Berrange wrote: > On Tue, Dec 04, 2007 at 12:08:15PM +, Richard W.M. Jones wrote: > > What do people think about adding port forwarding to network configurations? > > A good idea. Mark had forwarding on his original spec, but it was not > im

Re: [Libvir] Port forwarding

2007-12-04 Thread Daniel P. Berrange
On Tue, Dec 04, 2007 at 12:08:15PM +, Richard W.M. Jones wrote: > What do people think about adding port forwarding to network configurations? A good idea. Mark had forwarding on his original spec, but it was not implemented at the time. > At the moment it's unnecessarily difficult to connec

Re: [Libvir] PATCH: 5/10: public auth callback API

2007-12-04 Thread Richard W.M. Jones
Daniel P. Berrange wrote: virConnectPtr virConnectOpenAuth (const char *name, virConnectAuthPtr auth, int flags); I'm a fan of callers passing in the size of the structure (as they

[Libvir] Port forwarding

2007-12-04 Thread Richard W.M. Jones
What do people think about adding port forwarding to network configurations? At the moment it's unnecessarily difficult to connect to (eg.) sshd port or remote desktop port on a virtual machine running under the virtual network configuration. If those ports could be mapped to consecutive port

Re: [Libvir] [PATCH] qemud/qemud.c (qemudInitPaths): Remove unused code.

2007-12-04 Thread Richard W.M. Jones
Jim Meyering wrote: Here, "base" is set, gets memory allocated for it, and is written to, then freed, but it is never used. Yes, strange. That code was patched a great deal to change the way that paths were constructed so obviously this dead code was left in somewhere along the line. Rich.

[Libvir] [PATCH] qemud/qemud.c (qemudInitPaths): Remove unused code.

2007-12-04 Thread Jim Meyering
Here, "base" is set, gets memory allocated for it, and is written to, then freed, but it is never used. diff --git a/qemud/qemud.c b/qemud/qemud.c index f88ed42..6b515d9 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -644,10 +644,8 @@ static int qemudInitPaths(struct qemud_server *server,