Re: [Libvir] [PATCH] Pull vc-list-files from gnulib, and update.

"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > The hg locate command does look like the better bet to me - particularly > becasue it allows explicit filtering - manifest gives you all files whether > you want them or not. Thanks for looking at it. I've committed that change. -- Libvir-list

Re: [Libvir] virsh vncdisplay fix

On Thu, Jan 31, 2008 at 07:48:55PM +, Daniel P. Berrange wrote: > I've just looked at the behaviour on Xen 3.2.0 and it doesn't match > what you describe - there's always a type=vnc added even for legacy > config syntax. So I think this must be a 3.0.4 specific XenD bug. I > don't have any 3.0

[Libvir] New XML attributes for virtio

Hi! I filed https://bugzilla.redhat.com/show_bug.cgi?id=431063 yesterday to track this issue. Quoting the bug report: "To use the new virtio capabilites available in kvm 60, special command line paramaters need to be passed to kvm. There should be a way to specify that a device should use virti

[Libvir] [PATCH] don't use xen functions when USE_XEN is undefined

diff --git a/tests/statstest.c b/tests/statstest.c index 4c19833..6213da8 100644 --- a/tests/statstest.c +++ b/tests/statstest.c @@ -12,7 +12,7 @@ static void testQuietError(void *userData ATTRIBUTE_UNUSED, virErrorPtr error AT /* nada */ } -#ifdef __linux__ +#if __linux__ && WITH_XEN st

Re: [Libvir] avoid used-uninitialized errors in test driver

On Wed, Jan 30, 2008 at 03:09:57PM +0100, Jim Meyering wrote: > Here's another distracting and easily avoided error: [...] > This patch fixes it: > > * src/test.c (testOpenFromFile): avoid used-uninitialized errors in test > driver +1 thanks ! Daniel -- Red Hat Virtualization group http

Re: [Libvir] libvirt.c: avoid a double-free upon do_open failure

On Wed, Jan 30, 2008 at 02:58:11PM +0100, Jim Meyering wrote: > With a contrived example using more than 20 (the max permitted by > the testing framework) domains, I got a double-free error: [...] > here's one way to fix it: > > diff --git a/src/libvirt.c b/src/libvirt.c > index defadc1..c19565f 1

Re: [Libvir] [PATCH] test.c: Avoid segfault upon malloc failure, and plug a leak.

On Wed, Jan 30, 2008 at 02:46:00PM +0100, Jim Meyering wrote: > Testing exposed a tiny leak: > > $ valgrind --leak-check=full ./virsh --connect \ > test://$PWD/../docs/testnode.xml save fc4 /dev/null [...] > --- > src/test.c |9 - > 1 files changed, 8 insertions(+), 1 deletions(

Re: [Libvir] [PATCH] Pull vc-list-files from gnulib, and update.

On Fri, Feb 01, 2008 at 02:01:47PM +0100, Jim Meyering wrote: > "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > > Jim Meyering wrote: > >> Now that I've added the vc-list-files script to gnulib, > >> this patch makes libvirt's bootstrap pull it from there. > >> > >> Changes from the previous vers

Re: [Libvir] [PATCH] Pull vc-list-files from gnulib, and update.

"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Now that I've added the vc-list-files script to gnulib, >> this patch makes libvirt's bootstrap pull it from there. >> >> Changes from the previous version of the script: >> >> I reintroduced support for mercurial (only ligh

Re: [Libvir] [PATCH] Pull vc-list-files from gnulib, and update.

Jim Meyering wrote: Now that I've added the vc-list-files script to gnulib, this patch makes libvirt's bootstrap pull it from there. Changes from the previous version of the script: I reintroduced support for mercurial (only lightly tested), and rearranged the directory-existence tests so g