Hi all,
I have a question about compatibility issues when submitting changes
to both Xen and libvirt.
First, some background: I'm seeing a problem with virsh detach-disk.
It'll detach a disk from a running domain, but not update the domain's
configuration, so the disk will be back when the
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> This patch provides a couple of helper APIs used by the forthcoming
> driver backends.
>
>- virStorageBackendUpdateVolInfo - take a filename and virStorageVolPtr
> and update the capacity/allocation information based on the file
> stat
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> diff -r 739490b4a2f6 src/storage_backend_fs.c
> --- /dev/null Thu Jan 01 00:00:00 1970 +
> +++ b/src/storage_backend_fs.cThu Feb 07 13:44:25 2008 -0500
...
> +/* Short-circuit is already mounted */
Barely worth mentioning, but it th
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
...
> +if (virRun(conn, (char**)mntargv, NULL) < 0) {
> +free(src);
> +virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, "cannot mount %s
> on %s: %d",
> + src, pool->def->target.path, strerror(errno
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> diff -r 739490b4a2f6 src/storage_backend_fs.c
> --- /dev/null Thu Jan 01 00:00:00 1970 +
> +++ b/src/storage_backend_fs.cThu Feb 07 13:44:25 2008 -0500
...
> +/* Optionally extract capacity from file */
> +if (fileTypeInf
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> virStorageReportError(NULL, VIR_ERR_INTERNAL_ERROR, "missing backend for
> pool type %d", type);
Not specific to this patch, but any new error-reporting functions
like virStorageReportError need to be added to the err_func_re in
Makefile.main
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> On Fri, Feb 15, 2008 at 07:52:37PM +0100, Jim Meyering wrote:
>> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
...
>> Shouldn't size be 1 larger? i.e.,
>>
>> unsigned long long size =
>> dev->freeExtents[i].end -
>>
On Fri, Feb 15, 2008 at 07:52:37PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> > +static int virStorageBackendDiskCreateVol(virConnectPtr conn,
> > + virStoragePoolObjPtr pool,
> > +
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> +static int virStorageBackendDiskCreateVol(virConnectPtr conn,
> + virStoragePoolObjPtr pool,
> + virStorageVolDefPtr vol)
> +{
> +int i;
> +char start[100], e
On Fri, Feb 15, 2008 at 05:11:03PM +0100, Jim Meyering wrote:
> > +static const char *virStorageBackendDiskVolFormatToString(virConnectPtr
> > conn,
> > + int format) {
> > +switch (format) {
> > +case VIR_STORAGE_VOL_DISK_NONE:
> >
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
...
> diff -r 4c283aac5fd6 src/storage_backend_disk.c
> --- /dev/null Thu Jan 01 00:00:00 1970 +
> +++ b/src/storage_backend_disk.c Thu Feb 07 16:51:32 2008 -0500
...
> +static int virStorageBackendDiskVolFormatFromString(virConnectPtr conn,
On Tue, Feb 12, 2008 at 04:33:03AM +, Daniel P. Berrange wrote:
> This patch adds support for the storage APIs to the remote driver
> client end. As with the network driver, things are configured such
> that all virtualization drivers will end up delegating to the remote
> driver for storage AP
On Tue, Feb 12, 2008 at 04:33:42AM +, Daniel P. Berrange wrote:
> This extends the generator / manual bindings to implement all the
> storage APIs. Most are handle automatically, and those which are
> not, pretty much follow the existing pattern for virDomain and
> virNetwork APIs.
>
> genera
On Fri, Feb 15, 2008 at 10:10:24AM -0500, Daniel Veillard wrote:
> On Tue, Feb 12, 2008 at 04:33:03AM +, Daniel P. Berrange wrote:
> > This patch adds support for the storage APIs to the remote driver
> > client end. As with the network driver, things are configured such
> > that all virtualiza
On Tue, Feb 12, 2008 at 04:32:20AM +, Daniel P. Berrange wrote:
> This patch implements support for the storage APIs in the remote
> driver, server end. This is just the boilerplate code glueing the
> XDR handlers into the libvirt APIs.
Seems a direct result of the APIs, then +1 after regene
On Fri, Feb 15, 2008 at 11:03:47AM +, Mark McLoughlin wrote:
> Hi,
> Just a heads-up ... trying to build with -Werror on Fedora rawhide, I
> see:
Yep, I've got a patch for this pending - just need to get my rawhide box
working again to test properly.
Dan
--
|=- Red Hat, Engineering, Em
Hi,
Just a heads-up ... trying to build with -Werror on Fedora rawhide, I
see:
cc1: warnings being treated as errors
remote.c: In function 'remoteDispatchAuthPolkit':
remote.c:2661: error: 'polkit_context_can_caller_do_action' is deprecated
(declared at /usr/include/PolicyKit/polkit/polki
17 matches
Mail list logo
