Re: [Libvir] PATCH: 1/16: public API

2008-02-19 Thread Daniel Veillard
On Wed, Feb 20, 2008 at 04:00:39AM +, Daniel P. Berrange wrote: > On Tue, Feb 12, 2008 at 04:30:07AM +, Daniel P. Berrange wrote: > > This defines the public API for the storage pool and volume support. > > The naming of the APIs follows the example set by the network and > > domain APIs wh

Re: [Libvir] PATCH: 0/16: Storage management APIs

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:28:29AM +, Daniel P. Berrange wrote: > The patch series that follows provides storage management APIs for dealing > with local directories, local filesystems, remote filesystems, logical > volumes (LVM), disk partitioning, and iSCSI. It will also soon support > SCSI h

Re: [Libvir] PATCH: 14/16: disk partition backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:40:26AM +, Daniel P. Berrange wrote: > This implements a storage pool for partitioning local disks. > It uses parted as the tool for reading & writing disk partitions. > Since parted is GPLv3, we cannot link against the code directly. > So, this driver calls out to th

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:39:25AM +, Daniel P. Berrange wrote: > This provides a storage pool using the iSCSI protocol. Since there > is no API for iSCSI it is implemented by simply shelling out to the > iscsiadm command line tool. A pool corresponds to a single target > on the iSCSI server. S

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:38:39AM +, Daniel P. Berrange wrote: > This patch implements a storage pool based on logical volume > management. The underlying implementation calls out to LVM > on Linux. A future implementation for Solaris would use the > ZFS pool support to achieve the same functi

Re: [Libvir] PATCH: 11/16: directory/fs/netfs backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:37:57AM +, Daniel P. Berrange wrote: > This patch implements 3 storage pools in one go. This provides > the base level 'directory' storage pool, where an existing directory > contains files as volumes. This is guarenteed to be available on > any OS since it just uses

Re: [Libvir] PATCH: 10/16: general purpose helper APIs

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:37:08AM +, Daniel P. Berrange wrote: > This patch provides a couple of helper APIs used by the forthcoming > driver backends. > >- virStorageBackendUpdateVolInfo - take a filename and virStorageVolPtr > and update the capacity/allocation information based on

Re: [Libvir] PATCH: 5/16: remote driver client

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:33:03AM +, Daniel P. Berrange wrote: > This patch adds support for the storage APIs to the remote driver > client end. As with the network driver, things are configured such > that all virtualization drivers will end up delegating to the remote > driver for storage AP

Re: [Libvir] PATCH: 1/16: public API

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:30:07AM +, Daniel P. Berrange wrote: > This defines the public API for the storage pool and volume support. > The naming of the APIs follows the example set by the network and > domain APIs whereever the logical functions match. The main change > since previous iterat

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... >> > +for (i = 0 ; i < pool->def->source.ndevice ; i++) { >> > +int fd; >> > +char zeros[512]; >> > +memset(zeros, 0, sizeof(zeros)); ... >> is it really 512 or the block size on the device used ? But 512 is >> probab

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Daniel Veillard
On Tue, Feb 19, 2008 at 12:46:28PM +, Daniel P. Berrange wrote: > On Tue, Feb 19, 2008 at 03:43:11AM -0500, Daniel Veillard wrote: > > > + > > > +/* > > > + * LVM requires that the first 512 bytes are blanked if using > > > + * a whole disk as a PV. So we just blank them

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 19, 2008 at 03:43:11AM -0500, Daniel Veillard wrote: > > diff -r 31abfd8687b3 qemud/qemud.c > > --- a/qemud/qemud.c Thu Feb 07 13:44:25 2008 -0500 > > +++ b/qemud/qemud.c Thu Feb 07 14:17:16 2008 -0500 > > @@ -2089,7 +2089,9 @@ int main(int argc, char **argv) { > > > > if (pipe(s

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 19, 2008 at 08:45:03AM +, Mark McLoughlin wrote: > > On Tue, 2008-02-19 at 03:24 -0500, Daniel Veillard wrote: > > > +# For ISCSI driver > > > +Requires: iscsi-initiator-utils > > > > Apparently iscsi-initiator-utils exists in RHEL 4 (and 3 but > > we are not tergetting that old

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-19 Thread Daniel Veillard
On Tue, Feb 19, 2008 at 10:09:20AM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > On Mon, Feb 18, 2008 at 09:51:28AM -0500, Daniel Veillard wrote: > >> On Tue, Feb 12, 2008 at 04:36:04AM +, Daniel P. Berrange wrote: > ... > >> > +if (xml) > >> > +xm

Re: [Libvir] Deprecated PolicyKit function

2008-02-19 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > The attached patch fixes the deprecation warnings. ... > +qemudLog(QEMUD_ERR, > + "Policy kit failed to check authorization %d %s", Looks good, and got no warnings from my rawhide system. You'll want to mark that str

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-19 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Mon, Feb 18, 2008 at 09:51:28AM -0500, Daniel Veillard wrote: >> On Tue, Feb 12, 2008 at 04:36:04AM +, Daniel P. Berrange wrote: ... >> > +if (xml) >> > +xmlFreeDoc(xml); >> > +return NULL; >> > +} >> >> since we try to remo

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-19 Thread Mark McLoughlin
On Tue, 2008-02-19 at 03:24 -0500, Daniel Veillard wrote: > > +# For ISCSI driver > > +Requires: iscsi-initiator-utils > > Apparently iscsi-initiator-utils exists in RHEL 4 (and 3 but > we are not tergetting that old) it would be great if that worked > there too. I can't remember when

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:38:39AM +, Daniel P. Berrange wrote: > This patch implements a storage pool based on logical volume > management. The underlying implementation calls out to LVM > on Linux. A future implementation for Solaris would use the > ZFS pool support to achieve the same functi

Re: [Libvir] PATCH: 16/16: website documentation

2008-02-19 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:42:10AM +, Daniel P. Berrange wrote: > This patch adds a new 'storage.html' page to the website giving > examples of the XML format for each pool type, the XML format for > volumes, a description of all XML elements, and other storage pool > specific information. G

Re: [Libvir] PATCH: 15/16: stub test driver

2008-02-19 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:41:09AM +, Daniel P. Berrange wrote: > This just stubs out an empty no-op storage driver impl for the test > driver. This is basically to prevent the ensure the test suite does > not try to contact the daemon for storage APIs, which would cause > tests to fail. > > T

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-19 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:39:25AM +, Daniel P. Berrange wrote: > This provides a storage pool using the iSCSI protocol. Since there > is no API for iSCSI it is implemented by simply shelling out to the > iscsiadm command line tool. A pool corresponds to a single target > on the iSCSI server. S