Re: [Libvir] PATCH 0/4: QEMU test suite extensions

2008-04-18 Thread Daniel P. Berrange
This patch updates the QEMU test suites to use the new virtTestDifference function, and include tests for the serial/parallel device options. qemuxml2argvdata/qemuxml2argv-boot-cdrom.args|2 qemuxml2argvdata/qemuxml2argv-boot-floppy.args |2 qemuxml2argvdata/qemuxml2argv-b

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-18 Thread Daniel P. Berrange
This patch updates Xen HVM to allow use of serial ¶llel ports, though XenD limits you to single one of each even though QEMU supports many. It also updates the tag to support new syntax extensions. xend_internal.c | 256 +++- xend_internal.h

Re: [Libvir] PATCH 1/4: QEMU driver char device support

2008-04-18 Thread Daniel P. Berrange
This supports the serial/character devices in QEMU. It is complete except for fact that I don't extract the TTY path for type='pty'. This needs addressing before merging internal.h |4 qemu_conf.c | 646 +++- qemu_conf.h | 60 +

[Libvir] PATCH 0/4: Serial / parallel device support

2008-04-18 Thread Daniel P. Berrange
This patch series adds support for serial & parallel devices to the QEMU driver, and updates the Xen driver to support new syntax for HVM guests too. The following syntax is used. Anywhere you see 'serial', you can equally use 'console' or 'parallel'. The 'serial' is for real serial devices only,

Re: [Libvir] PATCH: Make test suite debug mode more friendly

2008-04-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > When the test suites fail, we have a DEBUG_TESTS=1 environment variable > which can be set to show the full XML doc or string pair that failed to > match. Unfortunately these docs can be quite large, so it is hard to > spot the difference between th

Re: [Libvir] PATCH: Use macros to remove duplicate test code

2008-04-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > Index: test_conf.sh > === > RCS file: /data/cvs/libvirt/tests/test_conf.sh,v > retrieving revision 1.4 > diff -u -p -r1.4 test_conf.sh > --- test_conf.sh 5 Feb 2008 19:27:37 -0

[Libvir] FYI, typo fix

2008-04-18 Thread Jim Meyering
I updated and couldn't compile. Here's the fix: avoid compile error when is absent * src/internal.h (HAVE_PTHREAD_H): Test with "#ifdef", not "#if". diff --git a/src/internal.h b/src/internal.h index 6b2b633..6bed477 100644 --- a/src/internal.h +++ b/src/internal.h @@ -12,7 +12,7

Re: [Libvir] PATCH: Use macros to remove duplicate test code

2008-04-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > The test suite files contain alot of boilerplate duplicated code. With a > few more macros I can significantly cut down the size of the test code. > > I also change abs_top_srcdir to abs_srcdir, and automatically initialize > it to 'getcwd' if the e

Re: [Libvir] PATCH: Make test suite debug mode more friendly

2008-04-18 Thread Richard W.M. Jones
On Fri, Apr 18, 2008 at 01:28:55AM +0100, Daniel P. Berrange wrote: > When the test suites fail, we have a DEBUG_TESTS=1 environment variable > which can be set to show the full XML doc or string pair that failed to > match. Unfortunately these docs can be quite large, so it is hard to > spot the d

Re: [Libvir] PATCH: Use macros to remove duplicate test code

2008-04-18 Thread Richard W.M. Jones
On Fri, Apr 18, 2008 at 01:32:49AM +0100, Daniel P. Berrange wrote: > The test suite files contain alot of boilerplate duplicated code. With a > few more macros I can significantly cut down the size of the test code. > > I also change abs_top_srcdir to abs_srcdir, and automatically initialize > it