Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-12 Thread Stefan de Konink
Daniel P. Berrange schreef: There is indentation whitespace damage here. Please check the HACKING file for details of how to setup *vim* and emacs to comply with libvirt indentation rules automatically. What is the vim suggestion made there? I see emacs en GNU indent. Stefan -- Libvir-list m

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-12 Thread Stefan de Konink
On Tue, 13 May 2008, Daniel P. Berrange wrote: > On Sat, May 10, 2008 at 07:42:51PM +0200, Stefan de Konink wrote: > > About mdns, do you think it would be a good thing to *not* follow the > > Avahi advise and explicitly set the host the service is running on? In my > > humble opinion I think that

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-12 Thread Atsushi SAKAI
Hi, Dan I think the qemu_driver should check KVM_API_VERSION for SMP support. How do you think? I am worrying about MAX_VCPUS=16 changes to 32 in future. Thanks Atsushi SAKAI "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > I don't bother trying to detect old versions of KVM which are UP only

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-12 Thread Daniel P. Berrange
On Sat, May 10, 2008 at 07:42:51PM +0200, Stefan de Konink wrote: > About mdns, do you think it would be a good thing to *not* follow the > Avahi advise and explicitly set the host the service is running on? In my > humble opinion I think that would be a wise decision. > > host The host this serv

[libvirt] PATCH: Fix default bus type selection for disks

2008-05-12 Thread Daniel P. Berrange
We recently added a new bus type attribute to disks to select between IDE, SCSI, etc. This attribute is optional and many tools won't set it. In such cases we default to IDE, which is clearly wrong. This patch updates it to pick the default bus based on the prefix of the disk target name, so that i

[libvirt] PATCH: Support bootloaders in QEMU driver

2008-05-12 Thread Daniel P. Berrange
The QEMU driver supports booting Xen guests via the Xenner hypervisor. For such paravirtualized guests there is no regular BIOS, so the bootloader has to be run on the host. Xenner defaults to pygrub, but since libvirt has a generic syntax for bootloaders, we should use it. So this patch adds sup

[libvirt] PATCH: Allow xen bus type for disks in QEMU driver

2008-05-12 Thread Daniel P. Berrange
With the recent work to support -drive arg, the QEMU driver now supports many types of bus for disks attached to VMs - ide, scsi, virtio. This patches adds another type 'xen' for the Xen blkfront driver. b/tests/qemuxml2argvdata/qemuxml2argv-disk-xenvbd.args |1 b/tests/qemuxml2argvdata/qem

[libvirt] PATCH: Allow Xen bus type for input devices in QEMU driver

2008-05-12 Thread Daniel P. Berrange
The Xenner virtual machine supportes a bus type of 'xen' for input devices, corresponding to the paravirtualized mouse device. QEMU currently rejects any bus type which isn't ps2 or usb. This patch makes it allow 'xen' as a valid bus type for Xenner guests. b/tests/qemuxml2argvdata/qemuxml2argv-i

[libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-12 Thread Daniel P. Berrange
Libvirt currently returns '1' when asked for the maximum number of VCPUs supported for KVM guests. KVM long long ago gained SMP support, so this patch fixes it to return 16, whcih is the current supported number. I don't bother trying to detect old versions of KVM which are UP only because I find

[libvirt] PATCH: Pass -name argument to QEMU

2008-05-12 Thread Daniel P. Berrange
This patch makes libvirt pass the -name argumet to QEMU it if it supported by the QEMU binary in question. THis allows QEMU to set the VNC title and allows Xenner to set the Xen guest name in xenstore. src/qemu_conf.c | 19 ++- src/qemu_conf.h