Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-13 Thread Daniel P. Berrange
On Wed, May 14, 2008 at 11:23:08AM +0900, Atsushi SAKAI wrote: > Hi, Dan > > Thank you for commenting. > Of course, I agree your point > and that you are commiting it. > > I am commenting it > just because 2 month is not old ago in my feeling. > > > Here Is the memo for my understanding. > (S

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-13 Thread Atsushi SAKAI
Hi, Dan Thank you for commenting. Of course, I agree your point and that you are commiting it. I am commenting it just because 2 month is not old ago in my feeling. Here Is the memo for my understanding. (Since I am not familiar with KVM) 2007/07/19 kvm-30 Guest SMP support (Parameter(KV

Re: [libvirt] PATCH: Remove use of strcmp, etc

2008-05-13 Thread Daniel P. Berrange
On Tue, May 13, 2008 at 02:56:19PM +0200, Jim Meyering wrote: > > I finished the job with the following. > That exposed another binary difference (which is fine): > > -if (STRNEQ(str, "linux")) > +if (STREQ(str, "hvm")) > hvm = 1; Yes, this is technically a no-op change if peopl

[libvirt] [ANNOUNCE] virt-df 2.1.0 - a 'df' tool for virtual guests

2008-05-13 Thread Richard W.M. Jones
I'm pleased to announce the most recent release of virt-df (2.1.0). Virt-df is 'df' for virtual guests. Run the program on the host / dom0 to display disk space used and available on all partitions on all guests. You don't need to run any sort of program/agent within the guest. Home page:

Re: [libvirt] listen_tls not enabling libvirtd to listen for tls

2008-05-13 Thread Kenneth Nagin
> Kenneth Nagin wrote: > > libvirtd is not listening for TLS connection by default. > > Setting 'listen_tls = 1' in /etc/libvirt/libvirtd.conf does not help > > either. > > However, starting 'libvirtd --listen' does work. > > I'm running Fedora 8. I prefer to use the configuration file since > >

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-13 Thread Cole Robinson
Daniel P. Berrange wrote: > On Tue, May 13, 2008 at 01:29:35PM +0900, Atsushi SAKAI wrote: >> Hi, Dan >> >> I think the qemu_driver should check KVM_API_VERSION for SMP support. >> How do you think? >> I am worrying about MAX_VCPUS=16 changes to 32 in future. > > If it increases to 32, then we sho

Re: [libvirt] PATCH: Fix default bus type selection for disks

2008-05-13 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Tue, May 13, 2008 at 10:31:10AM +0200, Jim Meyering wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> >> in spite of the proliferation of casts -- >> That's not good for readability/maintainability. >> >> What do you think of this? >>

Re: [libvirt] PATCH: Remove use of strcmp, etc

2008-05-13 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> On Fri, May 09, 2008 at 10:42:08PM +0100, Daniel P. Berrange wrote: >>> On Fri, May 09, 2008 at 11:40:39PM +0200, Jim Meyering wrote: >>> > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >>> > >>> > > This

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-13 Thread Stefan de Konink
Stefan de Konink schreef: On Tue, 13 May 2008, Stefan de Konink wrote: On Sat, May 10, 2008 at 07:42:51PM +0200, Stefan de Konink wrote: About mdns, do you think it would be a good thing to *not* follow the Avahi advise and explicitly set the host the service is running on? In my humble opinio

Re: [libvirt] PATCH: Fix default bus type selection for disks

2008-05-13 Thread Daniel P. Berrange
On Tue, May 13, 2008 at 10:31:10AM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > in spite of the proliferation of casts -- > That's not good for readability/maintainability. > > What do you think of this? > > static inline char *xml2char(xmlChar *x) { retur

Re: [libvirt] PATCH: Support bootloaders in QEMU driver

2008-05-13 Thread Daniel P. Berrange
On Tue, May 13, 2008 at 09:07:45AM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > The QEMU driver supports booting Xen guests via the Xenner hypervisor. For > > such paravirtualized guests there is no regular BIOS, so the bootloader has > > to be run on the host.

Re: [libvirt] PATCH: Fix KVM maximum vCPU count

2008-05-13 Thread Daniel P. Berrange
On Tue, May 13, 2008 at 01:29:35PM +0900, Atsushi SAKAI wrote: > Hi, Dan > > I think the qemu_driver should check KVM_API_VERSION for SMP support. > How do you think? > I am worrying about MAX_VCPUS=16 changes to 32 in future. If it increases to 32, then we should certainly check based on somethi

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-13 Thread Stefan de Konink
On Tue, 13 May 2008, Stefan de Konink wrote: > > On Sat, May 10, 2008 at 07:42:51PM +0200, Stefan de Konink wrote: > > > About mdns, do you think it would be a good thing to *not* follow the > > > Avahi advise and explicitly set the host the service is running on? In my > > > humble opinion I thin

[libvirt] [PATCH] avoid "not a string literal..." warnings

2008-05-13 Thread Jim Meyering
FYI, I've just checked in this change: avoid "not a string literal..." warnings * src/qemu_conf.c (qemudParseInterfaceXML): Add "%s". (qemudBuildCommandLine, qemudGenerateXML): Likewise. diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 2a29382..9772721 100644 --- a/src

Re: [libvirt] PATCH: Fix default bus type selection for disks

2008-05-13 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > We recently added a new bus type attribute to disks to select between IDE, > SCSI, etc. This attribute is optional and many tools won't set it. In such > cases we default to IDE, which is clearly wrong. This patch updates it to > pick the default bu

Re: [libvirt] listen_tls not enabling libvirtd to listen for tls

2008-05-13 Thread Chris Lalancette
Kenneth Nagin wrote: > libvirtd is not listening for TLS connection by default. > Setting 'listen_tls = 1' in /etc/libvirt/libvirtd.conf does not help > either. > However, starting 'libvirtd --listen' does work. > I'm running Fedora 8. I prefer to use the configuration file since > it is automati

Re: [libvirt] PATCH: Allow Xen bus type for input devices in QEMU driver

2008-05-13 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > The Xenner virtual machine supportes a bus type of 'xen' for input devices, > corresponding to the paravirtualized mouse device. QEMU currently rejects > any bus type which isn't ps2 or usb. This patch makes it allow 'xen' as a > valid bus type for

Re: [libvirt] PATCH: Allow xen bus type for disks in QEMU driver

2008-05-13 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > With the recent work to support -drive arg, the QEMU driver now supports > many types of bus for disks attached to VMs - ide, scsi, virtio. This patches > adds another type 'xen' for the Xen blkfront driver. ... > diff -r f6b47c9986b9 src/util.c > -

Re: [libvirt] PATCH: Support bootloaders in QEMU driver

2008-05-13 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > The QEMU driver supports booting Xen guests via the Xenner hypervisor. For > such paravirtualized guests there is no regular BIOS, so the bootloader has > to be run on the host. Xenner defaults to pygrub, but since libvirt has a > generic syntax f